linux-mtd.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] mtd: cfi: add fixups to support MT28FW02GBBA1HPC
@ 2022-10-19 15:49 Andreas Oetken
  2022-10-19 15:58 ` Greg Kroah-Hartman
  2022-10-19 16:18 ` Tokunori Ikegami
  0 siblings, 2 replies; 4+ messages in thread
From: Andreas Oetken @ 2022-10-19 15:49 UTC (permalink / raw)
  To: Vignesh Raghavendra, linux-mtd
  Cc: Miquel Raynal, Richard Weinberger, Greg Kroah-Hartman,
	Tokunori Ikegami, Andreas Oetken, Andreas Oetken

Apply existing fixups to MT28FW02GBBA1HPC from:
Commit 0a8e98305f63deaf0a799d5cf5532cc83af035d1 ("mtd: cfi_cmdset_0002:
Use chip_ready() for write on S29GL064N")
Commit 0fe3ede7941dfcd6fd540fc2b086453d3ee8f236 ("mtd: cfi: Add early
fixup for S70GL02GS")

Signed-off-by: Andreas Oetken <ennoerlangen@gmail.com>
---
 drivers/mtd/chips/cfi_cmdset_0002.c |  4 +++-
 drivers/mtd/chips/cfi_probe.c       | 15 ++++++++++++++-
 2 files changed, 17 insertions(+), 2 deletions(-)

diff --git a/drivers/mtd/chips/cfi_cmdset_0002.c b/drivers/mtd/chips/cfi_cmdset_0002.c
index 9bd65f3f805c..4e0bc2a1abb5 100644
--- a/drivers/mtd/chips/cfi_cmdset_0002.c
+++ b/drivers/mtd/chips/cfi_cmdset_0002.c
@@ -441,8 +441,10 @@ static void fixup_quirks(struct mtd_info *mtd)
 	struct map_info *map = mtd->priv;
 	struct cfi_private *cfi = map->fldrv_priv;
 
-	if (cfi->mfr == CFI_MFR_AMD && cfi->id == 0x0c01)
+	if (cfi->mfr == CFI_MFR_AMD && cfi->id == 0x0c01 ||
+	    cfi->mfr == CFI_MFR_INTEL && cfi->id == 0x227e) /*MT28FW02GBBA1HPC*/
 		cfi->quirks |= CFI_QUIRK_DQ_TRUE_DATA;
+
 }
 
 /* Used to fix CFI-Tables of chips without Extended Query Tables */
diff --git a/drivers/mtd/chips/cfi_probe.c b/drivers/mtd/chips/cfi_probe.c
index cf426956454c..102c1ffb9aad 100644
--- a/drivers/mtd/chips/cfi_probe.c
+++ b/drivers/mtd/chips/cfi_probe.c
@@ -186,9 +186,22 @@ static void fixup_s70gl02gs_chips(struct cfi_private *cfi)
 	pr_warn("Bad S70GL02GS CFI data; adjust to detect 2 chips\n");
 }
 
+
+static void fixup_mt28fw02gbba1hpc_chips(struct cfi_private *cfi)
+{
+	/*
+	 * MT28FW02GBBA1HPC flash reports a single 256 MiB chip, but is really made up
+	 * of two 128 MiB chips with 1024 sectors each.
+	 */
+	cfi->cfiq->DevSize = 27;
+	cfi->cfiq->EraseRegionInfo[0] = 0x20003ff;
+	pr_warn("Bad MT28FW02GBBA1HPC CFI data; adjust to detect 2 chips\n");
+}
+
 static const struct cfi_early_fixup cfi_early_fixup_table[] = {
 	{ CFI_MFR_AMD, 0x4801, fixup_s70gl02gs_chips },
-	{ },
+	{ CFI_MFR_INTEL, 0x227e, fixup_mt28fw02gbba1hpc_chips},
+	{ }
 };
 
 static int __xipram cfi_chip_setup(struct map_info *map,
-- 
2.30.2


______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] mtd: cfi: add fixups to support MT28FW02GBBA1HPC
  2022-10-19 15:49 [PATCH] mtd: cfi: add fixups to support MT28FW02GBBA1HPC Andreas Oetken
@ 2022-10-19 15:58 ` Greg Kroah-Hartman
  2022-10-19 19:34   ` Miquel Raynal
  2022-10-19 16:18 ` Tokunori Ikegami
  1 sibling, 1 reply; 4+ messages in thread
From: Greg Kroah-Hartman @ 2022-10-19 15:58 UTC (permalink / raw)
  To: Andreas Oetken
  Cc: Vignesh Raghavendra, linux-mtd, Miquel Raynal,
	Richard Weinberger, Tokunori Ikegami, Andreas Oetken

On Wed, Oct 19, 2022 at 05:49:24PM +0200, Andreas Oetken wrote:
> Apply existing fixups to MT28FW02GBBA1HPC from:
> Commit 0a8e98305f63deaf0a799d5cf5532cc83af035d1 ("mtd: cfi_cmdset_0002:
> Use chip_ready() for write on S29GL064N")
> Commit 0fe3ede7941dfcd6fd540fc2b086453d3ee8f236 ("mtd: cfi: Add early
> fixup for S70GL02GS")

That's not the proper way to reference commits in changelog texts.  No
need to use the full sha1.  See the documentation for more details.

Also, this text means nothing.  Please spell out what you are doing and
why you are doing it.  as-is it doesn't really make any sense.

thanks,

greg k-h

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] mtd: cfi: add fixups to support MT28FW02GBBA1HPC
  2022-10-19 15:49 [PATCH] mtd: cfi: add fixups to support MT28FW02GBBA1HPC Andreas Oetken
  2022-10-19 15:58 ` Greg Kroah-Hartman
@ 2022-10-19 16:18 ` Tokunori Ikegami
  1 sibling, 0 replies; 4+ messages in thread
From: Tokunori Ikegami @ 2022-10-19 16:18 UTC (permalink / raw)
  To: Andreas Oetken, Vignesh Raghavendra, linux-mtd
  Cc: Miquel Raynal, Richard Weinberger, Greg Kroah-Hartman, Andreas Oetken

Hi,

On 2022/10/20 0:49, Andreas Oetken wrote:
> Apply existing fixups to MT28FW02GBBA1HPC from:
> Commit 0a8e98305f63deaf0a799d5cf5532cc83af035d1 ("mtd: cfi_cmdset_0002:
> Use chip_ready() for write on S29GL064N")
> Commit 0fe3ede7941dfcd6fd540fc2b086453d3ee8f236 ("mtd: cfi: Add early
> fixup for S70GL02GS")
>
> Signed-off-by: Andreas Oetken <ennoerlangen@gmail.com>
> ---
>   drivers/mtd/chips/cfi_cmdset_0002.c |  4 +++-
>   drivers/mtd/chips/cfi_probe.c       | 15 ++++++++++++++-
>   2 files changed, 17 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mtd/chips/cfi_cmdset_0002.c b/drivers/mtd/chips/cfi_cmdset_0002.c
> index 9bd65f3f805c..4e0bc2a1abb5 100644
> --- a/drivers/mtd/chips/cfi_cmdset_0002.c
> +++ b/drivers/mtd/chips/cfi_cmdset_0002.c
> @@ -441,8 +441,10 @@ static void fixup_quirks(struct mtd_info *mtd)
>   	struct map_info *map = mtd->priv;
>   	struct cfi_private *cfi = map->fldrv_priv;
>   
> -	if (cfi->mfr == CFI_MFR_AMD && cfi->id == 0x0c01)
> +	if (cfi->mfr == CFI_MFR_AMD && cfi->id == 0x0c01 ||
> +	    cfi->mfr == CFI_MFR_INTEL && cfi->id == 0x227e) /*MT28FW02GBBA1HPC*/

This patch is not based on the mainline code since implemented as below 
on mainline.
 > #define S29GL064N_MN12        0x0c01
 > ...
 >     if (cfi->mfr == CFI_MFR_AMD && cfi->id == S29GL064N_MN12)

>   		cfi->quirks |= CFI_QUIRK_DQ_TRUE_DATA;
> +
The empty line added is not necessary to add I think.
>   }
>   
>   /* Used to fix CFI-Tables of chips without Extended Query Tables */
> diff --git a/drivers/mtd/chips/cfi_probe.c b/drivers/mtd/chips/cfi_probe.c
> index cf426956454c..102c1ffb9aad 100644
> --- a/drivers/mtd/chips/cfi_probe.c
> +++ b/drivers/mtd/chips/cfi_probe.c
> @@ -186,9 +186,22 @@ static void fixup_s70gl02gs_chips(struct cfi_private *cfi)
>   	pr_warn("Bad S70GL02GS CFI data; adjust to detect 2 chips\n");
>   }
>   
> +
> +static void fixup_mt28fw02gbba1hpc_chips(struct cfi_private *cfi)
> +{
> +	/*
> +	 * MT28FW02GBBA1HPC flash reports a single 256 MiB chip, but is really made up
> +	 * of two 128 MiB chips with 1024 sectors each.
> +	 */
> +	cfi->cfiq->DevSize = 27;
> +	cfi->cfiq->EraseRegionInfo[0] = 0x20003ff;
> +	pr_warn("Bad MT28FW02GBBA1HPC CFI data; adjust to detect 2 chips\n");
> +}
> +
>   static const struct cfi_early_fixup cfi_early_fixup_table[] = {
>   	{ CFI_MFR_AMD, 0x4801, fixup_s70gl02gs_chips },
> -	{ },
> +	{ CFI_MFR_INTEL, 0x227e, fixup_mt28fw02gbba1hpc_chips},
A space should be added between "fixup_mt28fw02gbba1hpc_chips" and "}".
> +	{ }
>   };
>   
>   static int __xipram cfi_chip_setup(struct map_info *map,

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] mtd: cfi: add fixups to support MT28FW02GBBA1HPC
  2022-10-19 15:58 ` Greg Kroah-Hartman
@ 2022-10-19 19:34   ` Miquel Raynal
  0 siblings, 0 replies; 4+ messages in thread
From: Miquel Raynal @ 2022-10-19 19:34 UTC (permalink / raw)
  To: Greg Kroah-Hartman
  Cc: Andreas Oetken, Vignesh Raghavendra, linux-mtd,
	Richard Weinberger, Tokunori Ikegami, Andreas Oetken

Hi Andreas,

gregkh@linuxfoundation.org wrote on Wed, 19 Oct 2022 17:58:35 +0200:

> On Wed, Oct 19, 2022 at 05:49:24PM +0200, Andreas Oetken wrote:
> > Apply existing fixups to MT28FW02GBBA1HPC from:
> > Commit 0a8e98305f63deaf0a799d5cf5532cc83af035d1 ("mtd: cfi_cmdset_0002:
> > Use chip_ready() for write on S29GL064N")
> > Commit 0fe3ede7941dfcd6fd540fc2b086453d3ee8f236 ("mtd: cfi: Add early
> > fixup for S70GL02GS")  
> 
> That's not the proper way to reference commits in changelog texts.  No
> need to use the full sha1.  See the documentation for more details.
> 
> Also, this text means nothing.  Please spell out what you are doing and
> why you are doing it.  as-is it doesn't really make any sense.

Indeed. And the title prefix is still wrong :)
git log --oneline -- drivers/mtd/chips/cfi_cmdset* should help.

Thanks,
Miquèl

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2022-10-19 19:35 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-19 15:49 [PATCH] mtd: cfi: add fixups to support MT28FW02GBBA1HPC Andreas Oetken
2022-10-19 15:58 ` Greg Kroah-Hartman
2022-10-19 19:34   ` Miquel Raynal
2022-10-19 16:18 ` Tokunori Ikegami

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).