From: Takahiro Kuwano <tkuw584924@gmail.com>
To: Tudor.Ambarus@microchip.com, linux-mtd@lists.infradead.org
Cc: miquel.raynal@bootlin.com, richard@nod.at, vigneshr@ti.com,
p.yadav@ti.com, Bacem.Daassi@infineon.com,
Takahiro.Kuwano@infineon.com
Subject: Re: [PATCH v11 2/3] mtd: spi-nor: spansion: Add local function to discover page size
Date: Wed, 20 Apr 2022 10:41:16 +0900 [thread overview]
Message-ID: <3ac22afa-b79c-7022-ebe6-a2e477b19d46@gmail.com> (raw)
In-Reply-To: <3fbf1d6d-918b-2ebf-ee7d-6e09cc0eac74@microchip.com>
On 4/19/2022 5:06 PM, Tudor.Ambarus@microchip.com wrote:
> On 4/18/22 08:41, tkuw584924@gmail.com wrote:
>> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>>
>> From: Takahiro Kuwano <Takahiro.Kuwano@infineon.com>
>>
>> The page size check in s28hs512t fixup can be used for s25hs/hl-t as well.
>> Move that to a newly created local function.
>>
>> Signed-off-by: Takahiro Kuwano <Takahiro.Kuwano@infineon.com>
>> ---
>> Changes in v11:
>> - Rebase on top of Tudor's series
>> https://patchwork.ozlabs.org/project/linux-mtd/list/?series=294490
>> - Add addr_width param
>>
>> drivers/mtd/spi-nor/spansion.c | 54 ++++++++++++++++++++--------------
>> 1 file changed, 32 insertions(+), 22 deletions(-)
>>
>> diff --git a/drivers/mtd/spi-nor/spansion.c b/drivers/mtd/spi-nor/spansion.c
>> index 6bcd25180af4..493240ebfd70 100644
>> --- a/drivers/mtd/spi-nor/spansion.c
>> +++ b/drivers/mtd/spi-nor/spansion.c
>> @@ -177,6 +177,37 @@ static int cypress_nor_quad_enable_volatile(struct spi_nor *nor)
>> return 0;
>> }
>>
>> +/**
>> + * cypress_nor_set_page_size() - Set page size which corresponds to the flash
>> + * configuration.
>> + * @nor: pointer to a 'struct spi_nor'
>> + * @addr_width: address width used in Read Any Register op
>> + *
>> + * The BFPT table advertises a 512B or 256B page size depending on part but the
>> + * page size is actually configurable (with the default being 256B). Read from
>> + * CFR3V[4] and set the correct size.
>> + *
>> + * Return: 0 on success, -errno otherwise.
>> + */
>> +static int cypress_nor_set_page_size(struct spi_nor *nor, u8 addr_width)
>> +{
>> + struct spi_mem_op op =
>> + CYPRESS_NOR_RD_ANY_REG_OP(addr_width, SPINOR_REG_CYPRESS_CFR3V,
>> + nor->bouncebuf);
>> + int ret;
>> +
>> + ret = spi_nor_read_reg(nor, &op, nor->reg_proto);
>> + if (ret)
>> + return ret;
>> +
>> + if (nor->bouncebuf[0] & SPINOR_REG_CYPRESS_CFR3V_PGSZ)
>> + nor->params->page_size = 512;
>> + else
>> + nor->params->page_size = 256;
>> +
>> + return 0;
>> +}
>> +
>> /**
>> * cypress_nor_octal_dtr_enable() - Enable octal DTR on Cypress flashes.
>> * @nor: pointer to a 'struct spi_nor'
>> @@ -231,28 +262,7 @@ static int s28hs512t_post_bfpt_fixup(struct spi_nor *nor,
>> const struct sfdp_parameter_header *bfpt_header,
>> const struct sfdp_bfpt *bfpt)
>> {
>> - /*
>> - * The BFPT table advertises a 512B page size but the page size is
>> - * actually configurable (with the default being 256B). Read from
>> - * CFR3V[4] and set the correct size.
>> - */
>> - struct spi_mem_op op =
>> - CYPRESS_NOR_RD_ANY_REG_OP(3, SPINOR_REG_CYPRESS_CFR3V,
>> - nor->bouncebuf);
>> - int ret;
>> -
>> - spi_nor_spimem_setup_op(nor, &op, nor->reg_proto);
>> -
>> - ret = spi_mem_exec_op(nor->spimem, &op);
>> - if (ret)
>> - return ret;
>> -
>> - if (nor->bouncebuf[0] & SPINOR_REG_CYPRESS_CFR3V_PGSZ)
>> - nor->params->page_size = 512;
>> - else
>> - nor->params->page_size = 256;
>> -
>> - return 0;
>> + return cypress_nor_set_page_size(nor, 3);
>
> not related to this patch, but can we use nor->add_width instead of 3?
>
I confirmed with a s28hs512t device on hand that nor->addr_width is set
to 3 during BFPT parse. We can use nor->addr_width and eliminate addr_width
param from cypress_nor_set_page_size(). I will do it in next rev.
> Reviewed-by: Tudor Ambarus <tudor.ambarus@microchip.com>
>
>> }
>>
>> static const struct spi_nor_fixups s28hs512t_fixups = {
>> --
>> 2.25.1
>>
>
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2022-04-20 1:41 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-18 5:41 [PATCH v11 0/3] mtd: spi-nor: Add support for Infineon s25hl-t/s25hs-t tkuw584924
2022-04-18 5:41 ` [PATCH v11 1/3] mtd: spi-nor: spansion: Add support for volatile QE bit tkuw584924
2022-04-19 8:01 ` Tudor.Ambarus
2022-04-20 1:03 ` Takahiro Kuwano
2022-04-19 12:53 ` Tudor.Ambarus
2022-04-20 0:48 ` Takahiro Kuwano
2022-04-18 5:41 ` [PATCH v11 2/3] mtd: spi-nor: spansion: Add local function to discover page size tkuw584924
2022-04-19 8:06 ` Tudor.Ambarus
2022-04-20 1:41 ` Takahiro Kuwano [this message]
2022-04-18 5:41 ` [PATCH v11 3/3] mtd: spi-nor: spansion: Add s25hl-t/s25hs-t IDs and fixups tkuw584924
2022-04-19 9:32 ` Tudor.Ambarus
2022-04-20 5:34 ` Takahiro Kuwano
2022-04-20 6:11 ` Tudor.Ambarus
2022-04-20 6:58 ` Takahiro Kuwano
2022-04-20 7:35 ` Tudor.Ambarus
2022-04-20 7:47 ` Tudor.Ambarus
2022-04-20 7:50 ` Takahiro Kuwano
2022-04-20 8:11 ` Tudor.Ambarus
2022-04-20 8:38 ` Takahiro Kuwano
2022-04-20 8:46 ` Tudor.Ambarus
2022-04-21 6:58 ` Takahiro Kuwano
2022-04-20 8:32 ` Takahiro Kuwano
2022-04-20 8:49 ` Tudor.Ambarus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3ac22afa-b79c-7022-ebe6-a2e477b19d46@gmail.com \
--to=tkuw584924@gmail.com \
--cc=Bacem.Daassi@infineon.com \
--cc=Takahiro.Kuwano@infineon.com \
--cc=Tudor.Ambarus@microchip.com \
--cc=linux-mtd@lists.infradead.org \
--cc=miquel.raynal@bootlin.com \
--cc=p.yadav@ti.com \
--cc=richard@nod.at \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).