linux-mtd.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Joakim.Tjernlund@infinera.com (Joakim Tjernlund)
To: linux-mtd@lists.infradead.org
Subject: [PATCH] mtd: cfi: Fixed endless loop problem in CFI when value was written but corrupted.
Date: Wed, 16 Jan 2019 08:50:26 +0000	[thread overview]
Message-ID: <414bf181e3b17ff5e97107850e65da476000f5ea.camel@infinera.com> (raw)
In-Reply-To: <acd7f2257808f78aa76840e6789c7f65c08986ef.camel@infinera.com>

On Wed, 2019-01-16 at 08:33 +0000, Joakim Tjernlund wrote:
> CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you recognize the sender and know the content is safe.
> 
> 
> On Wed, 2019-01-16 at 00:32 +0000, Przemyslaw Sobon wrote:
> > 
> > There was an endless loop in CFI Flash driver when a value was written
> > incorrectly. In such case chip_ready returns true but chip_good returns
> > false and we never get out of the loop.
> > 
> > The solution was to break the loop in 2 cases, either device is ready or
> > device is not ready and timeout elapsed. The correctness of the write is
> > checked after the loop ended. That way we ensure the loop always ends.
> > 
> > Signed-off-by: Przemyslaw Sobon <psobon@amazon.com>
> 
> hmm, current code was introduced by Tokunori Ikegami <ikegami@allied-telesis.co.jp> to address another problem he had.

Seems like Tokunori Ikegami's email address is invalid now ...

  reply	other threads:[~2019-01-16  8:50 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-16  0:32 [PATCH] mtd: cfi: Fixed endless loop problem in CFI when value was written but corrupted Przemyslaw Sobon
2019-01-16  8:33 ` Joakim Tjernlund
2019-01-16  8:50   ` Joakim Tjernlund [this message]
2019-01-16  8:54   ` Sobon, Przemyslaw
2019-02-07 23:58 Przemyslaw Sobon
2019-02-08 15:01 ` Tokunori Ikegami

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=414bf181e3b17ff5e97107850e65da476000f5ea.camel@infinera.com \
    --to=joakim.tjernlund@infinera.com \
    --cc=linux-mtd@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).