From: <Tudor.Ambarus@microchip.com>
To: <vigneshr@ti.com>
Cc: richard@nod.at, linux-mtd@lists.infradead.org,
linux-kernel@vger.kernel.org, miquel.raynal@bootlin.com
Subject: Re: [PATCH] mtd: spi-nor: Fix selection of 4-byte addressing opcodes on Spansion
Date: Mon, 13 Jan 2020 10:17:43 +0000 [thread overview]
Message-ID: <4323032.MiQHyusyOz@localhost.localdomain> (raw)
In-Reply-To: <20200108051343.1939-1-vigneshr@ti.com>
Hi, Vignesh,
On Wednesday, January 8, 2020 7:13:43 AM EET Vignesh Raghavendra wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the
> content is safe
>
> mtd->size is still unassigned when running spansion_post_sfdp_fixups()
> hook, therefore use nor->params.size to determine the size of flash device.
>
> This makes sure that 4-byte addressing opcodes are used on Spansion
> flashes that are larger than 16MiB and don't have SFDP 4BAIT table
> populated.
>
> Fixes: 92094ebc385e ("mtd: spi-nor: Add spansion_post_sfdp_fixups()")
> Signed-off-by: Vignesh Raghavendra <vigneshr@ti.com>
This fixes a recent bug, so if you want to take it through mtd/fixes you can
add:
Reviewed-by: Tudor Ambarus <tudor.ambarus@microchip.com>
If you want this through spi-nor/next, please let me know and I'll queue it.
Cheers,
ta
> ---
> drivers/mtd/spi-nor/spi-nor.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c
> index 1082b6bb1393..cd47f07deff3 100644
> --- a/drivers/mtd/spi-nor/spi-nor.c
> +++ b/drivers/mtd/spi-nor/spi-nor.c
> @@ -4783,9 +4783,7 @@ static void spi_nor_info_init_params(struct spi_nor
> *nor)
>
> static void spansion_post_sfdp_fixups(struct spi_nor *nor)
> {
> - struct mtd_info *mtd = &nor->mtd;
> -
> - if (mtd->size <= SZ_16M)
> + if (nor->params.size <= SZ_16M)
> return;
>
> nor->flags |= SNOR_F_4B_OPCODES;
> --
> 2.24.1
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2020-01-13 10:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-08 5:13 [PATCH] mtd: spi-nor: Fix selection of 4-byte addressing opcodes on Spansion Vignesh Raghavendra
2020-01-13 10:17 ` Tudor.Ambarus [this message]
2020-01-17 13:57 ` Tudor.Ambarus
2020-01-17 21:47 ` Miquel Raynal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4323032.MiQHyusyOz@localhost.localdomain \
--to=tudor.ambarus@microchip.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=miquel.raynal@bootlin.com \
--cc=richard@nod.at \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).