linux-mtd.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Richard Weinberger <richard@nod.at>
To: "Lihua (lihua, ran)" <hucool.lihua@huawei.com>
Cc: Sascha Hauer <s.hauer@pengutronix.de>,
	 linux-mtd <linux-mtd@lists.infradead.org>,
	 linux-kernel <linux-kernel@vger.kernel.org>,
	 Wei Yongjun <weiyongjun1@huawei.com>,
	yusongping@huawei.com
Subject: Re: [PATCH] ubifs: Fix build errors as symbol undefined
Date: Sat, 19 Nov 2022 22:25:50 +0100 (CET)	[thread overview]
Message-ID: <433070166.256175.1668893150374.JavaMail.zimbra@nod.at> (raw)
In-Reply-To: <23feff35-6f2d-5cd7-57f9-ff2591a3c74e@huawei.com>

----- Ursprüngliche Mail -----
> Von: "Lihua (lihua, ran)" <hucool.lihua@huawei.com>
>> diff --git a/fs/ubifs/Kconfig b/fs/ubifs/Kconfig
>> index 45d3d207fb99..93bda1057fdc 100644
>> --- a/fs/ubifs/Kconfig
>> +++ b/fs/ubifs/Kconfig
>> @@ -13,6 +13,7 @@ config UBIFS_FS
>>   	select CRYPTO_HASH_INFO
>>   	select UBIFS_FS_XATTR if FS_ENCRYPTION
>>   	select FS_ENCRYPTION_ALGS if FS_ENCRYPTION
>> +	select UBIFS_FS_AUTHENTICATION

I fear this is not a proper fix.
This changes does not longer allow building UBIFS without the authentication feature.
With what configuration do you see this error?

I just tried with:
CONFIG_UBIFS_FS=m
CONFIG_UBIFS_FS_ADVANCED_COMPR=y
CONFIG_UBIFS_FS_LZO=y
CONFIG_UBIFS_FS_ZLIB=y
CONFIG_UBIFS_FS_ZSTD=y
CONFIG_UBIFS_ATIME_SUPPORT=y
CONFIG_UBIFS_FS_XATTR=y
CONFIG_UBIFS_FS_SECURITY=y
# CONFIG_UBIFS_FS_AUTHENTICATION is not set

But don't get the error and, as expected, fs/ubifs/ubifs.o has no
reference to ubifs_bad_hash.

Thanks,
//richard

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

  reply	other threads:[~2022-11-19 21:26 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-15  8:33 [PATCH] ubifs: Fix build errors as symbol undefined Li Hua
2022-11-15  8:24 ` Zhihao Cheng
2022-11-19  5:21 ` Lihua (lihua, ran)
2022-11-19 21:25   ` Richard Weinberger [this message]
2022-11-21  1:54     ` Lihua (lihua, ran)
2022-11-21  8:00       ` Richard Weinberger
2022-11-21  9:32         ` Lihua (lihua, ran)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=433070166.256175.1668893150374.JavaMail.zimbra@nod.at \
    --to=richard@nod.at \
    --cc=hucool.lihua@huawei.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=s.hauer@pengutronix.de \
    --cc=weiyongjun1@huawei.com \
    --cc=yusongping@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).