From: "Cédric Le Goater" <clg@kaod.org>
To: Rob Herring <robh@kernel.org>
Cc: Joel Stanley <joel@jms.id.au>,
Chin-Ting Kuo <chin-ting_kuo@aspeedtech.com>,
Rob Herring <robh+dt@kernel.org>, Pratyush Yadav <p.yadav@ti.com>,
Mark Brown <broonie@kernel.org>,
Tudor Ambarus <tudor.ambarus@microchip.com>,
<linux-kernel@vger.kernel.org>, Tao Ren <rentao.bupt@gmail.com>,
Andrew Jeffery <andrew@aj.id.au>, <linux-spi@vger.kernel.org>,
<devicetree@vger.kernel.org>,
Vignesh Raghavendra <vigneshr@ti.com>,
<linux-mtd@lists.infradead.org>,
Jae Hyun Yoo <quic_jaehyoo@quicinc.com>,
<linux-aspeed@lists.ozlabs.org>,
<linux-arm-kernel@lists.infradead.org>,
Miquel Raynal <miquel.raynal@bootlin.com>,
Richard Weinberger <richard@nod.at>
Subject: Re: [PATCH v5 02/11] dt-bindings: spi: Add Aspeed SMC controllers device tree binding
Date: Mon, 2 May 2022 18:08:56 +0200 [thread overview]
Message-ID: <449f47d2-f700-e71d-996b-ce30c6906d89@kaod.org> (raw)
In-Reply-To: <1651505609.452113.1161768.nullmailer@robh.at.kernel.org>
On 5/2/22 17:33, Rob Herring wrote:
> On Mon, 02 May 2022 10:13:32 +0200, Cédric Le Goater wrote:
>> The "interrupt" property is optional because it is only necessary for
>> controllers supporting DMAs (Not implemented yet in the new driver).
>>
>> Cc: Chin-Ting Kuo <chin-ting_kuo@aspeedtech.com>
>> Tested-by: Joel Stanley <joel@jms.id.au>
>> Tested-by: Tao Ren <rentao.bupt@gmail.com>
>> Tested-by: Jae Hyun Yoo <quic_jaehyoo@quicinc.com>
>> Reviewed-by: Joel Stanley <joel@jms.id.au>
>> Reviewed-by: Rob Herring <robh@kernel.org>
>> Signed-off-by: Cédric Le Goater <clg@kaod.org>
>> ---
>> .../bindings/spi/aspeed,ast2600-fmc.yaml | 82 +++++++++++++++++++
>> MAINTAINERS | 9 ++
>> 2 files changed, 91 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/spi/aspeed,ast2600-fmc.yaml
>>
>
> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> on your patch (DT_CHECKER_FLAGS is new in v5.13):
>
> yamllint warnings/errors:
> ./Documentation/devicetree/bindings/spi/aspeed,ast2600-fmc.yaml:62:1: [error] syntax error: found character '\t' that cannot start any token (syntax)
drat. I forgot to rerun the check after prettifying the example.
Will resend a v6 without the tabs.
Thanks,
C.
>
> dtschema/dtc warnings/errors:
> make[1]: *** Deleting file 'Documentation/devicetree/bindings/spi/aspeed,ast2600-fmc.example.dts'
> Traceback (most recent call last):
> File "/usr/local/bin/dt-extract-example", line 52, in <module>
> binding = yaml.load(open(args.yamlfile, encoding='utf-8').read())
> File "/usr/local/lib/python3.10/dist-packages/ruamel/yaml/main.py", line 434, in load
> return constructor.get_single_data()
> File "/usr/local/lib/python3.10/dist-packages/ruamel/yaml/constructor.py", line 119, in get_single_data
> node = self.composer.get_single_node()
> File "_ruamel_yaml.pyx", line 706, in _ruamel_yaml.CParser.get_single_node
> File "_ruamel_yaml.pyx", line 724, in _ruamel_yaml.CParser._compose_document
> File "_ruamel_yaml.pyx", line 775, in _ruamel_yaml.CParser._compose_node
> File "_ruamel_yaml.pyx", line 889, in _ruamel_yaml.CParser._compose_mapping_node
> File "_ruamel_yaml.pyx", line 773, in _ruamel_yaml.CParser._compose_node
> File "_ruamel_yaml.pyx", line 848, in _ruamel_yaml.CParser._compose_sequence_node
> File "_ruamel_yaml.pyx", line 904, in _ruamel_yaml.CParser._parse_next_event
> ruamel.yaml.scanner.ScannerError: while scanning a block scalar
> in "<unicode string>", line 49, column 5
> found a tab character where an indentation space is expected
> in "<unicode string>", line 62, column 1
> make[1]: *** [Documentation/devicetree/bindings/Makefile:26: Documentation/devicetree/bindings/spi/aspeed,ast2600-fmc.example.dts] Error 1
> make[1]: *** Waiting for unfinished jobs....
> ./Documentation/devicetree/bindings/spi/aspeed,ast2600-fmc.yaml: while scanning a block scalar
> in "<unicode string>", line 49, column 5
> found a tab character where an indentation space is expected
> in "<unicode string>", line 62, column 1
> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/spi/aspeed,ast2600-fmc.yaml: ignoring, error parsing file
> make: *** [Makefile:1401: dt_binding_check] Error 2
>
> doc reference errors (make refcheckdocs):
>
> See https://patchwork.ozlabs.org/patch/
>
> This check can fail if there are any dependencies. The base for a patch
> series is generally the most recent rc1.
>
> If you already ran 'make dt_binding_check' and didn't see the above
> error(s), then make sure 'yamllint' is installed and dt-schema is up to
> date:
>
> pip3 install dtschema --upgrade
>
> Please check and re-submit.
>
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2022-05-02 16:09 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-02 8:13 [PATCH v5 00/11] spi: spi-mem: Convert Aspeed SMC driver to spi-mem Cédric Le Goater
2022-05-02 8:13 ` [PATCH v5 01/11] ARM: dts: aspeed: Adjust "reg" property of FMC/SPI controllers Cédric Le Goater
2022-05-02 8:13 ` [PATCH v5 02/11] dt-bindings: spi: Add Aspeed SMC controllers device tree binding Cédric Le Goater
2022-05-02 15:33 ` Rob Herring
2022-05-02 16:08 ` Cédric Le Goater [this message]
2022-05-02 8:13 ` [PATCH v5 03/11] spi: spi-mem: Convert Aspeed SMC driver to spi-mem Cédric Le Goater
2022-05-02 8:13 ` [PATCH v5 04/11] spi: aspeed: Add support for direct mapping Cédric Le Goater
2022-05-02 8:13 ` [PATCH v5 05/11] spi: aspeed: Adjust direct mapping to device size Cédric Le Goater
2022-05-02 8:13 ` [PATCH v5 06/11] spi: aspeed: Workaround AST2500 limitations Cédric Le Goater
2022-05-02 8:13 ` [PATCH v5 07/11] spi: aspeed: Add support for the AST2400 SPI controller Cédric Le Goater
2022-05-02 8:13 ` [PATCH v5 08/11] spi: aspeed: Calibrate read timings Cédric Le Goater
2022-05-02 8:13 ` [PATCH v5 09/11] ARM: dts: aspeed: Enable Dual SPI RX transfers Cédric Le Goater
2022-05-02 8:13 ` [PATCH v5 10/11] ARM: dts: aspeed-g4: Set spi-max-frequency for all flashes Cédric Le Goater
2022-05-02 8:13 ` [PATCH v5 11/11] mtd: spi-nor: aspeed: set the decoding size to at least 2MB for AST2600 Cédric Le Goater
2022-05-03 5:38 ` [PATCH v5 00/11] spi: spi-mem: Convert Aspeed SMC driver to spi-mem Joel Stanley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=449f47d2-f700-e71d-996b-ce30c6906d89@kaod.org \
--to=clg@kaod.org \
--cc=andrew@aj.id.au \
--cc=broonie@kernel.org \
--cc=chin-ting_kuo@aspeedtech.com \
--cc=devicetree@vger.kernel.org \
--cc=joel@jms.id.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-spi@vger.kernel.org \
--cc=miquel.raynal@bootlin.com \
--cc=p.yadav@ti.com \
--cc=quic_jaehyoo@quicinc.com \
--cc=rentao.bupt@gmail.com \
--cc=richard@nod.at \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
--cc=tudor.ambarus@microchip.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).