From: <Tudor.Ambarus@microchip.com>
To: <tkuw584924@gmail.com>, <p.yadav@ti.com>, <michael@walle.cc>,
<Takahiro.Kuwano@infineon.com>
Cc: <miquel.raynal@bootlin.com>, <richard@nod.at>, <vigneshr@ti.com>,
<Bacem.Daassi@infineon.com>, <linux-mtd@lists.infradead.org>
Subject: Re: [PATCH 1/2] mtd: spi-nor: spansion: Replace hardcoded values for addr_nbytes/addr_mode_nbytes
Date: Fri, 29 Jul 2022 05:32:16 +0000 [thread overview]
Message-ID: <486a0bbd-3000-56f3-863c-73df31cbe996@microchip.com> (raw)
In-Reply-To: <aeb5771d-16ff-cd8c-ad25-a076b4dd11a8@gmail.com>
On 7/29/22 05:35, Takahiro Kuwano wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> On 7/28/2022 1:27 PM, Tudor.Ambarus@microchip.com wrote:
>> Hi, Takahiro,
>>
>> On 7/28/22 07:14, Tudor Ambarus wrote:
>>> We track in the core the internal address mode of the flash. Stop using
>>> hardcoded values for the number of bytes of address and use
>>> nor->addr_nbytes and nor->params->addr_mode_nbytes instead.
>>>
>>> Signed-off-by: Tudor Ambarus <tudor.ambarus@microchip.com>
>>> ---
>>> drivers/mtd/spi-nor/spansion.c | 16 +++++++++++-----
>>> 1 file changed, 11 insertions(+), 5 deletions(-)
>>
>> Would you please test this patch. You'll need an s25hx
>> and an s28hs512t flash. Thanks!
>
> Both s25 and s28 works fine!
>
> Tested-by: Takahiro Kuwano <Takahiro.Kuwano@infineon.com>
Thank you, Takahiro!
--
Cheers,
ta
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2022-07-29 5:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-28 4:14 [PATCH 0/2] mtd: spi-nor: manufacturers: Replace hardcoded values for addr_nbytes/addr_mode_nbytes Tudor Ambarus
2022-07-28 4:14 ` [PATCH 1/2] mtd: spi-nor: spansion: " Tudor Ambarus
2022-07-28 4:27 ` Tudor.Ambarus
2022-07-29 2:35 ` Takahiro Kuwano
2022-07-29 5:32 ` Tudor.Ambarus [this message]
2022-07-28 4:14 ` [PATCH 2/2] mtd: spi-nor: micron-st.c: " Tudor Ambarus
2022-10-25 2:33 ` [PATCH 0/2] mtd: spi-nor: manufacturers: " Tudor Ambarus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=486a0bbd-3000-56f3-863c-73df31cbe996@microchip.com \
--to=tudor.ambarus@microchip.com \
--cc=Bacem.Daassi@infineon.com \
--cc=Takahiro.Kuwano@infineon.com \
--cc=linux-mtd@lists.infradead.org \
--cc=michael@walle.cc \
--cc=miquel.raynal@bootlin.com \
--cc=p.yadav@ti.com \
--cc=richard@nod.at \
--cc=tkuw584924@gmail.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).