linux-mtd.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Peter Horton <phorton@bitbox.co.uk>
To: Mike Dunn <mikedunn@newsguy.com>
Cc: linux-mtd@lists.infradead.org, dedekind1@gmail.com
Subject: Re: [PATCH v2] MTD: modify mtd api to return bitflip info on read operations
Date: Mon, 05 Dec 2011 17:09:00 +0000	[thread overview]
Message-ID: <4EDCFAAC.90709@bitbox.co.uk> (raw)
In-Reply-To: <4EDCF840.7050107@newsguy.com>

On 05/12/2011 16:58, Mike Dunn wrote:
> On 12/04/2011 10:07 PM, Artem Bityutskiy wrote:
>> On Sun, 2011-12-04 at 06:55 -0800, Mike Dunn wrote:
>>> So you're thinking that the driver would supply both ecc_strength and
>>> "scrublevel" (or maybe bb_threshold)?  Would these go into struct mtd_info?
>> Probably yes. After all, UBI has no idea about what kind of flash is
>> that and what kind of ECC it uses and what bit-flip level needs
>> scrubbing. So I think this kind of information should come from the
>> driver or from the user via mtd sysfs files. What do you think?
>
>
> I'm not a flash expert, but that sounds reasonable, especially if the scrublevel
> parameter is optional, with UBI using ecc_strength as the default value.  As for
> how to pass the parameter, sysfs might be a good idea for scrublevel, allowing
> it to be tunable without having to modify the driver if experience show that the
> driver author's original assumptions about how a block degrades were incorrect.
>

Surely the check for "do we need to scrub ?" should be done lower down 
otherwise all users of the mtd NAND interface (UBI / JFFS2 etc) are 
going to have to re-implement those sysfs files and the corresponding 
checks.

P.

  reply	other threads:[~2011-12-05 17:09 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-03 20:20 [PATCH v2] MTD: modify mtd api to return bitflip info on read operations Mike Dunn
2011-12-04  8:43 ` Peter Horton
2011-12-04 13:52   ` Mike Dunn
2011-12-04 14:43     ` Artem Bityutskiy
2011-12-04 14:55       ` Mike Dunn
2011-12-05  6:07         ` Artem Bityutskiy
2011-12-05 16:58           ` Mike Dunn
2011-12-05 17:09             ` Peter Horton [this message]
2011-12-05 18:57               ` Mike Dunn
2011-12-06 21:52                 ` Robert Jarzmik
2011-12-07  2:16                   ` Mike Dunn
2011-12-07  8:01                     ` Ricard Wanderlof
2011-12-07 18:32                       ` Mike Dunn
2011-12-12 12:48                         ` Artem Bityutskiy
2011-12-14 20:46                           ` Mike Dunn
2011-12-16 10:09                             ` Artem Bityutskiy
2011-12-07  9:42                   ` Peter Horton
2011-12-07 18:33                     ` Mike Dunn
2011-12-04 14:33 ` Artem Bityutskiy
2011-12-05  6:23 ` Artem Bityutskiy
2011-12-05 18:13   ` Mike Dunn
2011-12-05 21:16     ` Artem Bityutskiy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4EDCFAAC.90709@bitbox.co.uk \
    --to=phorton@bitbox.co.uk \
    --cc=dedekind1@gmail.com \
    --cc=linux-mtd@lists.infradead.org \
    --cc=mikedunn@newsguy.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).