* [PATCH 0/2] mtd: spi-nor: spansion: Add support for s28hl512t, s28hl01gt, and s28hs01gt
@ 2022-08-25 2:20 tkuw584924
2022-08-25 2:20 ` [PATCH 1/2] mtd: spi-nor: spansion: Rename s28hs512t prefix tkuw584924
2022-08-25 2:20 ` [PATCH 2/2] mtd: spi-nor: spansion: Add s28hl512t, s28hl01gt, and s28hs01gt info tkuw584924
0 siblings, 2 replies; 6+ messages in thread
From: tkuw584924 @ 2022-08-25 2:20 UTC (permalink / raw)
To: linux-mtd
Cc: tudor.ambarus, pratyush, michael, miquel.raynal, richard,
vigneshr, tkuw584924, Bacem.Daassi, Takahiro Kuwano
From: Takahiro Kuwano <Takahiro.Kuwano@infineon.com>
These devices are variants of s28hs512t(1.8V 512Mb) with different
density(1Gb) and power supply voltage(3V).
Datasheet:
https://www.infineon.com/dgdl/Infineon-S28HS256T_S28HS512T_S28HS01GT_S28HL256T_S28HL512T_S28HL01GT_256-Mb_(32-MB)_512-Mb_(64-MB)_1-Gb_(128-MB)_HS-T_(1.8-V)_HL-T_(3.0-V)_Semper_Flash_with_Octal_Interface-DataSheet-v03_00-EN.pdf?fileId=8ac78c8c7d0d8da4017d0ee6bca96f97&da=t
Tested on Zynq-7000 platform with Infineon SPI controller
ID, SFDP, Test logs:
-------------------------------------------------------------------------
zynq> cat /sys/bus/spi/devices/spi0.0/spi-nor/partname
s28hl512t
zynq> cat /sys/bus/spi/devices/spi0.0/spi-nor/jedec_id
345a1a
zynq> cat /sys/bus/spi/devices/spi0.0/spi-nor/manufacturer
spansion
zynq> xxd -p /sys/bus/spi/devices/spi0.0/spi-nor/sfdp
53464450080105fe00000114000100ff84000102500100ff050001055801
00ff8700011c6c0100ff0a000104dc0100ff81000116ec0100ffffffffff
ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
ffffffffffffffffffffffffffffffffe7218affffffff1f000000000000
0000eeffffffffff0000ffff00000c2100ff00ff12dc23faff8b91e8ffe3
ec031c6030b030b0f766805c000000fff9f810a000000000000084020000
0000ffff7e7e43120ffe21ffffdc00ee809b0000000000b08c95a80b0000
0c551ca20000800000000000c0ccffeb88fbffeb00650090060500a10065
009600650095716503d0716503d0a46bfb0290a579a20040288e0000ff00
0000ff0071650690716506900000000000000000716506d1716506d17165
0691716506910000ff000000ff00716505d5716505d50000ee7200000601
000000008000710600030600fc65ff0804008000fc65ff4002008000fd65
ff0402008000fe0002fff1ff0100f8ff0100f8fffb03fe0302fff8fffb03
f8ff0100f1ff0100fe0104fff1ff0100f8ff0200f8fff703f8ff0200f1ff
0100ff0400fff8ffff03
zynq> md5sum /sys/bus/spi/devices/spi0.0/spi-nor/sfdp
b7661a9fd55106d44f80f06e5b38f592 /sys/bus/spi/devices/spi0.0/spi-nor/sfdp
zynq> test_qspi.sh
6+0 records in
6+0 records out
6291456 bytes (6.0MB) copied, 0.231607 seconds, 25.9MB/s
Copied 6291456 bytes from qspi_test to address 0x00000000 in flash
Erased 6291456 bytes from address 0x00000000 in flash
Copied 6291456 bytes from address 0x00000000 in flash to qspi_read
0000000 ffff ffff ffff ffff ffff ffff ffff ffff
*
0600000
Copied 6291456 bytes from qspi_test to address 0x00000000 in flash
Copied 6291456 bytes from address 0x00000000 in flash to qspi_read
7ca01dfbd718151b749ab6ac05f316d199bbda25 qspi_test
7ca01dfbd718151b749ab6ac05f316d199bbda25 qspi_read
-------------------------------------------------------------------------
zynq> cat /sys/bus/spi/devices/spi0.0/spi-nor/partname
s28hl01gt
zynq> cat /sys/bus/spi/devices/spi0.0/spi-nor/jedec_id
345a1b
zynq> cat /sys/bus/spi/devices/spi0.0/spi-nor/manufacturer
spansion
zynq> xxd -p /sys/bus/spi/devices/spi0.0/spi-nor/sfdp
53464450080105fe00000114000100ff84000102500100ff050001055801
00ff8700011c6c0100ff0a000104dc0100ff81000116ec0100ffffffffff
ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
fffffffffffffffffffffffffffffffff7218affffffff3f000000000000
0000eeffffffffff0000ffff00000c2100ff00ff12dc23faff8b82e7ffe6
ec031c607ab07ab0f766805c000000fff910f8a0000000000000bc020000
0000ffff7e7e41120ffe21ffffdc00ee800b7171656500b0ff96a80b0000
0c551ca20000800000000000c0ccffeb88fbffeb00650090060500a10065
009600650095716503d0716503d0a46bfb0290a579a20040288e0000ff00
0000ff0071650690716506900000000000000000716506d1716506d17165
0691716506910000ff000000ff00716505d5716505d50000a01500000601
000000000080710500004306fc65ff0804008000fc65ff4002008000fd65
ff0402008000fe0002fff1ff0100f8ff0100f8fffb07fe0302fff8fffb07
f8ff0100f1ff0100fe0104fff1ff0000f8ff0200f8fff707f8ff0200f1ff
0000ff0400fff8ffff07
zynq> md5sum /sys/bus/spi/devices/spi0.0/spi-nor/sfdp
0fbb3fac2bc788513976d01840fd598f /sys/bus/spi/devices/spi0.0/spi-nor/sfdp
zynq> test_qspi.sh
6+0 records in
6+0 records out
6291456 bytes (6.0MB) copied, 0.231796 seconds, 25.9MB/s
Copied 6291456 bytes from qspi_test to address 0x00000000 in flash
Erased 6291456 bytes from address 0x00000000 in flash
Copied 6291456 bytes from address 0x00000000 in flash to qspi_read
0000000 ffff ffff ffff ffff ffff ffff ffff ffff
*
0600000
Copied 6291456 bytes from qspi_test to address 0x00000000 in flash
Copied 6291456 bytes from address 0x00000000 in flash to qspi_read
296c691a4653e0f5c334e1a9953d8cb4b1038d47 qspi_test
296c691a4653e0f5c334e1a9953d8cb4b1038d47 qspi_read
-------------------------------------------------------------------------
zynq> cat /sys/bus/spi/devices/spi0.0/spi-nor/partname
s28hs01gt
zynq> cat /sys/bus/spi/devices/spi0.0/spi-nor/jedec_id
345b1b
zynq> cat /sys/bus/spi/devices/spi0.0/spi-nor/manufacturer
spansion
zynq> xxd -p /sys/bus/spi/devices/spi0.0/spi-nor/sfdp
53464450080105fe00000114000100ff84000102500100ff050001055801
00ff8700011c6c0100ff0a000104dc0100ff81000116ec0100ffffffffff
ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
fffffffffffffffffffffffffffffffff7218affffffff3f000000000000
0000eeffffffffff0000ffff00000c2100ff00ff12dc23faff8b82e7ffe6
ec031c607ab07ab0f766805c000000fff910f8a0000000000000bc020000
0000ffff8e8e41120ffe21ffffdc00ee800b7171656500b0ff96a80b0000
0c551ca20000800000000000c0ccffeb88fbffeb00650090060500a10065
009600650095716503d0716503d0a46bfb0290a579a20040288e0000ff00
0000ff0071650690716506900000000000000000716506d1716506d17165
0691716506910000ff000000ff00716505d5716505d50000a01500000601
000000000080710500004306fc65ff0804008000fc65ff4002008000fd65
ff0402008000fe0002fff1ff0100f8ff0100f8fffb07fe0302fff8fffb07
f8ff0100f1ff0100fe0104fff1ff0000f8ff0200f8fff707f8ff0200f1ff
0000ff0400fff8ffff07
zynq> md5sum /sys/bus/spi/devices/spi0.0/spi-nor/sfdp
08db437d1890431e1d35284579100222 /sys/bus/spi/devices/spi0.0/spi-nor/sfdp
zynq> test_qspi.sh
6+0 records in
6+0 records out
6291456 bytes (6.0MB) copied, 0.232206 seconds, 25.8MB/s
Copied 6291456 bytes from qspi_test to address 0x00000000 in flash
Erased 6291456 bytes from address 0x00000000 in flash
Copied 6291456 bytes from address 0x00000000 in flash to qspi_read
0000000 ffff ffff ffff ffff ffff ffff ffff ffff
*
0600000
Copied 6291456 bytes from qspi_test to address 0x00000000 in flash
Copied 6291456 bytes from address 0x00000000 in flash to qspi_read
1af7d491e78b33caa6c72d2f0062658dafe52451 qspi_test
1af7d491e78b33caa6c72d2f0062658dafe52451 qspi_read
-------------------------------------------------------------------------
Takahiro Kuwano (2):
mtd: spi-nor: spansion: Rename s28hs512t prefix
mtd: spi-nor: spansion: Add s28hl512t, s28hl01gt, and s28hs01gt info
drivers/mtd/spi-nor/spansion.c | 31 +++++++++++++++++++++++--------
1 file changed, 23 insertions(+), 8 deletions(-)
--
2.25.1
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 1/2] mtd: spi-nor: spansion: Rename s28hs512t prefix
2022-08-25 2:20 [PATCH 0/2] mtd: spi-nor: spansion: Add support for s28hl512t, s28hl01gt, and s28hs01gt tkuw584924
@ 2022-08-25 2:20 ` tkuw584924
2022-08-25 7:59 ` Michael Walle
2022-08-25 2:20 ` [PATCH 2/2] mtd: spi-nor: spansion: Add s28hl512t, s28hl01gt, and s28hs01gt info tkuw584924
1 sibling, 1 reply; 6+ messages in thread
From: tkuw584924 @ 2022-08-25 2:20 UTC (permalink / raw)
To: linux-mtd
Cc: tudor.ambarus, pratyush, michael, miquel.raynal, richard,
vigneshr, tkuw584924, Bacem.Daassi, Takahiro Kuwano
From: Takahiro Kuwano <Takahiro.Kuwano@infineon.com>
Change prefix to support all other devices in SEMPER S28 family.
Signed-off-by: Takahiro Kuwano <Takahiro.Kuwano@infineon.com>
---
drivers/mtd/spi-nor/spansion.c | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/mtd/spi-nor/spansion.c b/drivers/mtd/spi-nor/spansion.c
index 676ffd6d12ec..03f361089a05 100644
--- a/drivers/mtd/spi-nor/spansion.c
+++ b/drivers/mtd/spi-nor/spansion.c
@@ -281,13 +281,13 @@ static int cypress_nor_octal_dtr_enable(struct spi_nor *nor, bool enable)
cypress_nor_octal_dtr_dis(nor);
}
-static void s28hs512t_default_init(struct spi_nor *nor)
+static void s28hx_t_default_init(struct spi_nor *nor)
{
nor->params->octal_dtr_enable = cypress_nor_octal_dtr_enable;
nor->params->writesize = 16;
}
-static void s28hs512t_post_sfdp_fixup(struct spi_nor *nor)
+static void s28hx_t_post_sfdp_fixup(struct spi_nor *nor)
{
/*
* On older versions of the flash the xSPI Profile 1.0 table has the
@@ -315,17 +315,17 @@ static void s28hs512t_post_sfdp_fixup(struct spi_nor *nor)
nor->params->rdsr_addr_nbytes = 4;
}
-static int s28hs512t_post_bfpt_fixup(struct spi_nor *nor,
+static int s28hx_t_post_bfpt_fixup(struct spi_nor *nor,
const struct sfdp_parameter_header *bfpt_header,
const struct sfdp_bfpt *bfpt)
{
return cypress_nor_set_page_size(nor);
}
-static const struct spi_nor_fixups s28hs512t_fixups = {
- .default_init = s28hs512t_default_init,
- .post_sfdp = s28hs512t_post_sfdp_fixup,
- .post_bfpt = s28hs512t_post_bfpt_fixup,
+static const struct spi_nor_fixups s28hx_t_fixups = {
+ .default_init = s28hx_t_default_init,
+ .post_sfdp = s28hx_t_post_sfdp_fixup,
+ .post_bfpt = s28hx_t_post_bfpt_fixup,
};
static int
@@ -462,7 +462,7 @@ static const struct flash_info spansion_nor_parts[] = {
{ "s28hs512t", INFO(0x345b1a, 0, 256 * 1024, 256)
NO_SFDP_FLAGS(SECT_4K | SPI_NOR_OCTAL_DTR_READ |
SPI_NOR_OCTAL_DTR_PP)
- .fixups = &s28hs512t_fixups,
+ .fixups = &s28hx_t_fixups,
},
};
--
2.25.1
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 2/2] mtd: spi-nor: spansion: Add s28hl512t, s28hl01gt, and s28hs01gt info
2022-08-25 2:20 [PATCH 0/2] mtd: spi-nor: spansion: Add support for s28hl512t, s28hl01gt, and s28hs01gt tkuw584924
2022-08-25 2:20 ` [PATCH 1/2] mtd: spi-nor: spansion: Rename s28hs512t prefix tkuw584924
@ 2022-08-25 2:20 ` tkuw584924
2022-08-25 7:57 ` Michael Walle
1 sibling, 1 reply; 6+ messages in thread
From: tkuw584924 @ 2022-08-25 2:20 UTC (permalink / raw)
To: linux-mtd
Cc: tudor.ambarus, pratyush, michael, miquel.raynal, richard,
vigneshr, tkuw584924, Bacem.Daassi, Takahiro Kuwano
From: Takahiro Kuwano <Takahiro.Kuwano@infineon.com>
Add flash info table entries for s28hl512gt, s28hl01gt, and s28hs01gt.
These devices have the same functionality as s28hs512t.
Signed-off-by: Takahiro Kuwano <Takahiro.Kuwano@infineon.com>
---
drivers/mtd/spi-nor/spansion.c | 15 +++++++++++++++
1 file changed, 15 insertions(+)
diff --git a/drivers/mtd/spi-nor/spansion.c b/drivers/mtd/spi-nor/spansion.c
index 03f361089a05..76a0e31c8323 100644
--- a/drivers/mtd/spi-nor/spansion.c
+++ b/drivers/mtd/spi-nor/spansion.c
@@ -459,11 +459,26 @@ static const struct flash_info spansion_nor_parts[] = {
.fixups = &s25hx_t_fixups },
{ "cy15x104q", INFO6(0x042cc2, 0x7f7f7f, 512 * 1024, 1)
FLAGS(SPI_NOR_NO_ERASE) },
+ { "s28hl512t", INFO(0x345a1a, 0, 256 * 1024, 256)
+ NO_SFDP_FLAGS(SECT_4K | SPI_NOR_OCTAL_DTR_READ |
+ SPI_NOR_OCTAL_DTR_PP)
+ .fixups = &s28hx_t_fixups,
+ },
+ { "s28hl01gt", INFO(0x345a1b, 0, 256 * 1024, 512)
+ NO_SFDP_FLAGS(SECT_4K | SPI_NOR_OCTAL_DTR_READ |
+ SPI_NOR_OCTAL_DTR_PP)
+ .fixups = &s28hx_t_fixups,
+ },
{ "s28hs512t", INFO(0x345b1a, 0, 256 * 1024, 256)
NO_SFDP_FLAGS(SECT_4K | SPI_NOR_OCTAL_DTR_READ |
SPI_NOR_OCTAL_DTR_PP)
.fixups = &s28hx_t_fixups,
},
+ { "s28hs01gt", INFO(0x345b1b, 0, 256 * 1024, 512)
+ NO_SFDP_FLAGS(SECT_4K | SPI_NOR_OCTAL_DTR_READ |
+ SPI_NOR_OCTAL_DTR_PP)
+ .fixups = &s28hx_t_fixups,
+ },
};
/**
--
2.25.1
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 2/2] mtd: spi-nor: spansion: Add s28hl512t, s28hl01gt, and s28hs01gt info
2022-08-25 2:20 ` [PATCH 2/2] mtd: spi-nor: spansion: Add s28hl512t, s28hl01gt, and s28hs01gt info tkuw584924
@ 2022-08-25 7:57 ` Michael Walle
2022-08-26 10:00 ` Takahiro Kuwano
0 siblings, 1 reply; 6+ messages in thread
From: Michael Walle @ 2022-08-25 7:57 UTC (permalink / raw)
To: tkuw584924
Cc: linux-mtd, tudor.ambarus, pratyush, miquel.raynal, richard,
vigneshr, Bacem.Daassi, Takahiro Kuwano
Am 2022-08-25 04:20, schrieb tkuw584924@gmail.com:
> From: Takahiro Kuwano <Takahiro.Kuwano@infineon.com>
>
> Add flash info table entries for s28hl512gt, s28hl01gt, and s28hs01gt.
> These devices have the same functionality as s28hs512t.
>
> Signed-off-by: Takahiro Kuwano <Takahiro.Kuwano@infineon.com>
> ---
> drivers/mtd/spi-nor/spansion.c | 15 +++++++++++++++
> 1 file changed, 15 insertions(+)
>
> diff --git a/drivers/mtd/spi-nor/spansion.c
> b/drivers/mtd/spi-nor/spansion.c
> index 03f361089a05..76a0e31c8323 100644
> --- a/drivers/mtd/spi-nor/spansion.c
> +++ b/drivers/mtd/spi-nor/spansion.c
> @@ -459,11 +459,26 @@ static const struct flash_info
> spansion_nor_parts[] = {
> .fixups = &s25hx_t_fixups },
> { "cy15x104q", INFO6(0x042cc2, 0x7f7f7f, 512 * 1024, 1)
> FLAGS(SPI_NOR_NO_ERASE) },
> + { "s28hl512t", INFO(0x345a1a, 0, 256 * 1024, 256)
> + NO_SFDP_FLAGS(SECT_4K | SPI_NOR_OCTAL_DTR_READ |
> + SPI_NOR_OCTAL_DTR_PP)
Do you really need the NO_SFDP_FLAGS here? And then the usual:
could you test with
{ "s28hl512t", INFO(0x345a1a, 0, 0, 0)
.fixups = &s28hx_t_fixups,
},
You might need
https://lore.kernel.org/linux-mtd/20220810220654.1297699-6-michael@walle.cc/
-michael
> + .fixups = &s28hx_t_fixups,
> + },
> + { "s28hl01gt", INFO(0x345a1b, 0, 256 * 1024, 512)
> + NO_SFDP_FLAGS(SECT_4K | SPI_NOR_OCTAL_DTR_READ |
> + SPI_NOR_OCTAL_DTR_PP)
> + .fixups = &s28hx_t_fixups,
> + },
> { "s28hs512t", INFO(0x345b1a, 0, 256 * 1024, 256)
> NO_SFDP_FLAGS(SECT_4K | SPI_NOR_OCTAL_DTR_READ |
> SPI_NOR_OCTAL_DTR_PP)
> .fixups = &s28hx_t_fixups,
> },
> + { "s28hs01gt", INFO(0x345b1b, 0, 256 * 1024, 512)
> + NO_SFDP_FLAGS(SECT_4K | SPI_NOR_OCTAL_DTR_READ |
> + SPI_NOR_OCTAL_DTR_PP)
> + .fixups = &s28hx_t_fixups,
> + },
> };
>
> /**
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] mtd: spi-nor: spansion: Rename s28hs512t prefix
2022-08-25 2:20 ` [PATCH 1/2] mtd: spi-nor: spansion: Rename s28hs512t prefix tkuw584924
@ 2022-08-25 7:59 ` Michael Walle
0 siblings, 0 replies; 6+ messages in thread
From: Michael Walle @ 2022-08-25 7:59 UTC (permalink / raw)
To: tkuw584924
Cc: linux-mtd, tudor.ambarus, pratyush, miquel.raynal, richard,
vigneshr, Bacem.Daassi, Takahiro Kuwano
Am 2022-08-25 04:20, schrieb tkuw584924@gmail.com:
> From: Takahiro Kuwano <Takahiro.Kuwano@infineon.com>
>
> Change prefix to support all other devices in SEMPER S28 family.
>
> Signed-off-by: Takahiro Kuwano <Takahiro.Kuwano@infineon.com>
I'm still no fan of all the renames. But I don't think this will
do any more harm than what there already is :)
Reviewed-by: Michael Walle <michael@walle.cc>
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 2/2] mtd: spi-nor: spansion: Add s28hl512t, s28hl01gt, and s28hs01gt info
2022-08-25 7:57 ` Michael Walle
@ 2022-08-26 10:00 ` Takahiro Kuwano
0 siblings, 0 replies; 6+ messages in thread
From: Takahiro Kuwano @ 2022-08-26 10:00 UTC (permalink / raw)
To: Michael Walle
Cc: linux-mtd, tudor.ambarus, pratyush, miquel.raynal, richard,
vigneshr, Bacem.Daassi, Takahiro Kuwano
On 8/25/2022 4:57 PM, Michael Walle wrote:
> Am 2022-08-25 04:20, schrieb tkuw584924@gmail.com:
>> From: Takahiro Kuwano <Takahiro.Kuwano@infineon.com>
>>
>> Add flash info table entries for s28hl512gt, s28hl01gt, and s28hs01gt.
>> These devices have the same functionality as s28hs512t.
>>
>> Signed-off-by: Takahiro Kuwano <Takahiro.Kuwano@infineon.com>
>> ---
>> drivers/mtd/spi-nor/spansion.c | 15 +++++++++++++++
>> 1 file changed, 15 insertions(+)
>>
>> diff --git a/drivers/mtd/spi-nor/spansion.c b/drivers/mtd/spi-nor/spansion.c
>> index 03f361089a05..76a0e31c8323 100644
>> --- a/drivers/mtd/spi-nor/spansion.c
>> +++ b/drivers/mtd/spi-nor/spansion.c
>> @@ -459,11 +459,26 @@ static const struct flash_info spansion_nor_parts[] = {
>> .fixups = &s25hx_t_fixups },
>> { "cy15x104q", INFO6(0x042cc2, 0x7f7f7f, 512 * 1024, 1)
>> FLAGS(SPI_NOR_NO_ERASE) },
>> + { "s28hl512t", INFO(0x345a1a, 0, 256 * 1024, 256)
>> + NO_SFDP_FLAGS(SECT_4K | SPI_NOR_OCTAL_DTR_READ |
>> + SPI_NOR_OCTAL_DTR_PP)
>
> Do you really need the NO_SFDP_FLAGS here? And then the usual:
> could you test with
> { "s28hl512t", INFO(0x345a1a, 0, 0, 0)
PARSE_SFDP?
> .fixups = &s28hx_t_fixups,
> },
>
With some minor changes in sfdp.c and spansion.c, it's working.
I will do more tests then revise the series.
Thank you!
Takahiro
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-08-26 10:00 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-25 2:20 [PATCH 0/2] mtd: spi-nor: spansion: Add support for s28hl512t, s28hl01gt, and s28hs01gt tkuw584924
2022-08-25 2:20 ` [PATCH 1/2] mtd: spi-nor: spansion: Rename s28hs512t prefix tkuw584924
2022-08-25 7:59 ` Michael Walle
2022-08-25 2:20 ` [PATCH 2/2] mtd: spi-nor: spansion: Add s28hl512t, s28hl01gt, and s28hs01gt info tkuw584924
2022-08-25 7:57 ` Michael Walle
2022-08-26 10:00 ` Takahiro Kuwano
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).