Linux-mtd Archive on lore.kernel.org
 help / color / Atom feed
From: Bastian Germann <bage@linutronix.de>
To: David Oberhollenzer <david.oberhollenzer@sigma-star.at>,
	Richard Weinberger <richard.weinberger@gmail.com>
Cc: linux-mtd@lists.infradead.org
Subject: Re: [PATCH] mkfs.ubifs: remove OPENSSL_no_config()
Date: Tue, 29 Sep 2020 16:05:03 +0200
Message-ID: <5efdb785-cd31-1bb1-b1cb-9d213b4d622f@linutronix.de> (raw)
In-Reply-To: <1bb381ec-1f5f-3844-d904-7dd2af58577d@sigma-star.at>

Am 25.09.20 um 05:15 schrieb David Oberhollenzer:
> On 9/24/20 6:40 PM, Bastian Germann wrote:
>> Am 25.07.20 um 10:24 schrieb Richard Weinberger:
>>> On Fri, Jul 24, 2020 at 10:00 AM <bage@linutronix.de> wrote:
>>>>
>>>> From: Torben Hohn <torben.hohn@linutronix.de>
>>>>
>>>> Especially for the pkcs11 engine, a configuration is required
>>>> because the provider has to be configured.
>>>>
>>>> Its not clear why OPENSSL_no_config() is called.
>>>
>>> My best guess is because on old openssl versions it used to work.
>>>
>>>> Remove OPENSSL_no_config() and call OPENSSL_config(NULL)
>>>> instead.
>>>
>>> David, can you please check whether this change works with all openssl versions
>>> we want to support?
>>>
>>
>> Are there any news on this?
>>
> 
> Sorry for the delay. I did some research on this in August but being busy at
> the time eventually forgot about the thread.
> 
> The latest changes that I found in the change log dated back to OpenSSL 0.9.7.
> Walking through the git log for the implementation seems to confirm that.
> 
> However, recent man pages say, that the OPENSSL_config functions are deprecated
> since OpenSSL 1.1.0 and OPENSSL_init_crypto should be used now, so the patch
> might require an extra #if for newer OpenSSL versions.
> 

That would be another patch but does not invalidate this one. mtd-utils
also uses other functions which are deprecated in OpenSSL >= 1.1.0:

OPENSSL_no_config
OpenSSL_add_all_digests
OpenSSL_add_all_algorithms
EVP_cleanup
ERR_free_strings
ERR_load_crypto_strings

You can yield this list via compiling with -DOPENSSL_API_COMPAT=0x10100000L.

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

  reply index

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-24  7:47 bage
2020-07-25  8:24 ` Richard Weinberger
2020-09-24 16:40   ` Bastian Germann
2020-09-25  3:15     ` David Oberhollenzer
2020-09-29 14:05       ` Bastian Germann [this message]
2020-10-18 20:44         ` David Oberhollenzer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5efdb785-cd31-1bb1-b1cb-9d213b4d622f@linutronix.de \
    --to=bage@linutronix.de \
    --cc=david.oberhollenzer@sigma-star.at \
    --cc=linux-mtd@lists.infradead.org \
    --cc=richard.weinberger@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-mtd Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-mtd/0 linux-mtd/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-mtd linux-mtd/ https://lore.kernel.org/linux-mtd \
		linux-mtd@lists.infradead.org
	public-inbox-index linux-mtd

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.infradead.lists.linux-mtd


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git