linux-mtd.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: "Rafał Miłecki" <rafal@milecki.pl>
To: Miquel Raynal <miquel.raynal@bootlin.com>
Cc: "Richard Weinberger" <richard@nod.at>,
	"Rafał Miłecki" <zajec5@gmail.com>,
	linux-mtd@lists.infradead.org,
	"Vignesh Raghavendra" <vigneshr@ti.com>,
	"Boris Brezillon" <bbrezillon@kernel.org>
Subject: Re: [PATCH] mtd: fix calculating partition end address
Date: Mon, 09 Mar 2020 15:19:10 +0100	[thread overview]
Message-ID: <6125d86fee0c83653cc281b3069e1587@milecki.pl> (raw)
In-Reply-To: <20200309150424.4b75af66@xps13>

On 2020-03-09 15:04, Miquel Raynal wrote:
> Rafał Miłecki <zajec5@gmail.com> wrote on Mon,  9 Mar 2020 08:44:45
> +0100:
> 
>> From: Rafał Miłecki <rafal@milecki.pl>
>> 
>> This fixes check for partitions that don't start at beginning of their
>> parents. Missing partition's offset in formula could result in forcing
>> read-only incorrectly.
>> 
>> Fixes: 6750f61a13a0 ("mtd: improve calculating partition boundaries 
>> when checking for alignment")
>> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
>> ---
>>  drivers/mtd/mtdpart.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/drivers/mtd/mtdpart.c b/drivers/mtd/mtdpart.c
>> index 7328c066c5ba..c683b432cc5e 100644
>> --- a/drivers/mtd/mtdpart.c
>> +++ b/drivers/mtd/mtdpart.c
>> @@ -524,7 +524,7 @@ static struct mtd_part *allocate_partition(struct 
>> mtd_info *parent,
>>  			part->name);
>>  	}
>> 
>> -	tmp = part_absolute_offset(parent) + slave->mtd.size;
>> +	tmp = part_absolute_offset(parent) + slave->offset + 
>> slave->mtd.size;
> 
> I think you are doing the change at the wrong place, if you want to
> check where the partition *starts* you should do it a few lines above.
> But I think the check should be here as well, probably.

The check where the partition *starts* is OK and I don't mean to change
it. The bug is about calculating absolute *end* address of partition.


> Anyway, I just applied on my local tree a patch rewriting a bit the
> partitioning scheme, could you please rebase on top of today's
> mtd/next and resend this patch updated?
> 
> Here is the change that I've done at this place:
> 	-       tmp = part_absolute_offset(parent) + slave->mtd.size;
> 	+       tmp = mtd_get_master_ofs(child, 0) + child->size;

I'll give it a try.

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

  reply	other threads:[~2020-03-09 14:19 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-09  7:44 [PATCH] mtd: fix calculating partition end address Rafał Miłecki
2020-03-09 14:04 ` Miquel Raynal
2020-03-09 14:19   ` Rafał Miłecki [this message]
2020-03-09 14:22     ` Miquel Raynal
2020-03-09 15:08       ` Rafał Miłecki
2020-03-09 15:22         ` Miquel Raynal
2020-05-02 18:04           ` Miquel Raynal
2020-05-02 19:36             ` Rafał Miłecki
2020-05-02 19:53               ` Miquel Raynal
2020-03-24 21:58     ` Miquel Raynal
2020-03-24 22:06       ` Rafał Miłecki
2020-03-24 22:11         ` Miquel Raynal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6125d86fee0c83653cc281b3069e1587@milecki.pl \
    --to=rafal@milecki.pl \
    --cc=bbrezillon@kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=miquel.raynal@bootlin.com \
    --cc=richard@nod.at \
    --cc=vigneshr@ti.com \
    --cc=zajec5@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).