From: Christian Marangi <ansuelsmth@gmail.com>
To: Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>
Cc: Miquel Raynal <miquel.raynal@bootlin.com>, linux-mtd@lists.infradead.org
Subject: Re: [syzbot] linux-next boot error: general protection fault in add_mtd_device
Date: Fri, 22 Jul 2022 04:51:46 +0200 [thread overview]
Message-ID: <62da6803.1c69fb81.2a10f.9bf1@mx.google.com> (raw)
In-Reply-To: <18701775-c174-96ce-31ce-478d8783b575@I-love.SAKURA.ne.jp>
On Fri, Jul 22, 2022 at 11:34:57AM +0900, Tetsuo Handa wrote:
> mtd_check_of_node() was added by commit ad9b10d1eaada169 ("mtd: core:
> introduce of support for dynamic partitions").
>
> I guess that sometimes (depending on probe timing) mtd->parent is NULL.
> Please check what mtd->parent == NULL means.
>
> + /* Check if a partitions node exist */
> + parent = mtd->parent;
> + parent_dn = dev_of_node(&parent->dev);
>
Currently there is thix [1].
Anyway you comment means a device may probe defer and have the parent
still set to NULL? How can we check that?
Return PROBE_DEFER always when no mtd parent is found?
[1] https://patchwork.ozlabs.org/project/linux-mtd/patch/20220703095631.16508-1-ansuelsmth@gmail.com/
> On 2022/06/30 18:32, syzbot wrote:
> > Hello,
> >
> > syzbot found the following issue on:
> >
> > HEAD commit: 6cc11d2a1759 Add linux-next specific files for 20220630
> > git tree: linux-next
> > console output: https://syzkaller.appspot.com/x/log.txt?x=1640f850080000
> > kernel config: https://syzkaller.appspot.com/x/.config?x=54f75b620e3845dd
> > dashboard link: https://syzkaller.appspot.com/bug?extid=fe013f55a2814a9e8cfd
> > compiler: gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2
> >
> > IMPORTANT: if you fix the issue, please add the following tag to the commit:
> > Reported-by: syzbot+fe013f55a2814a9e8cfd@syzkaller.appspotmail.com
--
Ansuel
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2022-07-22 9:04 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-30 9:32 [syzbot] linux-next boot error: general protection fault in add_mtd_device syzbot
2022-07-07 16:05 ` Siddh Raman Pant
2022-07-07 16:06 ` syzbot
2022-07-07 16:09 ` Siddh Raman Pant
2022-07-07 16:28 ` syzbot
2022-07-22 2:34 ` Tetsuo Handa
2022-07-22 2:51 ` Christian Marangi [this message]
2022-07-24 1:33 ` Tetsuo Handa
2022-07-24 1:37 ` Vanessa Page
2022-07-24 18:21 ` Linus Torvalds
2022-07-22 4:31 ` Vanessa Page
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=62da6803.1c69fb81.2a10f.9bf1@mx.google.com \
--to=ansuelsmth@gmail.com \
--cc=linux-mtd@lists.infradead.org \
--cc=miquel.raynal@bootlin.com \
--cc=penguin-kernel@i-love.sakura.ne.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).