From: Richard Weinberger <richard@nod.at>
To: liu song11 <liu.song11@zte.com.cn>
Cc: Richard Weinberger <richard.weinberger@gmail.com>,
linux-mtd <linux-mtd@lists.infradead.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
jiang xuexin <jiang.xuexin@zte.com.cn>
Subject: Re: [PATCH] ubifs: Fix potentially out-of-bounds memory access inubifs_dump_node
Date: Mon, 13 Jan 2020 09:30:44 +0100 (CET) [thread overview]
Message-ID: <646354604.19725.1578904244502.JavaMail.zimbra@nod.at> (raw)
In-Reply-To: <202001131616025809130@zte.com.cn>
----- Ursprüngliche Mail -----
> Although this will change a bit more, but the function of dumping data is
> retained,
> I will modify it as suggested and try to submit a patch, thanks.
Sure but the most common and important case is good then.
in fs/ubifs/file.c we use a fixed buffer size of UBIFS_MAX_DATA_NODE_SZ
to deal with data nodes. So, dumping is safe.
If we don't know the buffer size for minor cases, not a big deal.
Still better than giving up the feature completely.
Thanks,
//richard
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
parent reply other threads:[~2020-01-13 8:32 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <202001131616025809130@zte.com.cn>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=646354604.19725.1578904244502.JavaMail.zimbra@nod.at \
--to=richard@nod.at \
--cc=jiang.xuexin@zte.com.cn \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=liu.song11@zte.com.cn \
--cc=richard.weinberger@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).