From: Md Sadre Alam <quic_mdalam@quicinc.com>
To: Boris Brezillon <boris.brezillon@collabora.com>
Cc: <linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-mtd@lists.infradead.org>, <linux-arm-msm@vger.kernel.org>,
<robh+dt@kernel.org>, <vigneshr@ti.com>, <richard@nod.at>,
<miquel.raynal@bootlin.com>, <agross@kernel.org>,
<bjorn.andersson@linaro.org>, <quic_srichara@quicinc.com>,
<qpic_varada@quicinc.com>, <quic_sjaganat@quicinc.com>
Subject: Re: [PATCH 2/5] mtd: rawnand: qcom: Add initial support for qspi nand
Date: Mon, 6 Mar 2023 20:03:41 +0530 [thread overview]
Message-ID: <6d5ea6d8-d8c6-0875-f0b3-2fcaac64899d@quicinc.com> (raw)
In-Reply-To: <b70ddb40-a1f1-f967-6b7b-057a39b0bcc2@quicinc.com>
On 3/6/2023 7:45 PM, Md Sadre Alam wrote:
>
> On 10/29/2020 2:37 PM, Boris Brezillon wrote:
>> Hello,
>>
>> On Sat, 10 Oct 2020 11:01:39 +0530
>> Md Sadre Alam <mdalam@codeaurora.org> wrote:
>>
>>> This change will add initial support for qspi (serial nand).
>>>
>>> QPIC Version v.2.0 onwards supports serial nand as well so this
>>> change will initialize all required register to enable qspi (serial
>>> nand).
>>>
>>> This change is supporting very basic functionality of qspi nand flash.
>>>
>>> 1. Reset device (Reset QSPI NAND device).
>>>
>>> 2. Device detection (Read id QSPI NAND device).
>> Unfortunately, that's not going to work in the long term. You're
>> basically hacking the raw NAND framework to make SPI NANDs fit. I do
>> understand the rationale behind this decision (re-using the code for
>> ECC and probably other things), but that's not going to work. So I'd
>> recommend doing the following instead:
>>
>> 1/ implement a SPI-mem controller driver
>> 2/ implement an ECC engine driver so the ECC logic can be shared
>> between the SPI controller and raw NAND controller drivers
>> 3/ convert the raw NAND driver to the exec_op() interface (none of
>> this hack would have been possible if the driver was using the new
>> API)
>>
>> Regards,
>>
>> Boris
>>
> Sorry for late reply, again started working on this feature
> support. The QPIC v2 on wards there is serial nand support got added
> , its not a standard SPI controller
>
> its QPIC controller having support for serial nand. All SPI related
> configuration done by QPIC hardware and its not exposed as SPI bus to
> the external world. Only based on
>
> QPIC_SPI_CFG = 1, serial functionality will get selected. So that
> no need to implement as SPI-mem controller driver, since its not a SPI
> controller.
>
> Please check the below diagram for top view of QPIC controller.
>
>
___________________________________________________________________________
| QPIC wrapper |
AHB master IF |
|_______________________ __________________________
|
<------------------------------------------------- |
| QPIC | |
QPIC_IO_MACRO | |--------------------------------------------->Serial
NAND IOs
| | QPIC_SPI_CFG = 1 ----> |
| (Control SPI Bus internally) |
|--------------------------------------------->
| | | |
| |
| | | |
| |
| | |
|__________________________| |
| | | _
___________________________ |
| | | |
Ebi2_ext_if | |
| | QPIC_SPI_CFG=0 -------> | | |
|------------------------------------------------->
| | | | |
|-------------------------------------------------->Parallel NAND IOs
<---------------------------------------------------- |
|________________________ | | __________________________|
|
AHB Slav IF | |
|_____________________________________________________________________________|
>
>
>
> Regards,
>
> Alam.
>
>
>>
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2023-03-06 14:51 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-10 5:31 [PATCH 0/5] mtd: rawnand: qcom: Add support for QSPI nand Md Sadre Alam
2020-10-10 5:31 ` [PATCH 1/5] dt-bindings: qcom_nandc: IPQ5018 QPIC NAND documentation Md Sadre Alam
2020-10-13 16:21 ` Rob Herring
2020-10-10 5:31 ` [PATCH 2/5] mtd: rawnand: qcom: Add initial support for qspi nand Md Sadre Alam
2020-10-29 9:07 ` Boris Brezillon
2023-03-06 14:15 ` Md Sadre Alam
2023-03-06 14:33 ` Md Sadre Alam [this message]
2023-03-06 14:38 ` Miquel Raynal
2023-03-27 13:54 ` Md Sadre Alam
2023-03-27 14:49 ` Miquel Raynal
2023-03-28 11:18 ` Md Sadre Alam
2020-10-10 5:31 ` [PATCH 3/5] mtd: rawnand: qcom: Read QPIC version Md Sadre Alam
2020-10-10 5:31 ` [PATCH 4/5] mtd: rawnand: qcom: Enable support for erase, read & write for serial nand Md Sadre Alam
2020-10-10 5:31 ` [PATCH 5/5] mtd: rawnand: qcom: Add support for serial training Md Sadre Alam
2020-10-28 9:48 ` [PATCH 0/5] mtd: rawnand: qcom: Add support for QSPI nand Miquel Raynal
2020-10-28 18:24 ` mdalam
2020-10-29 7:53 ` Miquel Raynal
2020-10-29 8:37 ` Miquel Raynal
2020-10-29 8:38 ` Boris Brezillon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6d5ea6d8-d8c6-0875-f0b3-2fcaac64899d@quicinc.com \
--to=quic_mdalam@quicinc.com \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=boris.brezillon@collabora.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=miquel.raynal@bootlin.com \
--cc=qpic_varada@quicinc.com \
--cc=quic_sjaganat@quicinc.com \
--cc=quic_srichara@quicinc.com \
--cc=richard@nod.at \
--cc=robh+dt@kernel.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).