From: <Tudor.Ambarus@microchip.com>
To: <shuhao.mai.1990@gmail.com>, <miquel.raynal@bootlin.com>,
<richard@nod.at>, <vigneshr@ti.com>
Cc: linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mtd: spi-nor: winbond: Add support for w25q512jv
Date: Mon, 4 Jan 2021 08:58:26 +0000 [thread overview]
Message-ID: <6e59d200-f4a6-459e-8cba-86782413ae8b@microchip.com> (raw)
In-Reply-To: <20201111014556.6579-1-shuhao.mai.1990@gmail.com>
Hi, Shuhao,
On 11/11/20 3:45 AM, Shuhao Mai wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> Add support for w25q512jv. This is of the same series chip with
> w25q256jv, which is already supported, but with size doubled and
> different JEDEC ID.
Where and how was this tested? Please add this info in the commit
message.
>
> Signed-off-by: Shuhao Mai <shuhao.mai.1990@gmail.com>
> ---
> drivers/mtd/spi-nor/winbond.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/mtd/spi-nor/winbond.c b/drivers/mtd/spi-nor/winbond.c
> index e5dfa786f190..beaa6389e2dc 100644
> --- a/drivers/mtd/spi-nor/winbond.c
> +++ b/drivers/mtd/spi-nor/winbond.c
> @@ -97,6 +97,8 @@ static const struct flash_info winbond_parts[] = {
> SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
> { "w25m512jv", INFO(0xef7119, 0, 64 * 1024, 1024,
> SECT_4K | SPI_NOR_QUAD_READ | SPI_NOR_DUAL_READ) },
> + { "w25q512jv", INFO(0xef4020, 0, 64 * 1024, 1024,
We should name it "w25q512jvq" in order to differentiate it to the
"M" version: https://www.winbond.com/resource-files/W25Q512JV%20DTR%20RevD%2006292020%20133.pdf
The flash supports BP locking and we can enable it if you can test
the locking with mtd-utils. Not mandatory though.
Cheers,
ta
> + SECT_4K | SPI_NOR_QUAD_READ | SPI_NOR_DUAL_READ) },
> };
>
> /**
> --
> 2.20.1
>
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2021-01-04 8:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-11 1:45 [PATCH] mtd: spi-nor: winbond: Add support for w25q512jv Shuhao Mai
2021-01-04 8:58 ` Tudor.Ambarus [this message]
2021-01-07 11:35 ` Shuhao Mai
2021-02-08 7:53 ` [PATCH v2] mtd: spi-nor: winbond: Add support for w25q512jvq Shuhao Mai
2021-03-08 5:50 ` Tudor Ambarus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6e59d200-f4a6-459e-8cba-86782413ae8b@microchip.com \
--to=tudor.ambarus@microchip.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=miquel.raynal@bootlin.com \
--cc=richard@nod.at \
--cc=shuhao.mai.1990@gmail.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).