From: "Andrew Jeffery" <andrew@aj.id.au>
To: "Nishka Dasgupta" <nishkadg.linux@gmail.com>,
marek.vasut@gmail.com, tudor.ambarus@microchip.com,
dwmw2@infradead.org, computersforpeace@gmail.com,
miquel.raynal@bootlin.com, richard@nod.at, vigneshr@ti.com,
"Joel Stanley" <joel@jms.id.au>,
linux-mtd@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-aspeed@lists.ozlabs.org
Subject: Re: [PATCH] mtd: spi-nor: aspeed-smc: Add of_node_put()
Date: Fri, 09 Aug 2019 10:08:45 +0930 [thread overview]
Message-ID: <7335d5d1-77c7-4cfe-9ba5-2fc81e3e69eb@www.fastmail.com> (raw)
In-Reply-To: <20190808075104.15928-1-nishkadg.linux@gmail.com>
On Thu, 8 Aug 2019, at 17:21, Nishka Dasgupta wrote:
> Each iteration of for_each_available_child_of_node puts the previous
> node, but in the case of a break from the middle of the loop, there is
> no put, thus causing a memory leak. Upon termination of the loop
> (whether by break or a natural exit), either ret will have a non-zero
> value or child will be NULL. Hence add an of_node_put() that will
> execute only when ret has a non-zero value, as calling of_node_put() on
> a possible NULL value does not cause any further issues.
> Issue found with Coccinelle.
>
> Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com>
Reviewed-by: Andrew Jeffery <andrew@aj.id.au>
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2019-08-09 0:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-08 7:51 [PATCH] mtd: spi-nor: aspeed-smc: Add of_node_put() Nishka Dasgupta
2019-08-09 0:38 ` Andrew Jeffery [this message]
2019-08-28 10:20 ` Tudor.Ambarus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7335d5d1-77c7-4cfe-9ba5-2fc81e3e69eb@www.fastmail.com \
--to=andrew@aj.id.au \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=joel@jms.id.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-mtd@lists.infradead.org \
--cc=marek.vasut@gmail.com \
--cc=miquel.raynal@bootlin.com \
--cc=nishkadg.linux@gmail.com \
--cc=richard@nod.at \
--cc=tudor.ambarus@microchip.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).