linux-mtd.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
To: Miquel Raynal <miquel.raynal@bootlin.com>, Rob Herring <robh@kernel.org>
Cc: Richard Weinberger <richard@nod.at>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	Tudor Ambarus <Tudor.Ambarus@microchip.com>,
	linux-mtd@lists.infradead.org, devicetree@vger.kernel.org,
	Michal Simek <monstr@monstr.eu>,
	Naga Sureshkumar Relli <nagasure@xilinx.com>,
	Amit Kumar Mahapatra <akumarma@xilinx.com>,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, helmut.grohne@intenta.de,
	Srinivas Goud <sgoud@xilinx.com>,
	Siva Durga Prasad Paladugu <sivadur@xilinx.com>
Subject: Re: [PATCH v23 08/18] dt-binding: memory: pl353-smc: Enhance the description of the reg property
Date: Thu, 10 Jun 2021 23:12:12 +0200	[thread overview]
Message-ID: <76a94eb1-170a-307d-e1ce-1080a7af6a0a@canonical.com> (raw)
In-Reply-To: <20210610180107.1cc889f3@xps13>

On 10/06/2021 18:01, Miquel Raynal wrote:
> Hi Rob, Krzysztof,
> 
> Rob Herring <robh@kernel.org> wrote on Thu, 10 Jun 2021 10:53:45 -0500:
> 
>> On Thu, Jun 10, 2021 at 10:20:30AM +0200, Miquel Raynal wrote:
>>> The SMC bus controller features several register sets. The one pointed
>>> by the reg property is for the SMC configuration (impacts the
>>> sub-controllers configuration), while the others are meant to be used to
>>> send regular cycles on the memory bus (eg. CMD, ADDR, DATA for a NAND
>>> device). Detail this a little bit for the sake of clarity.
>>>
>>> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
>>> ---
>>>  .../devicetree/bindings/memory-controllers/pl353-smc.txt       | 3 ++-
>>>  1 file changed, 2 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/Documentation/devicetree/bindings/memory-controllers/pl353-smc.txt b/Documentation/devicetree/bindings/memory-controllers/pl353-smc.txt
>>> index ecd46856f139..ba6a5426f62b 100644
>>> --- a/Documentation/devicetree/bindings/memory-controllers/pl353-smc.txt
>>> +++ b/Documentation/devicetree/bindings/memory-controllers/pl353-smc.txt
>>> @@ -5,7 +5,8 @@ of memory interfaces: NAND and memory mapped interfaces (such as SRAM or NOR).
>>>  
>>>  Required properties:
>>>  - compatible		: Should be "arm,pl353-smc-r2p1", "arm,primecell".
>>> -- reg			: Controller registers map and length.
>>> +- reg			: SMC controller and sub-controllers configuration
>>> +			  registers.  
>>
>> I think you could just drop this patch. Otherwise, this doesn't match 
>> what's now in the yaml file.
> 
> Fine.
> 
> Krzysztof, if it's still time you can just take patch 9 which Rob
> just acked and forget about this one. I think we'll be good. Otherwise
> that will be for the next MW ;)

I skipped this one but took dtschema (9/18) so it should be in
tomorrow's linux-next.

Best regards,
Krzysztof

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

  reply	other threads:[~2021-06-10 21:13 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-10  8:20 [PATCH v23 00/18] ARM Primecell PL35x support Miquel Raynal
2021-06-10  8:20 ` [PATCH v23 01/18] dt-binding: memory: pl353-smc: Rephrase the binding Miquel Raynal
2021-06-10  8:20 ` [PATCH v23 02/18] dt-binding: memory: pl353-smc: Document the range property Miquel Raynal
2021-06-10  8:20 ` [PATCH v23 03/18] dt-binding: memory: pl353-smc: Drop the partitioning section Miquel Raynal
2021-06-10  8:20 ` [PATCH v23 04/18] dt-binding: memory: pl353-smc: Describe the child reg property Miquel Raynal
2021-06-10  8:20 ` [PATCH v23 05/18] dt-binding: memory: pl353-smc: Fix the example syntax and style Miquel Raynal
2021-06-10  8:20 ` [PATCH v23 06/18] dt-binding: memory: pl353-smc: Drop unsupported nodes from the example Miquel Raynal
2021-06-10  8:20 ` [PATCH v23 07/18] dt-binding: memory: pl353-smc: Fix the NAND controller node in " Miquel Raynal
2021-06-10  8:20 ` [PATCH v23 08/18] dt-binding: memory: pl353-smc: Enhance the description of the reg property Miquel Raynal
2021-06-10 15:53   ` Rob Herring
2021-06-10 16:01     ` Miquel Raynal
2021-06-10 21:12       ` Krzysztof Kozlowski [this message]
2021-06-10  8:20 ` [PATCH v23 09/18] dt-binding: memory: pl353-smc: Convert to yaml Miquel Raynal
2021-06-10 15:44   ` Rob Herring
2021-06-10  8:20 ` [PATCH v23 10/18] memory: pl353-smc: Fix style Miquel Raynal
2021-06-10  8:20 ` [PATCH v23 11/18] memory: pl353-smc: Rename goto labels Miquel Raynal
2021-06-10  8:20 ` [PATCH v23 12/18] memory: pl353-smc: Let lower level controller drivers handle inits Miquel Raynal
2021-06-10  8:20 ` [PATCH v23 13/18] memory: pl353-smc: Avoid useless acronyms in descriptions Miquel Raynal
2021-06-10  8:20 ` [PATCH v23 14/18] memory: pl353-smc: Declare variables following a reverse christmas tree order Miquel Raynal
2021-06-10  8:20 ` [PATCH v23 15/18] MAINTAINERS: Add PL353 SMC entry Miquel Raynal
2021-06-10  8:20 ` [PATCH v23 16/18] MAINTAINERS: Add PL353 NAND controller entry Miquel Raynal
2021-06-11 19:02   ` Miquel Raynal
2021-06-10  8:20 ` [PATCH v23 17/18] dt-bindings: mtd: pl353-nand: Describe this hardware controller Miquel Raynal
2021-06-10  8:48   ` Krzysztof Kozlowski
2021-06-10  8:56     ` Miquel Raynal
2021-06-10 15:48       ` Rob Herring
2021-06-10 15:49   ` Rob Herring
2021-06-11 19:01   ` Miquel Raynal
2021-06-10  8:20 ` [PATCH v23 18/18] mtd: rawnand: pl353: Add support for the ARM PL353 SMC NAND controller Miquel Raynal
2021-06-11 19:01   ` Miquel Raynal
2021-06-10 15:21 ` [PATCH v23 00/18] ARM Primecell PL35x support Krzysztof Kozlowski
2021-06-10 15:24 ` Krzysztof Kozlowski
2021-06-10 21:09 ` (subset) " Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=76a94eb1-170a-307d-e1ce-1080a7af6a0a@canonical.com \
    --to=krzysztof.kozlowski@canonical.com \
    --cc=Tudor.Ambarus@microchip.com \
    --cc=akumarma@xilinx.com \
    --cc=devicetree@vger.kernel.org \
    --cc=helmut.grohne@intenta.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=miquel.raynal@bootlin.com \
    --cc=monstr@monstr.eu \
    --cc=nagasure@xilinx.com \
    --cc=richard@nod.at \
    --cc=robh@kernel.org \
    --cc=sgoud@xilinx.com \
    --cc=sivadur@xilinx.com \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=vigneshr@ti.com \
    --subject='Re: [PATCH v23 08/18] dt-binding: memory: pl353-smc: Enhance the description of the reg property' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).