From: Dinh Nguyen <dinguyen@kernel.org>
To: Tudor.Ambarus@microchip.com, linux-mtd@lists.infradead.org
Cc: marex@denx.de, tien.fong.chee@intel.com, bbrezillon@kernel.org,
linux-kernel@vger.kernel.org, computersforpeace@gmail.com,
dwmw2@infradead.org
Subject: Re: [PATCHv5 2/2] mtd: spi-nor: cadence-quadspi: add reset control
Date: Wed, 12 Jun 2019 16:12:10 -0500 [thread overview]
Message-ID: <7a31d825-53a0-5b1f-af88-daff2b529587@kernel.org> (raw)
In-Reply-To: <2ee32a0d-7523-0b23-072e-e68af4977db7@microchip.com>
On 6/12/19 10:07 AM, Tudor.Ambarus@microchip.com wrote:
>
>
> On 06/12/2019 05:37 PM, Dinh Nguyen wrote:
>> External E-Mail
>>
>>
>> Get the reset control properties for the QSPI controller and bring them
>> out of reset. Most will have just one reset bit, but there is an additional
>> OCP reset bit that is used ECC. The OCP reset bit will also need to get
>> de-asserted as well. [1]
>>
>> The reason this patch is needed is in the case where a bootloader leaves
>> the QSPI controller in a reset state, or a state where init cannot occur
>> successfully, this patch will put the QSPI controller into a clean state.
>>
>> [1] https://www.intel.com/content/www/us/en/programmable/hps/arria-10/hps.html#reg_soc_top/sfo1429890575955.html
>>
>> Suggested-by: Tien-Fong Chee <tien.fong.chee@intel.com>
>> Signed-off-by: Dinh Nguyen <dinguyen@kernel.org>
>> ---
>> v5: remove udelay(not needed) on tested hardware
>> group reset assert/deassert together
>> update commit message with reasoning for patch
>> v4: fix compile error
>> v3: return full error by using PTR_ERR(rtsc)
>> move reset control calls until after the clock enables
>> use udelay(2) to be safe
>> Add optional OCP(Open Core Protocol) reset signal
>> v2: use devm_reset_control_get_optional_exclusive
>> print an error message
>> return -EPROBE_DEFER
>> ---
>> drivers/mtd/spi-nor/cadence-quadspi.c | 26 ++++++++++++++++++++++++++
>> 1 file changed, 26 insertions(+)
>>
>> diff --git a/drivers/mtd/spi-nor/cadence-quadspi.c b/drivers/mtd/spi-nor/cadence-quadspi.c
>> index 792628750eec..f8b1009e488c 100644
>> --- a/drivers/mtd/spi-nor/cadence-quadspi.c
>> +++ b/drivers/mtd/spi-nor/cadence-quadspi.c
>> @@ -34,6 +34,7 @@
>> #include <linux/of.h>
>> #include <linux/platform_device.h>
>> #include <linux/pm_runtime.h>
>> +#include <linux/reset.h>
>> #include <linux/sched.h>
>> #include <linux/spi/spi.h>
>> #include <linux/timer.h>
>> @@ -1336,6 +1337,8 @@ static int cqspi_probe(struct platform_device *pdev)
>> struct cqspi_st *cqspi;
>> struct resource *res;
>> struct resource *res_ahb;
>> + struct reset_control *rstc;
>> + struct reset_control *rstc_ocp;
>> const struct cqspi_driver_platdata *ddata;
>> int ret;
>> int irq;
>> @@ -1402,6 +1405,29 @@ static int cqspi_probe(struct platform_device *pdev)
>> goto probe_clk_failed;
>> }
>>
>> + /* Obtain QSPI reset control */
>> + rstc = devm_reset_control_get_optional_exclusive(dev, "qspi");
>> + if (IS_ERR(rstc)) {
>> + dev_err(dev, "Cannot get QSPI reset.\n");
>> + return PTR_ERR(rstc);
>> + }
>> +
>> + rstc_ocp = devm_reset_control_get_optional_exclusive(dev, "qspi-ocp");
>> + if (IS_ERR(rstc_ocp)) {
>> + dev_err(dev, "Cannot get QSPI OCP reset.\n");
>> + return PTR_ERR(rstc_ocp);
>> + }
>> +
>> + if (rstc) {
>
> Hi, Dinh,
>
> reset_control_assert/deassert() already have checks for null, you can call them
> directly without checking for null.
>
>> + reset_control_assert(rstc);
>> + reset_control_deassert(rstc);
>
> Is there any difference between:
> reset_control_assert(rstc);
> reset_control_assert(rstc_ocp);
>
> reset_control_deassert(rstc);
> reset_control_deassert(rstc_ocp);
>
> and:
>
> reset_control_assert(rstc);
> reset_control_deassert(rstc);
>
> reset_control_assert(rstc_ocp);
> reset_control_deassert(rstc_ocp);
>
> Which one would you choose?
>
I prefer grouping the assert/deassert for each reset pointer together.
Dinh
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
prev parent reply other threads:[~2019-06-12 21:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-12 14:37 [PATCHv5 1/2] dt-bindings: cadence-quadspi: add optional reset property Dinh Nguyen
2019-06-12 14:37 ` [PATCHv5 2/2] mtd: spi-nor: cadence-quadspi: add reset control Dinh Nguyen
2019-06-12 15:07 ` Tudor.Ambarus
2019-06-12 21:12 ` Dinh Nguyen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7a31d825-53a0-5b1f-af88-daff2b529587@kernel.org \
--to=dinguyen@kernel.org \
--cc=Tudor.Ambarus@microchip.com \
--cc=bbrezillon@kernel.org \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=marex@denx.de \
--cc=tien.fong.chee@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).