From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CA4C7C43334 for ; Wed, 6 Jul 2022 21:02:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:Subject:Cc:To:From :Date:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=oo9xoWEOCMx4yoiKHZDXXgOciOTT9BqGdH79+ErXeBg=; b=mt7lwFaSMBzqa99HFmWLQ8UXbV olmFSz7fH+JPMzG+940ZfWi634Zb847REJkLYFilKDS8qz+7h0ba6rh4WluDsVOx3FK9+rEaN3LNT t4maNk/zIYqlganu01EKZawc+jVW6LiCg9SvGkxlgQ9bGby/NCYDdx+mMgN4NU6WwSz/WRokbKeQz GORSPhla9Jh+YhiWAW+8dA1fQL4OsUmyhFDm4cp6GhYU1fA/eCObBxJ2kaafKKBnJdxkdKeliBoT9 kcn12cCkrN80Yadjd2YORy3Fma0C2JzXtUKoTt/EcT5XkRW5oo/9XEEVkoPer0e/WX0j9PxKHZ/HW JB1uNXIA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o9CAE-00COsV-CF; Wed, 06 Jul 2022 21:02:26 +0000 Received: from ssl.serverraum.org ([2a01:4f8:151:8464::1:2]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o9CA2-00COoD-Me; Wed, 06 Jul 2022 21:02:16 +0000 Received: from ssl.serverraum.org (web.serverraum.org [172.16.0.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ssl.serverraum.org (Postfix) with ESMTPSA id BABEB2223A; Wed, 6 Jul 2022 23:02:12 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=walle.cc; s=mail2016061301; t=1657141332; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=l9BSZkguRrgG6EPhutYIDpmenXtzq7TNMD8r/kLbskc=; b=WV6CXeZou7RvdPtdmr829rwyfN9tS5+35cTyMXOAxcqfznoaZT/8RuIdbp+P9ggkpqNWH+ La5o6Jh73TqZrLjKcdw7QVMk4YsHTqNT9+gN1Owvkuh6DIZuy8V4jy7xN4bymULQ73VoM6 FyvYVXrg8rAbo8PD3ftsNbU1LztRfbk= MIME-Version: 1.0 Date: Wed, 06 Jul 2022 23:02:12 +0200 From: Michael Walle To: haibo.chen@nxp.com Cc: ashish.kumar@nxp.com, yogeshgaur.83@gmail.com, broonie@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, han.xu@nxp.com, singh.kuldeep87k@gmail.com, tudor.ambarus@microchip.com, p.yadav@ti.com, miquel.raynal@bootlin.com, richard@nod.at, vigneshr@ti.com, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-mtd@lists.infradead.org, festevam@gmail.com, linux-imx@nxp.com, linux-arm-kernel@lists.infradead.org, zhengxunli@mxic.com.tw Subject: Re: [PATCH 04/11] spi: spi-nxp-fspi: add function to select sample clock source for flash reading In-Reply-To: <1657012303-6464-4-git-send-email-haibo.chen@nxp.com> References: <1657012303-6464-1-git-send-email-haibo.chen@nxp.com> <1657012303-6464-4-git-send-email-haibo.chen@nxp.com> User-Agent: Roundcube Webmail/1.4.13 Message-ID: <7a66e4fe8f7224ea272d68276c7b138b@walle.cc> X-Sender: michael@walle.cc X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220706_140214_976086_62E5D630 X-CRM114-Status: GOOD ( 21.71 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org Am 2022-07-05 11:11, schrieb haibo.chen@nxp.com: > From: Haibo Chen > > fspi define four mode for sample clock source selection. > > Here is the list of modes: > mode 0: Dummy Read strobe generated by FlexSPI Controller and loopback > internally > mode 1: Dummy Read strobe generated by FlexSPI Controller and loopback > from DQS pad > mode 2: Reserved > mode 3: Flash provided Read strobe and input from DQS pad > > In default, fspi use mode 0 after reset. > For 8-8-8-DTR mode, need to use mode 3, otherwise 8-8-8-DTR read always > get incorrect data. > > Signed-off-by: Haibo Chen > --- > drivers/spi/spi-nxp-fspi.c | 47 ++++++++++++++++++++++++++++++++++++++ > 1 file changed, 47 insertions(+) > > diff --git a/drivers/spi/spi-nxp-fspi.c b/drivers/spi/spi-nxp-fspi.c > index c32a4f53fa2a..34679dc0e1ad 100644 > --- a/drivers/spi/spi-nxp-fspi.c > +++ b/drivers/spi/spi-nxp-fspi.c > @@ -380,6 +380,7 @@ struct nxp_fspi { > struct pm_qos_request pm_qos_req; > int selected; > #define FSPI_INITILIZED (1 << 0) > +#define FSPI_RXCLKSRC_3 (1 << 1) > int flags; > }; > > @@ -877,6 +878,50 @@ static int nxp_fspi_do_op(struct nxp_fspi *f, > const struct spi_mem_op *op) > return err; > } > > +/* > + * Sample Clock source selection for Flash Reading > + * Four modes defined by fspi: > + * mode 0: Dummy Read strobe generated by FlexSPI Controller > + * and loopback internally > + * mode 1: Dummy Read strobe generated by FlexSPI Controller > + * and loopback from DQS pad > + * mode 2: Reserved > + * mode 3: Flash provided Read strobe and input from DQS pad > + * > + * fspi default use mode 0 after reset > + */ > +static void nxp_fspi_select_rx_sample_clk_source(struct nxp_fspi *f, > + const struct spi_mem_op *op) > +{ > + u32 reg; > + > + /* > + * For 8-8-8-DTR mode, need to use mode 3 (Flash provided Read > + * strobe and input from DQS pad), otherwise read operaton may > + * meet issue. > + * This mode require flash device connect the DQS pad on board. > + * For other modes, still use mode 0, keep align with before. > + * spi_nor_suspend will disable 8-8-8-DTR mode, also need to > + * change the mode back to mode 0. > + */ > + if (!(f->flags & FSPI_RXCLKSRC_3) && > + op->cmd.dtr && op->addr.dtr && > + op->dummy.dtr && op->data.dtr) { > + reg = fspi_readl(f, f->iobase + FSPI_MCR0); > + reg |= FSPI_MCR0_RXCLKSRC(3); > + fspi_writel(f, reg, f->iobase + FSPI_MCR0); > + f->flags |= FSPI_RXCLKSRC_3; > + } else if ((f->flags & FSPI_RXCLKSRC_3) && > + !op->cmd.dtr && !op->addr.dtr && > + !op->dummy.dtr && !op->data.dtr) { > + reg = fspi_readl(f, f->iobase + FSPI_MCR0); > + reg &= ~FSPI_MCR0_RXCLKSRC(3); /* select mode 0 */ > + fspi_writel(f, reg, f->iobase + FSPI_MCR0); > + f->flags &= ~FSPI_RXCLKSRC_3; > + } How is this supposed to work? Are you unconditionally enable flash provided read strobes if DTR is used? What if the flash doesn't provide one or the board haven't DQS connected? -michael ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/