From: Zhihao Cheng <chengzhihao1@huawei.com>
To: Yang Li <yang.lee@linux.alibaba.com>, <richard@nod.at>
Cc: <linux-mtd@lists.infradead.org>, <linux-kernel@vger.kernel.org>,
"Abaci Robot" <abaci@linux.alibaba.com>
Subject: Re: [PATCH -next] ubifs: Fix some kernel-doc comments
Date: Fri, 8 Jul 2022 19:14:37 +0800 [thread overview]
Message-ID: <7f4a0b5d-373f-0cb4-f1ea-5712d08a6bdb@huawei.com> (raw)
In-Reply-To: <2df4d326-c59a-52d2-c5aa-02954ddca97a@huawei.com>
在 2022/7/8 17:17, Zhihao Cheng 写道:
> 在 2022/6/2 13:52, Yang Li 写道:
>> Remove warnings found by running scripts/kernel-doc,
>> which is caused by using 'make W=1'.
>> fs/ubifs/journal.c:1221: warning: Function parameter or member
>> 'old_inode' not described in 'ubifs_jnl_rename'
>> fs/ubifs/journal.c:1221: warning: Function parameter or member 'old_nm'
>> not described in 'ubifs_jnl_rename'
>> fs/ubifs/journal.c:1221: warning: Function parameter or member
>> 'new_inode' not described in 'ubifs_jnl_rename'
>> fs/ubifs/journal.c:1221: warning: Function parameter or member 'new_nm'
>> not described in 'ubifs_jnl_rename'
>> fs/ubifs/journal.c:1221: warning: Function parameter or member
>> 'whiteout' not described in 'ubifs_jnl_rename'
>> fs/ubifs/journal.c:1221: warning: Excess function parameter 'old_dentry'
>> description in 'ubifs_jnl_rename'
>> fs/ubifs/journal.c:1221: warning: Excess function parameter 'new_dentry'
>> description in 'ubifs_jnl_rename'
>>
>> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
>> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
>> ---
>> fs/ubifs/journal.c | 7 +++++--
>> 1 file changed, 5 insertions(+), 2 deletions(-)
>>
>> diff --git a/fs/ubifs/journal.c b/fs/ubifs/journal.c
>> index 75dab0ae3939..16857d4e9aa8 100644
>> --- a/fs/ubifs/journal.c
>> +++ b/fs/ubifs/journal.c
>> @@ -1201,9 +1201,12 @@ int ubifs_jnl_xrename(struct ubifs_info *c,
>> const struct inode *fst_dir,
>> * ubifs_jnl_rename - rename a directory entry.
>> * @c: UBIFS file-system description object
>> * @old_dir: parent inode of directory entry to rename
>> - * @old_dentry: directory entry to rename
>> + * @old_inode: parent inode to rename
>> + * @old_nm: name of old inode to rename
>> * @new_dir: parent inode of directory entry to rename
>> - * @new_dentry: new directory entry (or directory entry to replace)
>> + * @new_inode: new inode to rename
>> + * @new_nm: name of new inode to rename
>> + * @whiteout: whiteout inode
>> * @sync: non-zero if the write-buffer has to be synchronized
>> *
>> * This function implements the re-name operation which may involve
>> writing up
>>
> Reviewed-by: Zhihao Cheng <chengzhihao1@huawei.com>
Please ignore this review tag, sorry for this mistaken reply, the review
tag is for v2.
>
>
> ______________________________________________________
> Linux MTD discussion mailing list
> http://lists.infradead.org/mailman/listinfo/linux-mtd/
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2022-07-08 11:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-02 5:52 [PATCH -next] ubifs: Fix some kernel-doc comments Yang Li
2022-06-02 6:36 ` Zhihao Cheng
2022-07-08 9:17 ` Zhihao Cheng
2022-07-08 11:14 ` Zhihao Cheng [this message]
2023-07-12 7:12 Yang Li
2023-07-12 7:32 ` Zhihao Cheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7f4a0b5d-373f-0cb4-f1ea-5712d08a6bdb@huawei.com \
--to=chengzhihao1@huawei.com \
--cc=abaci@linux.alibaba.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=richard@nod.at \
--cc=yang.lee@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).