From: <Tudor.Ambarus@microchip.com>
To: <sergei.shtylyov@cogentembedded.com>
Cc: richard@nod.at, linux-mtd@lists.infradead.org, vigneshr@ti.com,
miquel.raynal@bootlin.com
Subject: Re: [PATCH v2 4/5] mtd: spi-nor: fix kernel-doc for spi_nor::info
Date: Mon, 20 Apr 2020 09:20:49 +0000 [thread overview]
Message-ID: <8251539.igJhlKP8h3@192.168.0.120> (raw)
In-Reply-To: <2f00fec3-8385-a7f6-6bae-9014fd46fb9b@cogentembedded.com>
Hi, Sergei,
On Friday, April 3, 2020 11:49:48 PM EEST Sergei Shtylyov wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the
> content is safe
>
> When adding the 'info' field to 'struct spi_nor', some acronyms were in
> lower case and some in upper case and the JEDEC acronym mistyped -- fix
> these issues.
>
> Fixes: 46dde01f6bab ("mtd: spi-nor: add spi_nor_init() function")
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>
> ---
> Changes in version 2:
> - rebased to the 'spi-nor/next' branch of the MTD repo.
>
> include/linux/mtd/spi-nor.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Index: linux/include/linux/mtd/spi-nor.h
> ===================================================================
> --- linux.orig/include/linux/mtd/spi-nor.h
> +++ linux/include/linux/mtd/spi-nor.h
> @@ -335,7 +335,7 @@ struct spi_nor_flash_parameter;
> * @bouncebuf: bounce buffer used when the buffer passed by the MTD
> * layer is not DMA-able
> * @bouncebuf_size: size of the bounce buffer
> - * @info: spi-nor part JDEC MFR id and other info
> + * @info: SPI-NOR part JEDEC MFR ID and other info
There is an inconsistency in this file when referring to SPI NOR. It's either
called SPI-NOR or "SPI NOR". While I don't have a preference whether to keep
the "-" or not, I think we should be consistent across the file and use just a
format. So would you care to fix all the comments in spi-nor.h?
> * @manufacturer: spi-nor manufacturer
^ here's another problem.
Also, I think I would fix all these typos in a single patch, the fixes are
trivial enough, without affecting functionality and I'm not sure it is worth
backporting them. But again I don't have a strong opinion, so if you want to
keep these in separate commits that's ok for me.
Cheers,
ta
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2020-04-20 9:21 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-03 20:39 [PATCH v2 0/5] Fix kernel-doc comments for 'struct spi_nor' Sergei Shtylyov
2020-04-03 20:41 ` [PATCH v2 1/5] mtd: spi-nor: fix kernel-doc " Sergei Shtylyov
2020-04-03 20:44 ` [PATCH v2 2/5] mtd: spi-nor: fix kernel-doc for spi_nor::mtd Sergei Shtylyov
2020-04-03 20:45 ` [PATCH v2 3/5] mtd: spi-nor: fix kernel-doc for spi_nor::reg_proto Sergei Shtylyov
2020-04-03 20:49 ` [PATCH v2 4/5] mtd: spi-nor: fix kernel-doc for spi_nor::info Sergei Shtylyov
2020-04-20 9:20 ` Tudor.Ambarus [this message]
2020-04-21 3:50 ` Tudor.Ambarus
2020-04-28 8:47 ` [PATCH trivial] mtd: spi-nor: Fix SPI NOR acronym Tudor.Ambarus
2020-04-28 8:56 ` Tudor.Ambarus
2020-05-01 19:53 ` Sergei Shtylyov
2020-05-28 8:11 ` Tudor.Ambarus
2020-04-03 20:50 ` [PATCH v2 5/5] mtd: spi-nor: fix kernel-doc for spi_nor::spimem Sergei Shtylyov
2020-04-28 8:35 ` [PATCH v2 0/5] Fix kernel-doc comments for 'struct spi_nor' Tudor.Ambarus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8251539.igJhlKP8h3@192.168.0.120 \
--to=tudor.ambarus@microchip.com \
--cc=linux-mtd@lists.infradead.org \
--cc=miquel.raynal@bootlin.com \
--cc=richard@nod.at \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).