* [PATCH][next] mtd: rawnand: meson:: make several functions static
@ 2019-01-29 12:44 Colin King
2019-01-30 5:20 ` Liang Yang
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Colin King @ 2019-01-29 12:44 UTC (permalink / raw)
To: Liang Yang, Boris Brezillon, Miquel Raynal, Richard Weinberger,
David Woodhouse, Brian Norris, Marek Vasut, Kevin Hilman,
linux-mtd, linux-arm-kernel, linux-amlogic
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
There are several functions that are local to the source and do
not need to be in global scope, so make them static.
Cleans up sparse warnings.
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/mtd/nand/raw/meson_nand.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/mtd/nand/raw/meson_nand.c b/drivers/mtd/nand/raw/meson_nand.c
index b9c543d1054c..9557bd94dcd2 100644
--- a/drivers/mtd/nand/raw/meson_nand.c
+++ b/drivers/mtd/nand/raw/meson_nand.c
@@ -829,14 +829,14 @@ static int meson_nfc_read_oob(struct nand_chip *nand, int page)
return meson_nfc_read_page_hwecc(nand, NULL, 1, page);
}
-bool meson_nfc_is_buffer_dma_safe(const void *buffer)
+static bool meson_nfc_is_buffer_dma_safe(const void *buffer)
{
if (virt_addr_valid(buffer) && (!object_is_on_stack(buffer)))
return true;
return false;
}
-void *
+static void *
meson_nand_op_get_dma_safe_input_buf(const struct nand_op_instr *instr)
{
if (WARN_ON(instr->type != NAND_OP_DATA_IN_INSTR))
@@ -848,7 +848,7 @@ meson_nand_op_get_dma_safe_input_buf(const struct nand_op_instr *instr)
return kzalloc(instr->ctx.data.len, GFP_KERNEL);
}
-void
+static void
meson_nand_op_put_dma_safe_input_buf(const struct nand_op_instr *instr,
void *buf)
{
@@ -863,7 +863,7 @@ meson_nand_op_put_dma_safe_input_buf(const struct nand_op_instr *instr,
kfree(buf);
}
-void *
+static void *
meson_nand_op_get_dma_safe_output_buf(const struct nand_op_instr *instr)
{
if (WARN_ON(instr->type != NAND_OP_DATA_OUT_INSTR))
@@ -876,7 +876,7 @@ meson_nand_op_get_dma_safe_output_buf(const struct nand_op_instr *instr)
instr->ctx.data.len, GFP_KERNEL);
}
-void
+static void
meson_nand_op_put_dma_safe_output_buf(const struct nand_op_instr *instr,
const void *buf)
{
--
2.19.1
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH][next] mtd: rawnand: meson:: make several functions static
2019-01-29 12:44 [PATCH][next] mtd: rawnand: meson:: make several functions static Colin King
@ 2019-01-30 5:20 ` Liang Yang
2019-01-30 9:27 ` Liang Yang
2019-02-05 19:05 ` Miquel Raynal
2 siblings, 0 replies; 4+ messages in thread
From: Liang Yang @ 2019-01-30 5:20 UTC (permalink / raw)
To: Colin King, Boris Brezillon, Miquel Raynal, Richard Weinberger,
David Woodhouse, Brian Norris, Marek Vasut, Kevin Hilman,
linux-mtd, linux-arm-kernel, linux-amlogic
Cc: kernel-janitors, linux-kernel
Hello Colin,
On 2019/1/29 20:44, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> There are several functions that are local to the source and do
> not need to be in global scope, so make them static.
>
> Cleans up sparse warnings.
>
ok. thanks
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/mtd/nand/raw/meson_nand.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/mtd/nand/raw/meson_nand.c b/drivers/mtd/nand/raw/meson_nand.c
> index b9c543d1054c..9557bd94dcd2 100644
> --- a/drivers/mtd/nand/raw/meson_nand.c
> +++ b/drivers/mtd/nand/raw/meson_nand.c
> @@ -829,14 +829,14 @@ static int meson_nfc_read_oob(struct nand_chip *nand, int page)
> return meson_nfc_read_page_hwecc(nand, NULL, 1, page);
> }
>
> -bool meson_nfc_is_buffer_dma_safe(const void *buffer)
> +static bool meson_nfc_is_buffer_dma_safe(const void *buffer)
> {
> if (virt_addr_valid(buffer) && (!object_is_on_stack(buffer)))
> return true;
> return false;
> }
>
> -void *
> +static void *
> meson_nand_op_get_dma_safe_input_buf(const struct nand_op_instr *instr)
> {
> if (WARN_ON(instr->type != NAND_OP_DATA_IN_INSTR))
> @@ -848,7 +848,7 @@ meson_nand_op_get_dma_safe_input_buf(const struct nand_op_instr *instr)
> return kzalloc(instr->ctx.data.len, GFP_KERNEL);
> }
>
> -void
> +static void
> meson_nand_op_put_dma_safe_input_buf(const struct nand_op_instr *instr,
> void *buf)
> {
> @@ -863,7 +863,7 @@ meson_nand_op_put_dma_safe_input_buf(const struct nand_op_instr *instr,
> kfree(buf);
> }
>
> -void *
> +static void *
> meson_nand_op_get_dma_safe_output_buf(const struct nand_op_instr *instr)
> {
> if (WARN_ON(instr->type != NAND_OP_DATA_OUT_INSTR))
> @@ -876,7 +876,7 @@ meson_nand_op_get_dma_safe_output_buf(const struct nand_op_instr *instr)
> instr->ctx.data.len, GFP_KERNEL);
> }
>
> -void
> +static void
> meson_nand_op_put_dma_safe_output_buf(const struct nand_op_instr *instr,
> const void *buf)
> {
>
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH][next] mtd: rawnand: meson:: make several functions static
2019-01-29 12:44 [PATCH][next] mtd: rawnand: meson:: make several functions static Colin King
2019-01-30 5:20 ` Liang Yang
@ 2019-01-30 9:27 ` Liang Yang
2019-02-05 19:05 ` Miquel Raynal
2 siblings, 0 replies; 4+ messages in thread
From: Liang Yang @ 2019-01-30 9:27 UTC (permalink / raw)
To: Colin King, Boris Brezillon, Miquel Raynal, Richard Weinberger,
David Woodhouse, Brian Norris, Marek Vasut, Kevin Hilman,
linux-mtd, linux-arm-kernel, linux-amlogic
Cc: kernel-janitors, linux-kernel
Hi Colin,
On 2019/1/29 20:44, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> There are several functions that are local to the source and do
> not need to be in global scope, so make them static.
>
> Cleans up sparse warnings.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/mtd/nand/raw/meson_nand.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/mtd/nand/raw/meson_nand.c b/drivers/mtd/nand/raw/meson_nand.c
> index b9c543d1054c..9557bd94dcd2 100644
> --- a/drivers/mtd/nand/raw/meson_nand.c
> +++ b/drivers/mtd/nand/raw/meson_nand.c
> @@ -829,14 +829,14 @@ static int meson_nfc_read_oob(struct nand_chip *nand, int page)
> return meson_nfc_read_page_hwecc(nand, NULL, 1, page);
> }
>
> -bool meson_nfc_is_buffer_dma_safe(const void *buffer)
> +static bool meson_nfc_is_buffer_dma_safe(const void *buffer)
> {
> if (virt_addr_valid(buffer) && (!object_is_on_stack(buffer)))
> return true;
> return false;
> }
>
> -void *
> +static void *
> meson_nand_op_get_dma_safe_input_buf(const struct nand_op_instr *instr)
> {
> if (WARN_ON(instr->type != NAND_OP_DATA_IN_INSTR))
> @@ -848,7 +848,7 @@ meson_nand_op_get_dma_safe_input_buf(const struct nand_op_instr *instr)
> return kzalloc(instr->ctx.data.len, GFP_KERNEL);
> }
>
> -void
> +static void
> meson_nand_op_put_dma_safe_input_buf(const struct nand_op_instr *instr,
> void *buf)
> {
> @@ -863,7 +863,7 @@ meson_nand_op_put_dma_safe_input_buf(const struct nand_op_instr *instr,
> kfree(buf);
> }
>
> -void *
> +static void *
> meson_nand_op_get_dma_safe_output_buf(const struct nand_op_instr *instr)
> {
> if (WARN_ON(instr->type != NAND_OP_DATA_OUT_INSTR))
> @@ -876,7 +876,7 @@ meson_nand_op_get_dma_safe_output_buf(const struct nand_op_instr *instr)
> instr->ctx.data.len, GFP_KERNEL);
> }
>
> -void
> +static void
> meson_nand_op_put_dma_safe_output_buf(const struct nand_op_instr *instr,
> const void *buf)
> {
>
Looks good to me:
Acked-by: Liang Yang <liang.yang@amlogic.com>
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH][next] mtd: rawnand: meson:: make several functions static
2019-01-29 12:44 [PATCH][next] mtd: rawnand: meson:: make several functions static Colin King
2019-01-30 5:20 ` Liang Yang
2019-01-30 9:27 ` Liang Yang
@ 2019-02-05 19:05 ` Miquel Raynal
2 siblings, 0 replies; 4+ messages in thread
From: Miquel Raynal @ 2019-02-05 19:05 UTC (permalink / raw)
To: Colin King
Cc: Boris Brezillon, Richard Weinberger, kernel-janitors,
linux-kernel, Marek Vasut, Liang Yang, linux-mtd, Kevin Hilman,
linux-amlogic, Brian Norris, David Woodhouse, linux-arm-kernel
Hi Colin,
Colin King <colin.king@canonical.com> wrote on Tue, 29 Jan 2019
12:44:29 +0000:
> From: Colin Ian King <colin.king@canonical.com>
>
> There are several functions that are local to the source and do
> not need to be in global scope, so make them static.
>
> Cleans up sparse warnings.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Merged in nand/next with the original commit.
Thanks,
Miquèl
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-02-05 19:05 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-29 12:44 [PATCH][next] mtd: rawnand: meson:: make several functions static Colin King
2019-01-30 5:20 ` Liang Yang
2019-01-30 9:27 ` Liang Yang
2019-02-05 19:05 ` Miquel Raynal
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).