Linux-mtd Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] spi-nor : Remove SPI_NOR_HAS_TB flag on s25fl512s
       [not found] <CGME20190801092216epcas1p18622c765605e4b616d6eaf9fa55d2f3a@epcas1p1.samsung.com>
@ 2019-07-13 13:56 ` Jungseung Lee
  2019-08-20 15:19   ` Tudor.Ambarus
  0 siblings, 1 reply; 2+ messages in thread
From: Jungseung Lee @ 2019-07-13 13:56 UTC (permalink / raw)
  To: Marek Vasut, Tudor Ambarus, David Woodhouse, Brian Norris,
	Boris Brezillon, Richard Weinberger, u.kleine-koenig, linux-mtd,
	js07.lee, js07.lee

Currently, the Top/Bottom protection function (SPI_NOR_HAS_TB) is
implemented to fit some flashes with TB bit on SR.

s25fl512s has TBPROT bit on CR1, so the TB protection is not working on it.
Fix the wrong flag on s25fl512s.

Signed-off-by: Jungseung Lee <js07.lee@samsung.com>
---
 drivers/mtd/spi-nor/spi-nor.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c
index 03cc788511d5..c4f58944b482 100644
--- a/drivers/mtd/spi-nor/spi-nor.c
+++ b/drivers/mtd/spi-nor/spi-nor.c
@@ -2022,7 +2022,7 @@ static const struct flash_info spi_nor_ids[] = {
 	{ "s25fl256s1", INFO(0x010219, 0x4d01,  64 * 1024, 512, SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | USE_CLSR) },
 	{ "s25fl512s",  INFO6(0x010220, 0x4d0080, 256 * 1024, 256,
 			SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
-			SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB | USE_CLSR) },
+			SPI_NOR_HAS_LOCK | USE_CLSR) },
 	{ "s25fs512s",  INFO6(0x010220, 0x4d0081, 256 * 1024, 256, SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | USE_CLSR) },
 	{ "s70fl01gs",  INFO(0x010221, 0x4d00, 256 * 1024, 256, 0) },
 	{ "s25sl12800", INFO(0x012018, 0x0300, 256 * 1024,  64, 0) },
-- 
2.17.1


______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] spi-nor : Remove SPI_NOR_HAS_TB flag on s25fl512s
  2019-07-13 13:56 ` [PATCH] spi-nor : Remove SPI_NOR_HAS_TB flag on s25fl512s Jungseung Lee
@ 2019-08-20 15:19   ` Tudor.Ambarus
  0 siblings, 0 replies; 2+ messages in thread
From: Tudor.Ambarus @ 2019-08-20 15:19 UTC (permalink / raw)
  To: js07.lee, marek.vasut, dwmw2, computersforpeace, bbrezillon,
	richard, u.kleine-koenig, linux-mtd, js07.lee



On 07/13/2019 04:56 PM, Jungseung Lee wrote:
> External E-Mail
> 
> 
> Currently, the Top/Bottom protection function (SPI_NOR_HAS_TB) is
> implemented to fit some flashes with TB bit on SR.
> 
> s25fl512s has TBPROT bit on CR1, so the TB protection is not working on it.
> Fix the wrong flag on s25fl512s.
> 
> Signed-off-by: Jungseung Lee <js07.lee@samsung.com>
> ---

spi-nor patches should be prefixed with "mtd: spi-nor:", so I corrected that and

Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git,
spi-nor/next branch.

Thanks,
ta
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <CGME20190801092216epcas1p18622c765605e4b616d6eaf9fa55d2f3a@epcas1p1.samsung.com>
2019-07-13 13:56 ` [PATCH] spi-nor : Remove SPI_NOR_HAS_TB flag on s25fl512s Jungseung Lee
2019-08-20 15:19   ` Tudor.Ambarus

Linux-mtd Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-mtd/0 linux-mtd/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-mtd linux-mtd/ https://lore.kernel.org/linux-mtd \
		linux-mtd@lists.infradead.org
	public-inbox-index linux-mtd

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.infradead.lists.linux-mtd


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git