From: John Garry <john.garry@huawei.com>
To: Vignesh Raghavendra <vigneshr@ti.com>,
Alexander A Sverdlin <alexander.sverdlin@nokia.com>,
"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>
Cc: Tudor Ambarus <tudor.ambarus@microchip.com>,
Richard Weinberger <richard@nod.at>,
"chenxiang \(M\)" <chenxiang66@hisilicon.com>,
Boris Brezillon <bbrezillon@kernel.org>,
"stable@vger.kernel.org" <stable@vger.kernel.org>,
Marek Vasut <marek.vasut@gmail.com>,
Brian Norris <computersforpeace@gmail.com>,
David Woodhouse <dwmw2@infradead.org>
Subject: Re: [PATCH v2] mtd: spi-nor: Fixup page size for S25FS-S
Date: Tue, 18 Feb 2020 18:01:51 +0000 [thread overview]
Message-ID: <9042100b-eb7a-8285-6127-25d5b0073e94@huawei.com> (raw)
In-Reply-To: <0b5af315-5e1b-31ef-6cb9-eefefc86b425@ti.com>
On 18/02/2020 04:53, Vignesh Raghavendra wrote:
>> I don't mean to hijack this thread, but I have tried to enable QUAD mode
>> for part s25fl129p1, and it fails in spi_nor_write_16bit_cr_and_check():
>>
>> [ 47.263365] spi-nor spi-PRP0001:00: CR: read back test failed
>> [ 47.306567] spi-nor spi-PRP0001:00: quad mode not supported
>> [ 47.322413] spi-nor: probe of spi-PRP0001:00 failed with error -5
>>
>> Hacking the flags to set SNOR_F_NO_READ_CR, and at least I can
>> successfully probe the driver.
>>
>> Does anyone know if this part does not support reading the config
>> register. The limited datasheet here doesn't mention it, AFAICT:
>>
Hi Vignesh,
>> https://www.cypress.com/file/196851/download
> Above datasheet is for s25fl128p.
>
Right, I figured this out soon enough. I shouldn't just click on the
first page which google produces...
> Per, s25fl129p datasheet[1], part does support 0x35 (SPINOR_OP_RDCR)
> command and support 16bit write status register command (0x1)
>
> Could you debug further and see what exactly fails to match when
> read back fails?
I was trying to figure out the issue. So in
spi_nor_write_16bit_cr_and_check(), the sr check passes (it holds 0, so
that may be somewhat inconclusive) but the value for comparison return 0
in the CR also versus expected 3.
Maybe it is a host driver issue, but I am doubtful.
I can continue to investigate. Any ideas would be appreciated.
>
> [1]https://www.cypress.com/file/197121/download
>
>
Thanks,
John
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
prev parent reply other threads:[~2020-02-18 18:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-05 16:57 [PATCH v2] mtd: spi-nor: Fixup page size for S25FS-S Alexander A Sverdlin
2020-02-06 11:38 ` John Garry
2020-02-07 5:03 ` Vignesh Raghavendra
2020-02-12 18:00 ` John Garry
2020-02-18 4:53 ` Vignesh Raghavendra
2020-02-18 18:01 ` John Garry [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9042100b-eb7a-8285-6127-25d5b0073e94@huawei.com \
--to=john.garry@huawei.com \
--cc=alexander.sverdlin@nokia.com \
--cc=bbrezillon@kernel.org \
--cc=chenxiang66@hisilicon.com \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=marek.vasut@gmail.com \
--cc=richard@nod.at \
--cc=stable@vger.kernel.org \
--cc=tudor.ambarus@microchip.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).