From: Liang Yang <liang.yang@amlogic.com>
To: Neil Armstrong <narmstrong@baylibre.com>,
Miquel Raynal <miquel.raynal@bootlin.com>,
<linux-mtd@lists.infradead.org>
Cc: Rob Herring <robh+dt@kernel.org>,
Richard Weinberger <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>,
Jerome Brunet <jbrunet@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
Kevin Hilman <khilman@baylibre.com>,
Jianxin Pan <jianxin.pan@amlogic.com>,
Victor Wan <victor.wan@amlogic.com>,
XianWei Zhao <xianwei.zhao@amlogic.com>,
Kelvin Zhang <kelvin.zhang@amlogic.com>,
BiChao Zheng <bichao.zheng@amlogic.com>,
YongHui Yu <yonghui.yu@amlogic.com>,
<linux-arm-kernel@lists.infradead.org>,
<linux-amlogic@lists.infradead.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH RESEND v8 4/5] dt-bindings: nand: meson: convert txt to yaml
Date: Mon, 5 Sep 2022 15:37:05 +0800 [thread overview]
Message-ID: <9119f4d6-f9d4-e5e0-3536-95d5a6405cbe@amlogic.com> (raw)
In-Reply-To: <0ad6a792-74c2-9957-ee56-f183dcd75c58@baylibre.com>
Hi Neil,
Thanks for your remind.
I will add the ML in next resend version quickly.
On 2022/9/5 15:22, Neil Armstrong wrote:
> [ EXTERNAL EMAIL ]
>
> +CC [devicetree@vger.kernel.org]
>
> Please Add this ML to CC if you resend, it's the last patch of the serie
> that haven't got a proper review.
>
> On 22/08/2022 11:18, Liang Yang wrote:
>> convert the amlogic,meson-name.txt to amlogic,meson-nand.yaml
>>
>> Signed-off-by: Liang Yang <liang.yang@amlogic.com>
>> ---
>> .../bindings/mtd/amlogic,meson-nand.txt | 55 ------------
>> .../bindings/mtd/amlogic,meson-nand.yaml | 88 +++++++++++++++++++
>> 2 files changed, 88 insertions(+), 55 deletions(-)
>> delete mode 100644
>> Documentation/devicetree/bindings/mtd/amlogic,meson-nand.txt
>> create mode 100644
>> Documentation/devicetree/bindings/mtd/amlogic,meson-nand.yaml
>>
>> diff --git
>> a/Documentation/devicetree/bindings/mtd/amlogic,meson-nand.txt
>> b/Documentation/devicetree/bindings/mtd/amlogic,meson-nand.txt
>> deleted file mode 100644
>> index 5d5cdfef417f..000000000000
>> --- a/Documentation/devicetree/bindings/mtd/amlogic,meson-nand.txt
>> +++ /dev/null
>> @@ -1,55 +0,0 @@
>> -Amlogic NAND Flash Controller (NFC) for GXBB/GXL/AXG family SoCs
>> -
>> -This file documents the properties in addition to those available in
>> -the MTD NAND bindings.
>> -
>> -Required properties:
>> -- compatible : contains one of:
>> - - "amlogic,meson-gxl-nfc"
>> - - "amlogic,meson-axg-nfc"
>> -
>> -- reg : Offset and length of the register set
>> -
>> -- reg-names : "nfc" is the register set for NFC controller and "emmc"
>> - is the register set for MCI controller.
>> -
>> -- clocks :
>> - A list of phandle + clock-specifier pairs for the clocks listed
>> - in clock-names.
>> -
>> -- clock-names: Should contain the following:
>> - "core" - NFC module gate clock
>> - "device" - parent clock for internal NFC
>> -
>> -Optional children nodes:
>> -Children nodes represent the available nand chips.
>> -
>> -Other properties:
>> -see Documentation/devicetree/bindings/mtd/nand-controller.yaml for
>> generic bindings.
>> -
>> -Example demonstrate on AXG SoC:
>> -
>> - nand-controller@7800 {
>> - compatible = "amlogic,meson-axg-nfc";
>> - reg = <0x0 0x7800 0x0 0x100>,
>> - <0x0 0x7000 0x0 0x800>;
>> - reg-names = "nfc", "emmc";
>> - #address-cells = <1>;
>> - #size-cells = <0>;
>> - interrupts = <GIC_SPI 34 IRQ_TYPE_EDGE_RISING>;
>> -
>> - clocks = <&clkc CLKID_SD_EMMC_C>,
>> - <&clkc CLKID_FCLK_DIV2>;
>> - clock-names = "core", "device";
>> -
>> - pinctrl-names = "default";
>> - pinctrl-0 = <&nand_pins>;
>> -
>> - nand@0 {
>> - reg = <0>;
>> - #address-cells = <1>;
>> - #size-cells = <1>;
>> -
>> - nand-on-flash-bbt;
>> - };
>> - };
>> diff --git
>> a/Documentation/devicetree/bindings/mtd/amlogic,meson-nand.yaml
>> b/Documentation/devicetree/bindings/mtd/amlogic,meson-nand.yaml
>> new file mode 100644
>> index 000000000000..42634e9c0d3c
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/mtd/amlogic,meson-nand.yaml
>> @@ -0,0 +1,88 @@
>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/mtd/amlogic,meson-nand.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Amlogic NAND Flash Controller (NFC) for GXBB/GXL/AXG family SoCs
>> +
>> +allOf:
>> + - $ref: "nand-controller.yaml"
>> +
>> +maintainers:
>> + - liang.yang@amlogic.com
>> +
>> +properties:
>> + compatible:
>> + enum:
>> + - "amlogic,meson-gxl-nfc"
>> + - "amlogic,meson-axg-nfc"
>> +
>> + reg:
>> + maxItems: 2
>> +
>> + interrupts:
>> + maxItems: 1
>> +
>> + clocks:
>> + minItems: 2
>> +
>> + clock-names:
>> + items:
>> + - const: core
>> + - const: device
>> +
>> +patternProperties:
>> + "^nand@[0-7]$":
>> + type: object
>> + properties:
>> + reg:
>> + minimum: 0
>> + maximum: 1
>> +
>> + nand-ecc-mode:
>> + const: hw
>> +
>> + nand-ecc-step-size:
>> + const: 1024
>> +
>> + nand-ecc-strength:
>> + enum: [8, 16, 24, 30, 40, 50, 60]
>> + description: |
>> + The ECC configurations that can be supported are as follows.
>> + meson-gxl-nfc 8, 16, 24, 30, 40, 50, 60
>> + meson-axg-nfc 8
>> +
>> +required:
>> + - compatible
>> + - reg
>> + - interrupts
>> + - clocks
>> + - clock-names
>> +
>> +unevaluatedProperties: false
>> +
>> +examples:
>> + - |
>> + #include <dt-bindings/clock/axg-clkc.h>
>> + #include <dt-bindings/interrupt-controller/arm-gic.h>
>> + nand-controller@ffe07800 {
>> + compatible = "amlogic,meson-axg-nfc";
>> + reg = <0xffe07800 0x100>, <0xffe07000 0x800>;
>> + reg-names = "nfc", "emmc";
>> + interrupts = <GIC_SPI 34 IRQ_TYPE_EDGE_RISING>;
>> + clocks = <&clkc CLKID_SD_EMMC_C>, <&clkc CLKID_FCLK_DIV2>;
>> + clock-names = "core", "device";
>> +
>> + pinctrl-0 = <&nand_pins>;
>> + pinctrl-names = "default";
>> +
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> +
>> + nand@0 {
>> + reg = <0>;
>> + };
>> + };
>> +
>> +...
>
> Thanks,
> Neil
>
> .
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2022-09-05 9:24 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-22 9:18 [PATCH RESEND v8 0/5] fix the meson NFC clock Liang Yang
2022-08-22 9:18 ` [PATCH RESEND v8 1/5] dt-bindings: nand: meson: fix meson nfc clock Liang Yang
2022-08-22 9:18 ` [PATCH RESEND v8 2/5] mtd: rawnand: meson: fix the clock Liang Yang
2022-08-22 9:18 ` [PATCH RESEND v8 3/5] mtd: rawnand: meson: refine resource getting in probe Liang Yang
2022-08-22 9:18 ` [PATCH RESEND v8 4/5] dt-bindings: nand: meson: convert txt to yaml Liang Yang
2022-09-05 7:22 ` Neil Armstrong
2022-09-05 7:37 ` Liang Yang [this message]
2022-08-22 9:18 ` [PATCH RESEND v8 5/5] mtd: rawnand: meson: not support legacy clock Liang Yang
2022-09-05 7:50 [PATCH RESEND v8 0/5] fix the meson NFC clock Liang Yang
2022-09-05 7:50 ` [PATCH RESEND v8 4/5] dt-bindings: nand: meson: convert txt to yaml Liang Yang
2022-09-06 6:00 [PATCH RESEND v8 0/5] fix the meson NFC clock Liang Yang
2022-09-06 6:00 ` [PATCH RESEND v8 4/5] dt-bindings: nand: meson: convert txt to yaml Liang Yang
2022-09-06 13:40 ` Rob Herring
2022-09-07 7:43 ` Liang Yang
2022-09-06 14:30 ` Rob Herring
2022-09-07 7:45 ` Liang Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9119f4d6-f9d4-e5e0-3536-95d5a6405cbe@amlogic.com \
--to=liang.yang@amlogic.com \
--cc=bichao.zheng@amlogic.com \
--cc=jbrunet@baylibre.com \
--cc=jianxin.pan@amlogic.com \
--cc=kelvin.zhang@amlogic.com \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=miquel.raynal@bootlin.com \
--cc=narmstrong@baylibre.com \
--cc=richard@nod.at \
--cc=robh+dt@kernel.org \
--cc=victor.wan@amlogic.com \
--cc=vigneshr@ti.com \
--cc=xianwei.zhao@amlogic.com \
--cc=yonghui.yu@amlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).