From: <Tudor.Ambarus@microchip.com>
To: <robimarko@gmail.com>, <marek.vasut@gmail.com>,
<dwmw2@infradead.org>, <computersforpeace@gmail.com>,
<bbrezillon@kernel.org>, <richard@nod.at>,
<linux-mtd@lists.infradead.org>, <linux-kernel@vger.kernel.org>,
<bbrezillon@kernel.org>
Subject: Re: [PATCH] mtd: spi-nor: Add Winbond w25q16jv support
Date: Wed, 20 Feb 2019 20:29:07 +0000 [thread overview]
Message-ID: <97e48e85-9700-53e3-0f7a-eeac6f93f721@microchip.com> (raw)
In-Reply-To: <20190214205723.9011-1-robimarko@gmail.com>
Hi, Robert,
On 02/14/2019 10:57 PM, Robert Marko wrote:
> Datasheet: https://www.winbond.com/resource-files/w25q16jv%20spi%20revg%2003222018%20plus.pdf
>
> Testing done on Mikrotik Routerboard RB450Gx4 board under 4.19.19 kernel.
It is preferable to do the test on spi-nor/next
>
> Test board does not support Dual or Quad modes.
>
> Signed-off-by: Robert Marko <robimarko@gmail.com>
> ---
> drivers/mtd/spi-nor/spi-nor.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c
> index 6e13bbd1aaa5..0e958f48db1b 100644
> --- a/drivers/mtd/spi-nor/spi-nor.c
> +++ b/drivers/mtd/spi-nor/spi-nor.c
> @@ -1975,6 +1975,11 @@ static const struct flash_info spi_nor_ids[] = {
> SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
> SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB)
> },
> + {
> + "w25q16jv", INFO(0xef7015, 0, 64 * 1024, 32,
> + SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
> + SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB)
You'll need a way to differentiate between W25Q16JV-IQ/JQ and W25Q16JV-IM/JM.
And I would prefer to have the new entries ordered alphabetically as much as
possible. This one should fit just before w25q20cl. Manufacturers are naming
flashes based on a product identification system. The flashes are presented in
alphabetical order, we should do the same.
Cheers,
ta
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2019-02-20 20:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-14 20:57 [PATCH] mtd: spi-nor: Add Winbond w25q16jv support Robert Marko
2019-02-20 20:29 ` Tudor.Ambarus [this message]
2019-02-21 20:58 ` Robert Marko
2019-06-13 14:33 ` Tudor.Ambarus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=97e48e85-9700-53e3-0f7a-eeac6f93f721@microchip.com \
--to=tudor.ambarus@microchip.com \
--cc=bbrezillon@kernel.org \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=marek.vasut@gmail.com \
--cc=richard@nod.at \
--cc=robimarko@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).