From: <Tudor.Ambarus@microchip.com>
To: <jiaqing.zhao@linux.intel.com>, <linux-mtd@lists.infradead.org>,
<p.yadav@ti.com>, <michael@walle.cc>
Cc: <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] mtd: spi-nor: micron: Add SPI_NOR_DUAL_READ flag on mt25ql02g
Date: Thu, 21 Jul 2022 07:59:56 +0000 [thread overview]
Message-ID: <9fe7ad54-99d4-b972-1f4d-a5744efc5583@microchip.com> (raw)
In-Reply-To: <20220522054802.1719443-2-jiaqing.zhao@linux.intel.com>
On 5/22/22 08:48, Jiaqing Zhao wrote:
> [You don't often get email from jiaqing.zhao@linux.intel.com. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification.]
>
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> The Micron mt25ql02g supports x2 width dual mode operation. This patch
> adds the SPI_NOR_DUAL_READ flag to its flash_info entry.
can't the dual mode be retrieved from SFDP?
Can you dump the sysfs sfdp table please?
>
> Signed-off-by: Jiaqing Zhao <jiaqing.zhao@linux.intel.com>
> ---
> drivers/mtd/spi-nor/micron-st.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/spi-nor/micron-st.c b/drivers/mtd/spi-nor/micron-st.c
> index 8a20475ce77a..da0251c1a263 100644
> --- a/drivers/mtd/spi-nor/micron-st.c
> +++ b/drivers/mtd/spi-nor/micron-st.c
> @@ -233,7 +233,7 @@ static const struct flash_info st_nor_parts[] = {
> },
> { "mt25ql02g", INFO(0x20ba22, 0, 64 * 1024, 4096)
> FLAGS(NO_CHIP_ERASE)
> - NO_SFDP_FLAGS(SECT_4K | SPI_NOR_QUAD_READ)
> + NO_SFDP_FLAGS(SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ)
> MFR_FLAGS(USE_FSR)
> },
> { "mt25qu02g", INFO(0x20bb22, 0, 64 * 1024, 4096)
> --
> 2.34.1
>
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2022-07-21 8:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-22 5:48 [PATCH 1/2] mtd: spi-nor: macronix: Add support for mx66l2g45g Jiaqing Zhao
2022-05-22 5:48 ` [PATCH 2/2] mtd: spi-nor: micron: Add SPI_NOR_DUAL_READ flag on mt25ql02g Jiaqing Zhao
2022-07-21 7:59 ` Tudor.Ambarus [this message]
2022-05-23 7:54 ` [PATCH 1/2] mtd: spi-nor: macronix: Add support for mx66l2g45g Michael Walle
2022-05-23 8:50 ` Jiaqing Zhao
2022-05-23 8:56 ` Michael Walle
2022-05-23 10:12 ` Jiaqing Zhao
2022-05-23 11:59 ` Michael Walle
2022-05-23 12:18 ` Jiaqing Zhao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9fe7ad54-99d4-b972-1f4d-a5744efc5583@microchip.com \
--to=tudor.ambarus@microchip.com \
--cc=jiaqing.zhao@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=michael@walle.cc \
--cc=p.yadav@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).