From: "Bean Huo (beanhuo)" <beanhuo@micron.com>
To: "Tudor.Ambarus@microchip.com" <Tudor.Ambarus@microchip.com>,
"marek.vasut@gmail.com" <marek.vasut@gmail.com>,
"dwmw2@infradead.org" <dwmw2@infradead.org>,
"computersforpeace@gmail.com" <computersforpeace@gmail.com>,
"bbrezillon@kernel.org" <bbrezillon@kernel.org>,
"richard@nod.at" <richard@nod.at>
Cc: "linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"bbrezillon@kernel.org" <bbrezillon@kernel.org>
Subject: RE: [EXT] Re: [PATCH] include: mtd: spi-nor: change HWCPAS to HWCAPS
Date: Fri, 8 Feb 2019 11:39:42 +0000 [thread overview]
Message-ID: <BYAPR08MB4533E2C1B5CBD0789F1A1F0EDB690@BYAPR08MB4533.namprd08.prod.outlook.com> (raw)
In-Reply-To: <f167ad30-2a15-e430-1a6e-d1e1ba455b67@microchip.com>
Hi, Tudor
>SNOR_HWCPAS_READ_OCTO was renamed to SNOR_HWCPAS_READ_OCTAL
>please update your remote and send a new patch.
>
Which branch do you mean? I checked linux-mtd, not renamed yet.
>The patch prefix is wrong, it should be prefixed with "mtd: spi-nor:". When in
>doubt, you can check how were prefixed previous patches on the same file by
>running something like:
>
>git log --oneline include/linux/mtd/spi-nor.h
>
>On 02/07/2019 03:46 PM, Bean Huo (beanhuo) wrote:
>>
>
>This looks like a blank line, it's not needed, remove it please.
>> Maybe this is wrong abbreviation, change from HWCPAS to HWCAPS.
>
>Indeed, it is, use imperative, something like: "Fix wrong abbreviation,
>s/HWCPAS/HWCAPS"
>>
>> Signed-off-by: Bean Huo <beanhuo@micron.com>
>
>Your S-o-b tag doesn't match the author name, please fix this as well.
It is automatically added by git, what is correct way?
Thanks,
//Bean
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2019-02-08 11:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-07 13:46 [PATCH] include: mtd: spi-nor: change HWCPAS to HWCAPS Bean Huo (beanhuo)
2019-02-08 10:26 ` Tudor.Ambarus
2019-02-08 11:39 ` Bean Huo (beanhuo) [this message]
2019-02-08 12:27 ` [EXT] " Tudor.Ambarus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BYAPR08MB4533E2C1B5CBD0789F1A1F0EDB690@BYAPR08MB4533.namprd08.prod.outlook.com \
--to=beanhuo@micron.com \
--cc=Tudor.Ambarus@microchip.com \
--cc=bbrezillon@kernel.org \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=marek.vasut@gmail.com \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).