Linux-mtd Archive on lore.kernel.org
 help / color / Atom feed
From: Han Xu <xhnjupt@gmail.com>
To: Miquel Raynal <miquel.raynal@bootlin.com>
Cc: linux-mtd <linux-mtd@lists.infradead.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>,
	Sascha Hauer <kernel@pengutronix.de>,
	Lucas Stach <l.stach@pengutronix.de>
Subject: Re: imx27: Unsupported ECC algorithm
Date: Thu, 15 Oct 2020 22:04:14 -0500
Message-ID: <CA+EcR200pOT8F=xS+Fh_gyJMF9ZGxFU6Y+RDRg6XyntyR2yGdA@mail.gmail.com> (raw)
In-Reply-To: <20201014152659.6ef6a2fc@xps13>

On Wed, Oct 14, 2020 at 8:32 AM Miquel Raynal <miquel.raynal@bootlin.com> wrote:
>
> Hi Fabio, Sascha, Lucas,
>
> Fabio Estevam <festevam@gmail.com> wrote on Wed, 14 Oct 2020 09:23:06
> -0300:
>
> > Hi Lucas,
> >
> > On Tue, Oct 13, 2020 at 2:14 PM Lucas Stach <l.stach@pengutronix.de> wrote:
> >
> > > Just a heads up: our lab was broken for some time due to a local issue.
> > > It's now back to working and the backlog of jobs is being executed on
> > > the boards right now, so results should show up in the near furture.
> >
> > Thanks. kernelci results are showing up again.
> >
> > Hi Miquel,
> >
> > The ECC issues are still present on imx27-phytec-phycard-s-rdk:
> > https://storage.kernelci.org/next/master/next-20201013/arm/imx_v4_v5_defconfig/gcc-8/lab-pengutronix/baseline-imx27-phytec-phycard-s-rdk.html
> >
> > BTW, ECC errors are also reported on a Freescale Layerscape 2088A RDB Board:
> > https://www.spinics.net/lists/iommu/msg49772.html
> >
>
> I supposed the failing division is this one:
>
>         /*
>          * Set the number of read / write steps for one page depending on ECC
>          * mode.
>          */
>         ecc->steps = mtd->writesize / ecc->size;
>         if (ecc->steps * ecc->size != mtd->writesize) {
>                 WARN(1, "Invalid ECC parameters\n");
>                 ret = -EINVAL;
>                 goto err_nand_manuf_cleanup;
>         }
>
> Which produces the warning right after. This would mean that
>
>         ecc->size == 0
>
> But this entry is set before calling nand_scan() in mxcnd_probe() to
> 512, and that does not make sense.
>
> I guess we should be able to reproduce this error with any board using
> the mxc NAND driver with hardware correction (now also called "on
> host"). Do you have such a board available to at least verify that the
> beginning of my logic is right?

Hi Miquel,

I debugged on one LS1043A platform and found in rawnand_dt_init(), the
chip->ecc.strength was set to nand->ecc.user_conf.strength, which may
not have been touched before. Same as chip->ecc.size.

>
> Thanks,
> Miquèl
>
> ______________________________________________________
> Linux MTD discussion mailing list
> http://lists.infradead.org/mailman/listinfo/linux-mtd/



-- 
Sincerely,

Han XU

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

  parent reply index

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-16 13:49 Fabio Estevam
2020-09-17 16:13 ` Miquel Raynal
2020-09-17 16:45   ` Miquel Raynal
2020-09-17 17:12     ` Fabio Estevam
2020-09-21  9:40 ` Sascha Hauer
2020-09-28 15:20   ` Miquel Raynal
2020-09-29 11:39     ` Fabio Estevam
2020-09-29 16:31       ` Fabio Estevam
2020-09-29 17:46         ` Miquel Raynal
2020-09-30 14:58         ` Miquel Raynal
2020-10-01 21:39           ` Fabio Estevam
2020-10-13 17:14             ` Lucas Stach
2020-10-13 17:36               ` Miquel Raynal
2020-10-14 12:23               ` Fabio Estevam
2020-10-14 13:26                 ` Miquel Raynal
2020-10-15 19:24                   ` Fabio Estevam
2020-10-16  3:04                   ` Han Xu [this message]
2020-10-16  6:39                   ` Sascha Hauer
2020-10-16  7:53                     ` Miquel Raynal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CA+EcR200pOT8F=xS+Fh_gyJMF9ZGxFU6Y+RDRg6XyntyR2yGdA@mail.gmail.com' \
    --to=xhnjupt@gmail.com \
    --cc=festevam@gmail.com \
    --cc=kernel@pengutronix.de \
    --cc=l.stach@pengutronix.de \
    --cc=linux-mtd@lists.infradead.org \
    --cc=miquel.raynal@bootlin.com \
    --cc=s.hauer@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-mtd Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-mtd/0 linux-mtd/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-mtd linux-mtd/ https://lore.kernel.org/linux-mtd \
		linux-mtd@lists.infradead.org
	public-inbox-index linux-mtd

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.infradead.lists.linux-mtd


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git