From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90304C433E0 for ; Tue, 7 Jul 2020 10:44:54 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5CEF22064C for ; Tue, 7 Jul 2020 10:44:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ib/cGPb1"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=google.com header.i=@google.com header.b="i+8zrHE/" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5CEF22064C Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=dH7Gu8z8MP7Vw7BYzgsu7cU7dvlX8LFPlJABw0GVHSs=; b=ib/cGPb1nmiaKEl27HG3AsN6I ZK9drw4Iq9FmKq2+U2vgh3MNB7B3jijFDCJtvsTXig/NkpXa++7oD3CwJj6MMJ9/WdgGz/r7ddhdR 4QkZFNXf04AQoXIuXG/bgp0xF/saY56lHy+IanPFH2ey6i1GyEGUqJMcI6BJsQgTLFRWXoKHitdkJ Hrf64MyLqF44WcM8Gfjnf3D4FkwFBqMlwElWPZ968OmxYHNMxbqMKJ6tZ29vpK5gNlZwUbB0jXHp2 e0rIgGOxH2mRF4WBG0SgWHUlfVxAlRqDlxC2V294PbL+TRMwWoCmYWnbayRyCp+VoFAaasKyoZ4rG EFDxserkA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jsl5K-00079P-B5; Tue, 07 Jul 2020 10:44:22 +0000 Received: from mail-oi1-x244.google.com ([2607:f8b0:4864:20::244]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jsl5I-00078W-ND for linux-mtd@lists.infradead.org; Tue, 07 Jul 2020 10:44:21 +0000 Received: by mail-oi1-x244.google.com with SMTP id k22so23167603oib.0 for ; Tue, 07 Jul 2020 03:44:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=7QgWKK4RTXLZo2mZ8LP12+iEtRAYWukejbIygBOzwIw=; b=i+8zrHE/fs2Y8R0mSJSYG3HjDe8DMVO33zE9s8G+U3bPlySiM1KMfVq7FQZXMQAhf1 1otQWa3z0Vo7rjF4WrjRMSTIn13HVhr/JHalXoGUunpOX7WHRLB3zlFjoS1E2nKKej2L wWpZzxVUx8xWAMhvXDyMkaCaV3SfS6vGC00xyBcxsE3DhCqezURHXrD0RavIKX0oj+sp /oPMgxrv/HUucbo5d4BmjphhcwAKuEq5xOk51hTZk2do4F4w3ppJDidPfTL+qFOXKgk2 BplIYO3/hCX+Qvdwhdxy7PAM/Rm0Np0kp7ad9ua2RSY+KL50IHQX2mnutETcFSLaBndV Gpvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=7QgWKK4RTXLZo2mZ8LP12+iEtRAYWukejbIygBOzwIw=; b=BXAL+uXwQKc4YP9rs81rDXxte3y4N2PLxvvKwriDh/nlz5DRdOAIus97C4ISSWapMI poa0Ucq1l5xMT2joQGM8scYgI3Opox/hTQJzPnm0xgclpb1h3jUjQryWUHtIHcvesVJU NJp9HLHNAtCCCsBZ+KLcc4N42K6E481iALYIogpR8Uow6vVmSoQ5pML4cfy+aWx1J81y SYe0WWf5Xogf+AZZ4vvWhXKXNvgeV0OP/16FXFDtnlYvk+AlEBh8+EK1CI4spohxn2eC PrqEN2/YqZaKjbjZEqQNZCqpNtmr6xIlFufF3rMqRUif43yROAe4UyIPoHkDIOu949oW BzVw== X-Gm-Message-State: AOAM530b+l7VSl9PRhdJqV4Lc4m3exjl/+2u8CF8CUVzH8qBKsofuG3R 8u0N28CpqtoADNMGUOOLJYW9XRvQRfyNC+7cQ1O3eA== X-Google-Smtp-Source: ABdhPJz+TeWph34DQmuzU5/HwXijA0+NDY97HXcO97SKerniK7b3Ulr3aDgUOA25daDJjAs5gvkPux2OD9AQjmHA6HA= X-Received: by 2002:a05:6808:a19:: with SMTP id n25mr2626139oij.84.1594118657366; Tue, 07 Jul 2020 03:44:17 -0700 (PDT) MIME-Version: 1.0 References: <20200624043341.33364-1-drosen@google.com> <20200624043341.33364-5-drosen@google.com> <877dvxggsl.fsf@collabora.com> In-Reply-To: <877dvxggsl.fsf@collabora.com> From: Daniel Rosenberg Date: Tue, 7 Jul 2020 03:44:06 -0700 Message-ID: Subject: Re: [PATCH v9 4/4] ext4: Use generic casefolding support To: Gabriel Krisman Bertazi X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200707_064420_765590_90D6967E X-CRM114-Status: GOOD ( 11.42 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Theodore Ts'o , Jonathan Corbet , Richard Weinberger , Andreas Dilger , Chao Yu , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, Eric Biggers , linux-fscrypt@vger.kernel.org, linux-mtd@lists.infradead.org, Alexander Viro , linux-fsdevel@vger.kernel.org, Jaegeuk Kim , linux-ext4@vger.kernel.org, kernel-team@android.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org On Tue, Jun 23, 2020 at 10:43 PM Gabriel Krisman Bertazi wrote: > > Daniel Rosenberg writes: > > > - > > const struct dentry_operations ext4_dentry_ops = { > > - .d_hash = ext4_d_hash, > > - .d_compare = ext4_d_compare, > > + .d_hash = generic_ci_d_hash, > > + .d_compare = generic_ci_d_compare, > > }; > > #endif > > Can you make the structure generic since it is the same for f2fs and > ext4, which let you drop the code guards? Unless that becomes a problem for > d_revalidate with fscrypt, it is fine like this. > > -- > Gabriel Krisman Bertazi I unify them in a later patch, since I end up having to deal with fscrypt's d_revalidate. With that patch I'd end up undoing the export I'd add for this, so I'll skip that for the moment. -Daniel ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/