* [PATCH] mtd-utils: flash_otp_dump make offset optional
@ 2022-08-18 9:35 Michael Walle
2022-08-19 12:32 ` Sergei Antonov
0 siblings, 1 reply; 3+ messages in thread
From: Michael Walle @ 2022-08-18 9:35 UTC (permalink / raw)
To: David Oberhollenzer; +Cc: linux-mtd, Sergei Antonov, Michael Walle
Commit 0a5e2fa5c1e4 ("mtd-utils: add optional offset parameter to
flash_otp_dump") introduced an offset parameter. This should have
been optional, but there was a typo. Fix it.
Reported-by: Sergei Antonov <saproj@gmail.com>
Fixes: 0a5e2fa5c1e4 ("mtd-utils: add optional offset parameter to flash_otp_dump")
Signed-off-by: Michael Walle <michael@walle.cc>
---
misc-utils/flash_otp_dump.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/misc-utils/flash_otp_dump.c b/misc-utils/flash_otp_dump.c
index f1e1782..324d856 100644
--- a/misc-utils/flash_otp_dump.c
+++ b/misc-utils/flash_otp_dump.c
@@ -20,7 +20,7 @@ int main(int argc,char *argv[])
int offset = 0;
unsigned char buf[16];
- if (argc <= 3 || (strcmp(argv[1], "-f") && strcmp(argv[1], "-u"))) {
+ if (argc < 3 || (strcmp(argv[1], "-f") && strcmp(argv[1], "-u"))) {
fprintf(stderr,"Usage: %s [ -f | -u ] <device> [<offset>]\n", PROGRAM_NAME);
return EINVAL;
}
--
2.30.2
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] mtd-utils: flash_otp_dump make offset optional
2022-08-18 9:35 [PATCH] mtd-utils: flash_otp_dump make offset optional Michael Walle
@ 2022-08-19 12:32 ` Sergei Antonov
2022-09-27 6:43 ` David Oberhollenzer
0 siblings, 1 reply; 3+ messages in thread
From: Sergei Antonov @ 2022-08-19 12:32 UTC (permalink / raw)
To: Michael Walle; +Cc: David Oberhollenzer, linux-mtd
On Thu, 18 Aug 2022 at 12:36, Michael Walle <michael@walle.cc> wrote:
>
> Commit 0a5e2fa5c1e4 ("mtd-utils: add optional offset parameter to
> flash_otp_dump") introduced an offset parameter. This should have
> been optional, but there was a typo. Fix it.
>
> Reported-by: Sergei Antonov <saproj@gmail.com>
> Fixes: 0a5e2fa5c1e4 ("mtd-utils: add optional offset parameter to flash_otp_dump")
> Signed-off-by: Michael Walle <michael@walle.cc>
Reviewed-by: Sergei Antonov <saproj@gmail.com>
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mtd-utils: flash_otp_dump make offset optional
2022-08-19 12:32 ` Sergei Antonov
@ 2022-09-27 6:43 ` David Oberhollenzer
0 siblings, 0 replies; 3+ messages in thread
From: David Oberhollenzer @ 2022-09-27 6:43 UTC (permalink / raw)
To: Sergei Antonov, Michael Walle; +Cc: linux-mtd
Applied to mtd-utils.git master.
Thanks,
David
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-09-27 6:44 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-18 9:35 [PATCH] mtd-utils: flash_otp_dump make offset optional Michael Walle
2022-08-19 12:32 ` Sergei Antonov
2022-09-27 6:43 ` David Oberhollenzer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).