From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA794C432C0 for ; Fri, 29 Nov 2019 00:00:09 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 960F021774 for ; Fri, 29 Nov 2019 00:00:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="S4GoKhzf"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=jms.id.au header.i=@jms.id.au header.b="SzvDGgqD" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 960F021774 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=jms.id.au Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=byNdYAlhHcehelstW9YFcKe7vJVNfkOJfz8oCe3eeoY=; b=S4GoKhzfCwObUF XBCy+YiZlP3vYbZcQ1beKClgfG8g5DRS+d/LPrYcjhDIcXq1G4NVw5E8wYcozXuyTiWG7ZuCwKVYT lBTBSUIMxt6kE6aQ7rTpMCUtAGwy6KgbJmOV4dgRM/SQ8LE1qf7AmiqoFDFjlIhB3Qms3OOLodN65 v7pfUUVAKXtPqiRtQ7xu3PlwJFXj4/c46G0XjZlT5M5j12qrzEkehGk0DCvH5s9VkxJikjxvLMklE j4nBOt4IH+iey0H7PAR2di5nQWGFdChwDqJ2lchyiBu+BMeGCHzwGrFUptXQQc7NyVOlmv/huj9E6 kM+fNVEZ2K0m5JQrG1dg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iaThP-00076V-VS; Thu, 28 Nov 2019 23:59:51 +0000 Received: from mail-qt1-x841.google.com ([2607:f8b0:4864:20::841]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iaThN-00076B-A1 for linux-mtd@lists.infradead.org; Thu, 28 Nov 2019 23:59:50 +0000 Received: by mail-qt1-x841.google.com with SMTP id z22so9833752qto.7 for ; Thu, 28 Nov 2019 15:59:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jms.id.au; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=hQwL4adBgXITc3PkYkwHn1sVmJQxAI5c44/ZAMQ909k=; b=SzvDGgqDbhXRLCNx2yAvCitr/MeJnBLqu0VZWKbEKIIM6e/tradTFioO2kNcvyLsDS N1GjfKiKATmESqzIG7MV0zf+Ge17s3lu8rITgQzXVgMQDvZ7/L80K/eSJeNsAmbp7g6C Rp5dEWUc98LpgXd+0f6qCXoBTHbIhl2BKWCIo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=hQwL4adBgXITc3PkYkwHn1sVmJQxAI5c44/ZAMQ909k=; b=LHQbiNufkPJjWnGS9TVjOAI1J5/KjSDNNV6H8/6T7wLJBawlggLRPwmPYKH/9uYb98 NSJt1gs4w5/hBGCfVkmA+3J8ocCZnFNHnSj7xKFwOOJtweSfsD+LzwwgOHnIiOU/00ih CAas1gxjpoislgZ0Odc4ARVuLy9JMsnselguHK//1Z0U8mCBTbH6bauJgldGb34t4BjE lk0uKdVHbkiaJFtXD7HzQo5W4vQOsd5cwX7OBmaNM0g+XOaWtWNcr9ztBjMeOBK14+15 oNTdSuCXoeY2Mn4bnhq+u5yvD6W5X/bweiFXrxdAYG4PYFAbkYXmnZ6qNWd/oZtmDxAu uqCA== X-Gm-Message-State: APjAAAWpxvVfOugJ+gTpgfA0ykgIRO5LZa8WbygHiNrTlZHib8Ba21em nF07gi77janB6HfEb/fo283HLAiUSdnyqvNytsA= X-Google-Smtp-Source: APXvYqzXePwMmNs55hixBu4+IfrZ4gkETYPVrExEHD2UWD0h2FOIELUjUmdNdLDG9KQCXq8x8FQZdxVZh7rv0QNJ1Yc= X-Received: by 2002:ac8:7292:: with SMTP id v18mr1945327qto.169.1574985585624; Thu, 28 Nov 2019 15:59:45 -0800 (PST) MIME-Version: 1.0 References: <156950767876.30879.17024491763471689960.stgit@warthog.procyon.org.uk> <2758feea-8d6e-c690-5cac-d42213f2024b@huawei.com> In-Reply-To: <2758feea-8d6e-c690-5cac-d42213f2024b@huawei.com> From: Joel Stanley Date: Thu, 28 Nov 2019 23:59:33 +0000 Message-ID: Subject: Re: [PATCH] jffs2: Fix mounting under new mount API To: Hou Tao X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191128_155949_348959_9B60758A X-CRM114-Status: GOOD ( 11.32 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Han Xu , Sergei Shtylyov , Andrew Jeffery , Richard Weinberger , Linux Kernel Mailing List , David Howells , linux-mtd , viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org, David Woodhouse Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org On Thu, 14 Nov 2019 at 12:05, Hou Tao wrote: > > Hi, > > On 2019/11/14 4:38, Han Xu wrote: > > Tested the JFFS2 on 5.4 kernel as the instruction said, still got some > > errors, any ideas? > > > > > > > With the patch, > > > > root@imx8mmevk:~# cat /proc/mtd > > dev: size erasesize name > > mtd0: 00400000 00020000 "mtdram test device" > > mtd1: 04000000 00020000 "5d120000.spi" > > root@imx8mmevk:~# mtd_debug info /dev/mtd0 > > mtd.type = MTD_RAM > > mtd.flags = MTD_CAP_RAM > > mtd.size = 4194304 (4M) > > mtd.erasesize = 131072 (128K) > > mtd.writesize = 1 > > mtd.oobsize = 0 > > regions = 0 > > > > root@imx8mmevk:~# flash_erase /dev/mtd0 0 0 > > Erasing 128 Kibyte @ 3e0000 -- 100 % complete > > root@imx8mmevk:~# mount -t jffs2 /dev/mtdblock0 test_dir/ > > root@imx8mmevk:~# mount > > /dev/mtdblock0 on /home/root/test_dir type jffs2 (rw,relatime) > > > > BUT, it's not writable. > > You should revert the following commit to make it work: > > commit f2538f999345405f7d2e1194c0c8efa4e11f7b3a > Author: Jia-Ju Bai > Date: Wed Jul 24 10:46:58 2019 +0800 > > jffs2: Fix possible null-pointer dereferences in jffs2_add_frag_to_fragtree() > > The revert needs to get into v5.4. Maybe Richard has forget about it ? I hit this today. The error I saw was: [ 4.975868] jffs2: error: (77) jffs2_build_inode_fragtree: Add node to tree failed -22 [ 4.983923] jffs2: error: (77) jffs2_do_read_inode_internal: Failed to build final fragtree for inode #5377: error -22 [ 4.994709] jffs2: Returned error for crccheck of ino #5377. Expect badness... Reverting the f2538f999345 commit fixed things. Is the revert queued for stable? Cheers, Joel ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/