* [PATCH 2/2] mtd: phram,slram: Disable when the kernel is locked down
[not found] <20190830154549.vss6h5tlrl6d5r5y@decadent.org.uk>
@ 2019-08-30 15:47 ` Ben Hutchings
2019-09-10 14:27 ` [PATCH 2/2] mtd: phram, slram: " Matthew Garrett
0 siblings, 1 reply; 5+ messages in thread
From: Ben Hutchings @ 2019-08-30 15:47 UTC (permalink / raw)
To: jmorris
Cc: David Howells, linux-mtd, linux-security-module, Joern Engel,
Matthew Garrett
[-- Attachment #1.1: Type: text/plain, Size: 2416 bytes --]
These drivers allow mapping arbitrary memory ranges as MTD devices.
This should be disabled to preserve the kernel's integrity when it is
locked down.
* Add the HWPARAM flag to the module parameters
* When slram is built-in, it uses __setup() to read kernel parameters,
so add an explicit check security_locked_down() check
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Cc: Matthew Garrett <mjg59@google.com>
Cc: David Howells <dhowells@redhat.com>
Cc: Joern Engel <joern@lazybastard.org>
Cc: linux-mtd@lists.infradead.org
---
drivers/mtd/devices/phram.c | 6 +++++-
drivers/mtd/devices/slram.c | 9 ++++++++-
2 files changed, 13 insertions(+), 2 deletions(-)
diff --git a/drivers/mtd/devices/phram.c b/drivers/mtd/devices/phram.c
index c467286ca007..9c18b4bb2ed9 100644
--- a/drivers/mtd/devices/phram.c
+++ b/drivers/mtd/devices/phram.c
@@ -294,7 +294,11 @@ static int phram_param_call(const char *val, const struct kernel_param *kp)
#endif
}
-module_param_call(phram, phram_param_call, NULL, NULL, 000);
+static const struct kernel_param_ops phram_param_ops = {
+ .set = phram_param_call
+};
+__module_param_call(MODULE_PARAM_PREFIX, phram, &phram_param_ops, NULL,
+ 000, -1, KERNEL_PARAM_FL_HWPARAM | hwparam_iomem);
MODULE_PARM_DESC(phram, "Memory region to map. \"phram=<name>,<start>,<length>\"");
diff --git a/drivers/mtd/devices/slram.c b/drivers/mtd/devices/slram.c
index 28131a127d06..d92a2461e2ce 100644
--- a/drivers/mtd/devices/slram.c
+++ b/drivers/mtd/devices/slram.c
@@ -43,6 +43,7 @@
#include <linux/ioctl.h>
#include <linux/init.h>
#include <linux/io.h>
+#include <linux/security.h>
#include <linux/mtd/mtd.h>
@@ -65,7 +66,7 @@ typedef struct slram_mtd_list {
#ifdef MODULE
static char *map[SLRAM_MAX_DEVICES_PARAMS];
-module_param_array(map, charp, NULL, 0);
+module_param_hw_array(map, charp, iomem, NULL, 0);
MODULE_PARM_DESC(map, "List of memory regions to map. \"map=<name>, <start>, <length / end>\"");
#else
static char *map;
@@ -281,11 +282,17 @@ static int __init init_slram(void)
#ifndef MODULE
char *devstart;
char *devlength;
+ int ret;
if (!map) {
E("slram: not enough parameters.\n");
return(-EINVAL);
}
+
+ ret = security_locked_down(LOCKDOWN_MODULE_PARAMETERS);
+ if (ret)
+ return ret;
+
while (map) {
devname = devstart = devlength = NULL;
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 144 bytes --]
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 2/2] mtd: phram, slram: Disable when the kernel is locked down
2019-08-30 15:47 ` [PATCH 2/2] mtd: phram,slram: Disable when the kernel is locked down Ben Hutchings
@ 2019-09-10 14:27 ` Matthew Garrett
2019-09-10 15:17 ` [PATCH 2/2] mtd: phram,slram: " James Morris
0 siblings, 1 reply; 5+ messages in thread
From: Matthew Garrett @ 2019-09-10 14:27 UTC (permalink / raw)
To: Ben Hutchings
Cc: David Howells, linux-mtd, LSM List, Joern Engel, James Morris
On Fri, Aug 30, 2019 at 11:47 AM Ben Hutchings <ben@decadent.org.uk> wrote:
>
> These drivers allow mapping arbitrary memory ranges as MTD devices.
> This should be disabled to preserve the kernel's integrity when it is
> locked down.
>
> * Add the HWPARAM flag to the module parameters
> * When slram is built-in, it uses __setup() to read kernel parameters,
> so add an explicit check security_locked_down() check
>
> Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
> Cc: Matthew Garrett <mjg59@google.com>
> Cc: David Howells <dhowells@redhat.com>
> Cc: Joern Engel <joern@lazybastard.org>
> Cc: linux-mtd@lists.infradead.org
Reviewed-by: Matthew Garrett <mjg59@google.com>
James, should I pick patches like this up and send them to you, or
will you queue them directly after they're acked?
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 2/2] mtd: phram,slram: Disable when the kernel is locked down
2019-09-10 14:27 ` [PATCH 2/2] mtd: phram, slram: " Matthew Garrett
@ 2019-09-10 15:17 ` James Morris
2019-09-10 22:18 ` [PATCH 2/2] mtd: phram, slram: " Richard Weinberger
0 siblings, 1 reply; 5+ messages in thread
From: James Morris @ 2019-09-10 15:17 UTC (permalink / raw)
To: Matthew Garrett
Cc: David Howells, Joern Engel, LSM List, Ben Hutchings, linux-mtd
On Tue, 10 Sep 2019, Matthew Garrett wrote:
> On Fri, Aug 30, 2019 at 11:47 AM Ben Hutchings <ben@decadent.org.uk> wrote:
> >
> > These drivers allow mapping arbitrary memory ranges as MTD devices.
> > This should be disabled to preserve the kernel's integrity when it is
> > locked down.
> >
> > * Add the HWPARAM flag to the module parameters
> > * When slram is built-in, it uses __setup() to read kernel parameters,
> > so add an explicit check security_locked_down() check
> >
> > Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
> > Cc: Matthew Garrett <mjg59@google.com>
> > Cc: David Howells <dhowells@redhat.com>
> > Cc: Joern Engel <joern@lazybastard.org>
> > Cc: linux-mtd@lists.infradead.org
>
> Reviewed-by: Matthew Garrett <mjg59@google.com>
>
> James, should I pick patches like this up and send them to you, or
> will you queue them directly after they're acked?
As long as I'm on the to or cc when they're acked, I can grab them.
--
James Morris
<jmorris@namei.org>
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 2/2] mtd: phram, slram: Disable when the kernel is locked down
2019-09-10 15:17 ` [PATCH 2/2] mtd: phram,slram: " James Morris
@ 2019-09-10 22:18 ` Richard Weinberger
2019-09-10 23:43 ` [PATCH 2/2] mtd: phram,slram: " Ben Hutchings
0 siblings, 1 reply; 5+ messages in thread
From: Richard Weinberger @ 2019-09-10 22:18 UTC (permalink / raw)
To: James Morris
Cc: Joern Engel, Matthew Garrett, David Howells, LSM List, linux-mtd,
Ben Hutchings
On Tue, Sep 10, 2019 at 5:17 PM James Morris <jmorris@namei.org> wrote:
>
> On Tue, 10 Sep 2019, Matthew Garrett wrote:
>
> > On Fri, Aug 30, 2019 at 11:47 AM Ben Hutchings <ben@decadent.org.uk> wrote:
> > >
> > > These drivers allow mapping arbitrary memory ranges as MTD devices.
> > > This should be disabled to preserve the kernel's integrity when it is
> > > locked down.
> > >
> > > * Add the HWPARAM flag to the module parameters
> > > * When slram is built-in, it uses __setup() to read kernel parameters,
> > > so add an explicit check security_locked_down() check
> > >
> > > Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
> > > Cc: Matthew Garrett <mjg59@google.com>
> > > Cc: David Howells <dhowells@redhat.com>
> > > Cc: Joern Engel <joern@lazybastard.org>
> > > Cc: linux-mtd@lists.infradead.org
> >
> > Reviewed-by: Matthew Garrett <mjg59@google.com>
> >
> > James, should I pick patches like this up and send them to you, or
> > will you queue them directly after they're acked?
>
> As long as I'm on the to or cc when they're acked, I can grab them.
Acked-by: Richard Weinberger <richard@nod.at>
BTW: I don't have 1/2 in my inbox, is it also MTD related?
--
Thanks,
//richard
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 2/2] mtd: phram,slram: Disable when the kernel is locked down
2019-09-10 22:18 ` [PATCH 2/2] mtd: phram, slram: " Richard Weinberger
@ 2019-09-10 23:43 ` Ben Hutchings
0 siblings, 0 replies; 5+ messages in thread
From: Ben Hutchings @ 2019-09-10 23:43 UTC (permalink / raw)
To: Richard Weinberger, James Morris
Cc: David Howells, linux-mtd, LSM List, Joern Engel, Matthew Garrett
[-- Attachment #1.1: Type: text/plain, Size: 1666 bytes --]
On Wed, 2019-09-11 at 00:18 +0200, Richard Weinberger wrote:
> On Tue, Sep 10, 2019 at 5:17 PM James Morris <jmorris@namei.org> wrote:
> > On Tue, 10 Sep 2019, Matthew Garrett wrote:
> >
> > > On Fri, Aug 30, 2019 at 11:47 AM Ben Hutchings <ben@decadent.org.uk> wrote:
> > > > These drivers allow mapping arbitrary memory ranges as MTD devices.
> > > > This should be disabled to preserve the kernel's integrity when it is
> > > > locked down.
> > > >
> > > > * Add the HWPARAM flag to the module parameters
> > > > * When slram is built-in, it uses __setup() to read kernel parameters,
> > > > so add an explicit check security_locked_down() check
> > > >
> > > > Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
> > > > Cc: Matthew Garrett <mjg59@google.com>
> > > > Cc: David Howells <dhowells@redhat.com>
> > > > Cc: Joern Engel <joern@lazybastard.org>
> > > > Cc: linux-mtd@lists.infradead.org
> > >
> > > Reviewed-by: Matthew Garrett <mjg59@google.com>
> > >
> > > James, should I pick patches like this up and send them to you, or
> > > will you queue them directly after they're acked?
> >
> > As long as I'm on the to or cc when they're acked, I can grab them.
>
> Acked-by: Richard Weinberger <richard@nod.at>
>
> BTW: I don't have 1/2 in my inbox, is it also MTD related?
No, that was for some other drivers (comedi) that allow setting I/O
addresses from user-space.
Ben.
--
Ben Hutchings
The obvious mathematical breakthrough [to break modern encryption]
would be development of an easy way to factor large prime numbers.
- Bill Gates
[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 144 bytes --]
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-09-10 23:43 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20190830154549.vss6h5tlrl6d5r5y@decadent.org.uk>
2019-08-30 15:47 ` [PATCH 2/2] mtd: phram,slram: Disable when the kernel is locked down Ben Hutchings
2019-09-10 14:27 ` [PATCH 2/2] mtd: phram, slram: " Matthew Garrett
2019-09-10 15:17 ` [PATCH 2/2] mtd: phram,slram: " James Morris
2019-09-10 22:18 ` [PATCH 2/2] mtd: phram, slram: " Richard Weinberger
2019-09-10 23:43 ` [PATCH 2/2] mtd: phram,slram: " Ben Hutchings
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).