From: Doug Anderson <dianders@chromium.org>
To: Vignesh Raghavendra <vigneshr@ti.com>
Cc: Michael Walle <michael@walle.cc>,
linux-mtd@lists.infradead.org,
LKML <linux-kernel@vger.kernel.org>,
Tudor Ambarus <tudor.ambarus@microchip.com>
Subject: Re: [PATCH] Revert "mtd: spi-nor: Prefer asynchronous probe"
Date: Mon, 5 Oct 2020 07:43:21 -0700 [thread overview]
Message-ID: <CAD=FV=XLWgyS0T5h9JtNpDSo4PebUYX-YEAW9nBo5VyhKRbvYA@mail.gmail.com> (raw)
In-Reply-To: <20201005090321.8724-1-vigneshr@ti.com>
Hi,
On Mon, Oct 5, 2020 at 2:03 AM Vignesh Raghavendra <vigneshr@ti.com> wrote:
>
> This reverts commit 03edda0e1edaa3c2e99239c66e3c14d749318fd6.
>
> This leads to warn dump like [1] on some platforms and reorders MTD
> devices thus may break user space expectations. So revert the change.
>
> [1]:
>
> [ 1.849801] ------------[ cut here ]------------
> [ 1.854271] mscc_felix 0000:00:00.5: device is disabled, skipping
> [ 1.858753] WARNING: CPU: 1 PID: 7 at kernel/kmod.c:136 __request_module+0x3a4/0x568
>
> [...]
>
> Reported-by: Michael Walle <michael@walle.cc>
> Signed-off-by: Vignesh Raghavendra <vigneshr@ti.com>
> ---
> drivers/mtd/spi-nor/core.c | 1 -
> 1 file changed, 1 deletion(-)
Thank you for the revert and sorry for the breakage.
Reviewed-by: Douglas Anderson <dianders@chromium.org>
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2020-10-05 14:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-05 9:03 [PATCH] Revert "mtd: spi-nor: Prefer asynchronous probe" Vignesh Raghavendra
2020-10-05 14:43 ` Doug Anderson [this message]
2020-10-06 5:23 ` Vignesh Raghavendra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAD=FV=XLWgyS0T5h9JtNpDSo4PebUYX-YEAW9nBo5VyhKRbvYA@mail.gmail.com' \
--to=dianders@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=michael@walle.cc \
--cc=tudor.ambarus@microchip.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).