From: Richard Weinberger <richard.weinberger@gmail.com>
To: "Doyle, Patrick" <pdoyle@irobot.com>
Cc: "u-boot@lists.denx.de" <u-boot@lists.denx.de>,
"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
Boris Brezillon <boris.brezillon@bootlin.com>
Subject: Re: [PATCH] Fix corner case in bad block table handling.
Date: Mon, 3 Aug 2020 10:30:11 +0200 [thread overview]
Message-ID: <CAFLxGvx5TLu3b8-hXWBaRn3Z-vNL4kqM-JQyh_mzeNhyhLAOtg@mail.gmail.com> (raw)
In-Reply-To: <MN2PR13MB3309227C223D0CD8AFE5836AB37E0@MN2PR13MB3309.namprd13.prod.outlook.com>
On Wed, Jul 15, 2020 at 4:54 PM Doyle, Patrick <pdoyle@irobot.com> wrote:
>
>
>
> In the unlikely event that both blocks 10 and 11 are marked as bad (on a
> 32 bit machine), then the process of marking block 10 as bad stomps on
> cached entry for block 11. There are (of course) other examples.
>
> Signed-off-by: Patrick Doyle <pdoyle@irobot.com>
> ---
> drivers/mtd/nand/bbt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/nand/bbt.c b/drivers/mtd/nand/bbt.c
> index 7e0ad3190c..eb1184aadb 100644
> --- a/drivers/mtd/nand/bbt.c
> +++ b/drivers/mtd/nand/bbt.c
> @@ -124,7 +124,7 @@ int nanddev_bbt_set_block_status(struct nand_device *nand, unsigned int entry,
> unsigned int rbits = bits_per_block + offs - BITS_PER_LONG;
>
> pos[1] &= ~GENMASK(rbits - 1, 0);
> - pos[1] |= val >> rbits;
> + pos[1] |= val >> (bits_per_block - rbits);
Looks good to me.
Fixes: 9c3736a3de21 ("mtd: nand: Add core infrastructure to deal with
NAND devices")
Reviewed-by: Richard Weinberger <richard@nod.at>
--
Thanks,
//richard
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2020-08-03 8:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-15 14:46 [PATCH] Fix corner case in bad block table handling Doyle, Patrick
2020-08-03 8:30 ` Richard Weinberger [this message]
2020-08-05 20:27 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFLxGvx5TLu3b8-hXWBaRn3Z-vNL4kqM-JQyh_mzeNhyhLAOtg@mail.gmail.com \
--to=richard.weinberger@gmail.com \
--cc=boris.brezillon@bootlin.com \
--cc=linux-mtd@lists.infradead.org \
--cc=pdoyle@irobot.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).