From: Richard Weinberger <richard.weinberger@gmail.com>
To: Zhihao Cheng <chengzhihao1@huawei.com>
Cc: Richard Weinberger <richard@nod.at>,
Sascha Hauer <s.hauer@pengutronix.de>,
linux-mtd@lists.infradead.org,
LKML <linux-kernel@vger.kernel.org>,
"zhangyi \(F\)" <yi.zhang@huawei.com>
Subject: Re: [PATCH v2] ubifs: Fix deadlock in concurrent bulk-read and writepage
Date: Thu, 16 Jan 2020 23:45:10 +0100 [thread overview]
Message-ID: <CAFLxGvzOeL_0Lq30rvbaSuxsFZSzYSvKw2V=C1gvbad9VPjiEQ@mail.gmail.com> (raw)
In-Reply-To: <1578736236-141308-1-git-send-email-chengzhihao1@huawei.com>
On Sat, Jan 11, 2020 at 10:43 AM Zhihao Cheng <chengzhihao1@huawei.com> wrote:
>
> In ubifs, concurrent execution of writepage and bulk read on the same file
> may cause ABBA deadlock, for example (Reproduce method see Link):
>
> Process A(Bulk-read starts from page4) Process B(write page4 back)
> vfs_read wb_workfn or fsync
> ... ...
> generic_file_buffered_read write_cache_pages
> ubifs_readpage LOCK(page4)
>
> ubifs_bulk_read ubifs_writepage
> LOCK(ui->ui_mutex) ubifs_write_inode
>
> ubifs_do_bulk_read LOCK(ui->ui_mutex)
> find_or_create_page(alloc page4) ↑
> LOCK(page4) <-- ABBA deadlock occurs!
>
> In order to ensure the serialization execution of bulk read, we can't
> remove the big lock 'ui->ui_mutex' in ubifs_bulk_read(). Instead, we
> allow ubifs_do_bulk_read() to lock page failed by replacing
> find_or_create_page(FGP_LOCK) with
> pagecache_get_page(FGP_LOCK | FGP_NOWAIT).
>
> Signed-off-by: Zhihao Cheng <chengzhihao1@huawei.com>
> Suggested-by: zhangyi (F) <yi.zhang@huawei.com>
> Cc: <Stable@vger.kernel.org>
> Fixes: 4793e7c5e1c ("UBIFS: add bulk-read facility")
> Link: https://bugzilla.kernel.org/show_bug.cgi?id=206153
> ---
> fs/ubifs/file.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
Applied. Thanks a lot for hunting this down!
--
Thanks,
//richard
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
prev parent reply other threads:[~2020-01-16 22:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-11 9:50 [PATCH v2] ubifs: Fix deadlock in concurrent bulk-read and writepage Zhihao Cheng
2020-01-16 22:45 ` Richard Weinberger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFLxGvzOeL_0Lq30rvbaSuxsFZSzYSvKw2V=C1gvbad9VPjiEQ@mail.gmail.com' \
--to=richard.weinberger@gmail.com \
--cc=chengzhihao1@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=richard@nod.at \
--cc=s.hauer@pengutronix.de \
--cc=yi.zhang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).