Re: [PATCH RFC 3/3] nand: pl353: Add driver for arm pl353 smc nand interface

From: punnaiah choudary kalluri <punnaia@xilinx.com>
To: monstr@monstr.eu
Cc: "mark.rutland@arm.com" <mark.rutland@arm.com>,
	"jussi.kivilinna@iki.fi" <jussi.kivilinna@iki.fi>,
	"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
	"artem.bityutskiy@linux.intel.com"
	<artem.bityutskiy@linux.intel.com>,
	"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
	"arnd@arndb.de" <arnd@arndb.de>,
	"michal.simek@xilinx.com" <michal.simek@xilinx.com>,
	"ezequiel.garcia@free-electrons.com"
	<ezequiel.garcia@free-electrons.com>,
	"grant.likely@linaro.org" <grant.likely@linaro.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"jason@lakedaemon.net" <jason@lakedaemon.net>,
	"pawel.moll@arm.com" <pawel.moll@arm.com>,
	"ijc+devicetree@hellion.org.uk" <ijc+devicetree@hellion.org.uk>,
	"joern@logfs.org" <joern@logfs.org>,
	Punnaiah Choudary Kalluri <punnaiah.choudary.kalluri@xilinx.com>,
	"robh+dt@kernel.org" <robh+dt@kernel.org>,
	"acourbot@nvidia.com" <acourbot@nvidia.com>,
	"Gupta, Pekon" <pekon@ti.com>,
	Punnaiah Choudary <kpc528@gmail.com>,
	"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"rob@landley.net" <rob@landley.net>,
	"galak@codeaurora.org" <galak@codeaurora.org>,
	"Khoronzhuk, Ivan" <ivan.khoronzhuk@ti.com>,
	"computersforpeace@gmail.com" <computersforpeace@gmail.com>,
	"dwmw2@infradead.org" <dwmw2@infradead.org>
Subject: Re: [PATCH RFC 3/3] nand: pl353: Add driver for arm pl353 smc nand interface
Date: Thu, 3 Apr 2014 10:35:41 +0530	[thread overview]
Message-ID: <CAGnW=BYkoi3MzfbzWU67C+e_CY+YL8m7zGL8D5Cd61SjkrQpXg@mail.gmail.com> (raw)
In-Reply-To: <53396C95.3030005@monstr.eu>

On Mon, Mar 31, 2014 at 6:54 PM, Michal Simek <monstr@monstr.eu> wrote:
> On 03/31/2014 02:46 PM, Michal Simek wrote:
>> On 03/27/2014 07:21 PM, Punnaiah Choudary Kalluri wrote:
>>> Add driver for arm pl353 static memory controller nand interface.
>>> This controller is used in xilinx zynq soc for interfacing the nand
>>> flash memory.
>>>
>>> Signed-off-by: Punnaiah Choudary Kalluri <punnaia@xilinx.com>
>>> ---
>>>  drivers/mtd/nand/Kconfig      |    8 +
>>>  drivers/mtd/nand/Makefile     |    1 +
>>>  drivers/mtd/nand/pl353_nand.c | 1122 +++++++++++++++++++++++++++++++++++++++++
>>>  3 files changed, 1131 insertions(+), 0 deletions(-)
>>>  create mode 100644 drivers/mtd/nand/pl353_nand.c
>>>
>>> diff --git a/drivers/mtd/nand/Kconfig b/drivers/mtd/nand/Kconfig
>>> index 90ff447..31c1d0c 100644
>>> --- a/drivers/mtd/nand/Kconfig
>>> +++ b/drivers/mtd/nand/Kconfig
>>> @@ -510,4 +510,12 @@ config MTD_NAND_XWAY
>>>        Enables support for NAND Flash chips on Lantiq XWAY SoCs. NAND is attached
>>>        to the External Bus Unit (EBU).
>>>
>>> +config MTD_NAND_PL353
>>> +    tristate "ARM Pl353 NAND flash driver"
>>> +    depends on MTD_NAND && ARM
>>> +    select PL353_SMC
>>
>> Here should be probably depends on PL353_SMC.
>> I just found it.
>
> Just to be accurate.
> When MEMORY=n with select PL353_SMC you are not able select PL353_SMC
> and compile it.

OK. I will check this one and fix it in v2.

Punnaiah

>
> Thanks,
> Michal
>
> --
> Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
> w: www.monstr.eu p: +42-0-721842854
> Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
> Maintainer of Linux kernel - Xilinx Zynq ARM architecture
> Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform
>
>