From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: kbuild test robot <lkp@intel.com>
Cc: devicetree <devicetree@vger.kernel.org>,
kbuild-all@lists.01.org, Vignesh R <vigneshr@ti.com>,
Arnd Bergmann <arnd@arndb.de>,
Richard Weinberger <richard@nod.at>,
Brendan Higgins <brendanhiggins@google.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"Ramuthevar,
Vadivel MuruganX" <vadivel.muruganx.ramuthevar@linux.intel.com>,
Boris Brezillon <boris.brezillon@collabora.com>,
"open list:MEMORY TECHNOLOGY..." <linux-mtd@lists.infradead.org>,
Miquel Raynal <miquel.raynal@bootlin.com>,
Anders Roxell <anders.roxell@linaro.org>,
Thomas Gleixner <tglx@linutronix.de>,
masonccyang@mxic.com.tw
Subject: Re: [PATCH v7 2/2] mtd: rawnand: Add NAND controller support on Intel LGM SoC
Date: Fri, 15 May 2020 17:27:19 +0300 [thread overview]
Message-ID: <CAHp75VdUWaEAuStEQZD4yOWcxBT0EkxiX90u1_9vppFb5JniGQ@mail.gmail.com> (raw)
In-Reply-To: <CAHp75Ven9q-6dDYtP_uXigeS_r2uvpUZVR5Mh0RdEd36MbTG+Q@mail.gmail.com>
On Fri, May 15, 2020 at 5:25 PM Andy Shevchenko
<andy.shevchenko@gmail.com> wrote:
> On Fri, May 15, 2020 at 4:48 PM kbuild test robot <lkp@intel.com> wrote:
> > 440 reg = cpu_to_be32(*pdata++);
> > > 441 writel(reg, ebu_host->hsnand + HSNAND_CMSG_0);
> > 442
> > 443 reg = cpu_to_be32(*pdata);
> > 444 writel(reg, ebu_host->hsnand + HSNAND_CMSG_1);
>
> On BE:
> cpu_to_be32 -> no-op
> writel() -> converts reg to LE
>
> On LE:
> cpu_to_be32 -> converts to BE
> writel() -> no-op (in terms of conversion)
>
> Seems to me that the proper API (if above is intended) should be swab32().
> But something tells me that above is broken (or my understanding is wrong).
And perhaps it should use lo_hi_writeq() or something like that.
--
With Best Regards,
Andy Shevchenko
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2020-05-15 14:27 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-15 10:55 [PATCH v7 0/2] mtd: rawnand: Add NAND controller support on Intel LGM SoC Ramuthevar, Vadivel MuruganX
2020-05-15 10:55 ` [PATCH v7 1/2] dt-bindings: mtd: Add Nand Flash Controller support for " Ramuthevar, Vadivel MuruganX
2020-05-15 10:55 ` [PATCH v7 2/2] mtd: rawnand: Add NAND controller support on " Ramuthevar, Vadivel MuruganX
2020-05-15 11:48 ` Andy Shevchenko
2020-05-15 13:43 ` kbuild test robot
2020-05-15 14:25 ` Andy Shevchenko
2020-05-15 14:27 ` Andy Shevchenko [this message]
2020-05-15 14:30 ` Arnd Bergmann
2020-05-18 11:39 ` Ramuthevar, Vadivel MuruganX
2020-05-18 11:43 ` Andy Shevchenko
2020-05-18 11:57 ` Arnd Bergmann
2020-05-18 13:20 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHp75VdUWaEAuStEQZD4yOWcxBT0EkxiX90u1_9vppFb5JniGQ@mail.gmail.com \
--to=andy.shevchenko@gmail.com \
--cc=anders.roxell@linaro.org \
--cc=arnd@arndb.de \
--cc=boris.brezillon@collabora.com \
--cc=brendanhiggins@google.com \
--cc=devicetree@vger.kernel.org \
--cc=kbuild-all@lists.01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=lkp@intel.com \
--cc=masonccyang@mxic.com.tw \
--cc=miquel.raynal@bootlin.com \
--cc=richard@nod.at \
--cc=tglx@linutronix.de \
--cc=vadivel.muruganx.ramuthevar@linux.intel.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).