From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1D1EDC5DF60 for ; Thu, 7 Nov 2019 09:32:04 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E2C2420673 for ; Thu, 7 Nov 2019 09:32:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="KIy+WZrm"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mAChVYxc" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E2C2420673 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=UD1gBUBR4Dk2KZUCEnb+t4UdlomKhXqPsKYdO1SwAfQ=; b=KIy+WZrmmz7y6f kLRaEU7ttxMiMFtleALhP6CteWf8PBvQRIzwIDVv+dEaZ4KTOb9iX5MhlaNFgDoyr1sObP+VjzXqv 0Gl8nQPV6H32SzYhwuXGUwMWnKbzimhO+PQhrb2/oZLMVIKb0y8tYAB/ORoONtMgq1d/gROGvZsu4 GEy7T5yp3FUI6qFeXvims7oGkLU+HlU+NDRUjh/wP28kvKGFZ8qtKKQVQhbEgP6+ctWQkS+iazsDi dsaCCjQwsX40v/lFw5prLOTxrv4W2nRliwawqaE1UDiQ/2RG2tnpeetLjqFnSKBA4KgqagzAIrY7i XiddhCK9eMvtHX3v3SJA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iSe8r-000191-T7; Thu, 07 Nov 2019 09:31:49 +0000 Received: from mail-ot1-x341.google.com ([2607:f8b0:4864:20::341]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iSe8p-00018M-PP; Thu, 07 Nov 2019 09:31:49 +0000 Received: by mail-ot1-x341.google.com with SMTP id z6so1449043otb.2; Thu, 07 Nov 2019 01:31:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Iuasj2afgMJAzja6uysg+1QDLDZRD47UOISLXL9pb2M=; b=mAChVYxcoSkGwnhp7ff0QokhxUd9QPmLoT9Cn1E5xIr6i0h+cx4rUyZ+2s5Xciwe/i Kq4kM1DVxxmaURAxoZGrw+n/+u10deLVn2EQpK/BzXp8JvX+qpdFP6mu/BJgzNKVqvus Zf8mTPaeOflRCP43BUE0t5I5xFGekUFkw0KjgYSTC3QxMZV3o/1Hm4mLGZ2ntTOtERUF F7kYt6w5xMOSvINLjuEcwvaqvMMNY6g6uy/k2pa3Gv9Gd4uBV6k2YrUj+N+54vPfLVnB Movv9Q+DXqaspibA9j9xhl8o1i20Y1d74H70SIvtktZr5MOD0HjDgGD8jXq9Rm6axuHc h2eg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Iuasj2afgMJAzja6uysg+1QDLDZRD47UOISLXL9pb2M=; b=BtZ2e/alMrsCTZ9HX3PY5DG8KWsAT5EXIPDXNHDQMr9mBAG8OF9GsSGNNWcy3YUYwe v9X1nyhjTC+93HoMSvz8sU4pIKBcr7HonQE9g+hbwazzffpQPt6adZ8bIc8K4W1d2sYx nB5EW1iXKPFzRYCla+GrgqoTh32rSKsudg675GdvdWF6Bql6xPcI/3WHiFhFY9fxO/NU 6k7RX+cfmI1srkVjHby7rn1vYgTPmzcdzjr9rjF73ooAiKf9wxmWYzUa3XZaUHz4aH0w 4y8kkR3vSk8nXLap1Bu2oy0Ba4/3zJAtzJA1U3oC3Ha+4KYUlP+ssVt95oMURmkmijUE gYgg== X-Gm-Message-State: APjAAAVix6tDzo5rrg1ygjbU7+99JnZebgNURpPaopiTUw+FJRBHRDEv yvwpMlASKLFie8mo7pCNUvJUdfMnRIA/CsuKrmg= X-Google-Smtp-Source: APXvYqxM2u5buXTzjVMjKs0NiT8xZ4gQE9rzxlSnRNK0x5jTIg9zCq0fAgqpl2XlavGpu0oHc0B6P/uQpa0ir3k8lhM= X-Received: by 2002:a9d:1b0d:: with SMTP id l13mr193968otl.84.1573119106712; Thu, 07 Nov 2019 01:31:46 -0800 (PST) MIME-Version: 1.0 References: <20191106140748.13100-1-gch981213@gmail.com> <20191106140748.13100-2-gch981213@gmail.com> In-Reply-To: From: Chuanhong Guo Date: Thu, 7 Nov 2019 17:31:35 +0800 Message-ID: Subject: Re: [PATCH 1/2] mtd: mtk-quadspi: add support for memory-mapped flash reading To: Vignesh Raghavendra X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191107_013147_823807_08DC02B1 X-CRM114-Status: GOOD ( 13.87 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Tudor Ambarus , Richard Weinberger , open list , Rob Herring , linux-mtd@lists.infradead.org, Miquel Raynal , Matthias Brugger , linux-mediatek@lists.infradead.org, Brian Norris , David Woodhouse , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org Hi! On Thu, Nov 7, 2019 at 2:05 PM Vignesh Raghavendra wrote: > > @@ -272,6 +273,11 @@ static ssize_t mtk_nor_read(struct spi_nor *nor, loff_t from, size_t length, > > mtk_nor_set_read_mode(mtk_nor); > > mtk_nor_set_addr(mtk_nor, addr); > > > > + if (mtk_nor->flash_base) { > > + memcpy_fromio(buffer, mtk_nor->flash_base + from, length); > > + return length; > > + } > > + > > Don't you need to check if access is still within valid memory mapped > window? The mapped area is 256MB and I don't quite believe there will be such a big NOR flash. I'll add a check here in the next version. > > > for (i = 0; i < length; i++) { > > ret = mtk_nor_execute_cmd(mtk_nor, MTK_NOR_PIO_READ_CMD); > > if (ret < 0) > > @@ -475,6 +481,11 @@ static int mtk_nor_drv_probe(struct platform_device *pdev) > > if (IS_ERR(mtk_nor->base)) > > return PTR_ERR(mtk_nor->base); > > > > + res = platform_get_resource(pdev, IORESOURCE_MEM, 1); > > + mtk_nor->flash_base = devm_ioremap_resource(&pdev->dev, res); > > There is a single API now: devm_platform_ioremap_resource(). Cool. I'll change it. Should I add another patch to change the same mapping operation right above this piece of code? Regards, Chuanhong Guo ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/