From: Chuanhong Guo <gch981213@gmail.com>
To: Boris Brezillon <boris.brezillon@collabora.com>
Cc: Vignesh Raghavendra <vigneshr@ti.com>,
Boris Brezillon <bbrezillon@kernel.org>,
Richard Weinberger <richard@nod.at>,
open list <linux-kernel@vger.kernel.org>,
linux-mtd@lists.infradead.org,
Miquel Raynal <miquel.raynal@bootlin.com>
Subject: Re: [PATCH v2] mtd: nand: spi: rework detect procedure for different read id op
Date: Fri, 10 Jan 2020 15:34:28 +0800 [thread overview]
Message-ID: <CAJsYDVK4RtX92O3M+EOsZa5qS4TxE0OVaEq=KOnAuP6DEHvw2Q@mail.gmail.com> (raw)
In-Reply-To: <20200110075859.3edfae3a@collabora.com>
Hi!
On Fri, Jan 10, 2020 at 2:59 PM Boris Brezillon
<boris.brezillon@collabora.com> wrote:
> [...]
> > + ret = spinand_read_id_op(spinand, 1, 0, id);
> > + if (ret)
> > + return ret;
> > + ret = spinand_manufacturer_match(spinand,
> > + SPINAND_READID_METHOD_OPCODE_ADDR);
> > + if (!ret)
> > + return 0;
> > +
> > + ret = spinand_read_id_op(spinand, 0, 1, id);
>
> Hm, we should probably do only one of each read_id and iterate over all
> manufacturers/chips each time instead of doing 3 read_ids per
> manufacturer.
This actually do the former instead of the latter. Maybe the function
names are a bit
misleading. spinand_manufacturer_match iterates over all manufacturers
in one call,
and spinand_manufacturer_detect is called once in spinand_detect.
Do you have suggestions on function naming?
> [...]
> > + * SPINAND_READID_METHOD_OPCODE_DUMMY: chip id is returned after
> > + * read_id opcode + 1 dummy byte.
> > + */
> > +struct spinand_devid {
> > + u16 id;
>
> Can we make that field an array of u8?
>
> const u8 *id;
>
> > + u8 len;
> > + enum spinand_readid_method method;
> > +};
> [...]
> >
> > +#define SPINAND_ID(__id, __len, __method) \
> > + { \
> > + .id = __id, \
> > + .len = __len, \
> > + .method = __method, \
> > + }
>
> That one can be turned into
>
> #define SPINAND_ID(__method, ...) \
> { \
> .id = (const u8[]){ __VA_ARGS }, \
> .len = sizeof((u8[]){ __VA_ARGS }), \
> .method = __method, \
> }
Wow. I never thought of this cool trick. I'll give it a try.
Regards,
Chuanhong Guo
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2020-01-10 7:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-10 2:51 [PATCH v2] mtd: nand: spi: rework detect procedure for different read id op Chuanhong Guo
2020-01-10 6:58 ` Boris Brezillon
2020-01-10 7:34 ` Chuanhong Guo [this message]
2020-01-10 8:04 ` Boris Brezillon
2020-01-10 8:10 ` Miquel Raynal
2020-01-10 8:21 ` Boris Brezillon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJsYDVK4RtX92O3M+EOsZa5qS4TxE0OVaEq=KOnAuP6DEHvw2Q@mail.gmail.com' \
--to=gch981213@gmail.com \
--cc=bbrezillon@kernel.org \
--cc=boris.brezillon@collabora.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=miquel.raynal@bootlin.com \
--cc=richard@nod.at \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).