From: Masahiro Yamada <yamada.masahiro@socionext.com>
To: Miquel Raynal <miquel.raynal@bootlin.com>
Cc: Boris Brezillon <bbrezillon@kernel.org>,
Richard Weinberger <richard@nod.at>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Marek Vasut <marek.vasut@gmail.com>,
linux-mtd <linux-mtd@lists.infradead.org>,
Brian Norris <computersforpeace@gmail.com>,
David Woodhouse <dwmw2@infradead.org>
Subject: Re: [PATCH v2 04/10] mtd: rawnand: denali: switch over to ->exec_op() from legacy hooks
Date: Tue, 5 Mar 2019 16:13:19 +0900 [thread overview]
Message-ID: <CAK7LNAS_c0SsWwwkqc5_HBX560NPM5-QJSH9_JcTLULHvz3b1A@mail.gmail.com> (raw)
In-Reply-To: <20190304103052.0eba71a6@xps13>
Hi Miquel,
On Mon, Mar 4, 2019 at 6:31 PM Miquel Raynal <miquel.raynal@bootlin.com> wrote:
>
> Hi Masahiro,
>
> Masahiro Yamada <yamada.masahiro@socionext.com> wrote on Tue, 12 Feb
> 2019 16:12:56 +0900:
>
> > Implement ->exec_op(), and remove the deprecated hooks.
> >
> > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> > ---
>
> Thanks for working on this, I like it very much!
>
> >
> > Changes in v2: None
> >
> > drivers/mtd/nand/raw/denali.c | 234 +++++++++++++++++++++++-------------------
> > 1 file changed, 126 insertions(+), 108 deletions(-)
> >
> > diff --git a/drivers/mtd/nand/raw/denali.c b/drivers/mtd/nand/raw/denali.c
> > index a2fe2ff..bd7df25 100644
> > --- a/drivers/mtd/nand/raw/denali.c
> > +++ b/drivers/mtd/nand/raw/denali.c
>
> [...]
>
> > +
> > +static int denali_exec_instr(struct nand_chip *chip,
> > + const struct nand_op_instr *instr)
> > +{
> > + struct denali_nand_info *denali = to_denali(chip);
> > + bool width16 = chip->options & NAND_BUSWIDTH_16;
> > +
> > + switch (instr->type) {
> > + case NAND_OP_CMD_INSTR:
> > + denali_exec_out8(denali, DENALI_MAP11_CMD,
> > + &instr->ctx.cmd.opcode, 1);
> > + return 0;
> > + case NAND_OP_ADDR_INSTR:
> > + denali_exec_out8(denali, DENALI_MAP11_ADDR,
> > + instr->ctx.addr.addrs,
> > + instr->ctx.addr.naddrs);
> > + return 0;
> > + case NAND_OP_DATA_IN_INSTR:
> > + (!instr->ctx.data.force_8bit && width16 ?
> > + denali_exec_in16 :
> > + denali_exec_in8)(denali, DENALI_MAP11_DATA,
> > + instr->ctx.data.buf.in,
> > + instr->ctx.data.len);
>
> I think this is abusing the ternary operator, can you please find
> another way for writing this? Otherwise it is not easily readable... If
> it is really too complicated within 80 chars, then never mind.
Yes, I am abusing it,
but the intention is quite clear.
I could stupidly repeat the same function arguments like follows,
but I did not want to do it.
case NAND_OP_DATA_IN_INSTR:
if (!instr->ctx.data.force_8bit && width16)
denali_exec_in16(denali, DENALI_MAP11_DATA,
instr->ctx.data.buf.in,
instr->ctx.data.len);
else
denali_exec_in8(denali, DENALI_MAP11_DATA,
instr->ctx.data.buf.in,
instr->ctx.data.len);
> > + return 0;
> > + case NAND_OP_DATA_OUT_INSTR:
> > + (!instr->ctx.data.force_8bit && width16 ?
> > + denali_exec_out16 :
> > + denali_exec_out8)(denali, DENALI_MAP11_DATA,
> > + instr->ctx.data.buf.out,
> > + instr->ctx.data.len);
> > + return 0;
> > + case NAND_OP_WAITRDY_INSTR:
> > + return denali_exec_waitrdy(denali);
> > + default:
> > + WARN_ONCE(1, "unsupported NAND instruction type: %d\n",
> > + instr->type);
> > +
> > + return -EINVAL;
> > + }
> > +}
> > +
>
>
> Thanks,
> Miquèl
>
> ______________________________________________________
> Linux MTD discussion mailing list
> http://lists.infradead.org/mailman/listinfo/linux-mtd/
--
Best Regards
Masahiro Yamada
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2019-03-05 7:14 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-12 7:12 [PATCH v2 00/10] mtd: rawnand: denali: exec_op(), controller/chip separation, and cleanups Masahiro Yamada
2019-02-12 7:12 ` [PATCH v2 01/10] mtd: rawnand: denali: use nand_chip pointer more for internal functions Masahiro Yamada
2019-02-12 7:12 ` [PATCH v2 02/10] mtd: rawnand: denali: refactor syndrome layout handling for raw access Masahiro Yamada
2019-03-04 9:01 ` Miquel Raynal
2019-03-05 9:20 ` Masahiro Yamada
2019-03-05 17:55 ` Miquel Raynal
2019-02-12 7:12 ` [PATCH v2 03/10] mtd: rawnand: denali: remove unneeded casts in denali_{read, write}_pio Masahiro Yamada
2019-02-12 7:12 ` [PATCH v2 04/10] mtd: rawnand: denali: switch over to ->exec_op() from legacy hooks Masahiro Yamada
2019-03-04 9:30 ` Miquel Raynal
2019-03-05 7:13 ` Masahiro Yamada [this message]
2019-02-12 7:12 ` [PATCH v2 05/10] mtd: rawnand: denali: use more precise timeout for NAND_OP_WAITRDT_INSTR Masahiro Yamada
2019-03-04 8:43 ` Miquel Raynal
2019-03-05 6:36 ` Masahiro Yamada
2019-02-12 7:12 ` [PATCH v2 06/10] mtd: rawnand: denali: use bool type instead of int where appropriate Masahiro Yamada
2019-02-12 7:12 ` [PATCH v2 07/10] mtd: rawnand: denali_pci: rename goto labels Masahiro Yamada
2019-02-12 7:13 ` [PATCH v2 08/10] mtd: rawnand: denali: decouple controller and NAND chips Masahiro Yamada
2019-02-18 20:01 ` Rob Herring
2019-02-12 7:13 ` [PATCH v2 09/10] mtd: rawnand: denali: remove DENALI_NR_BANKS macro Masahiro Yamada
2019-02-12 7:13 ` [PATCH v2 10/10] mtd: rawnand: denali: clean up coding style Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAK7LNAS_c0SsWwwkqc5_HBX560NPM5-QJSH9_JcTLULHvz3b1A@mail.gmail.com \
--to=yamada.masahiro@socionext.com \
--cc=bbrezillon@kernel.org \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=marek.vasut@gmail.com \
--cc=miquel.raynal@bootlin.com \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).