Linux-mtd Archive on
 help / color / Atom feed
From: Kamal Dasu <>
To: Richard Weinberger <>
Cc: Boris Brezillon <>,
	Richard Weinberger <>,
	Kamal Dasu <>,
	LKML <>,
	Marek Vasut <>,
	MTD Maling List <>,
	Miquel Raynal <>,,
	Brian Norris <>,
	David Woodhouse <>
Subject: Re: [PATCH] mtd: nand: raw: brcmnand: When oops in progress use pio and interrupt polling
Date: Thu, 16 May 2019 10:47:07 -0400
Message-ID: <> (raw)
In-Reply-To: <>

On Mon, May 6, 2019 at 12:01 PM Richard Weinberger
<> wrote:
> On Wed, May 1, 2019 at 7:52 PM Kamal Dasu <> wrote:
> >
> > If mtd_oops is in progress switch to polling for nand command completion
> > interrupts and use PIO mode wihtout DMA so that the mtd_oops buffer can
> > be completely written in the assinged nand partition. This is needed in
> > cases where the panic does not happen on cpu0 and there is only one online
> > CPU and the panic is not on cpu0.
> This optimization is highly specific to your hardware and AFAIK cannot
> be applied
> in general to brcmnand.
> So the problem you see is that depending on the oops you can no longer use dma
> or interrupts in the driver?
> How about adding a new flag to panic_nand_write() which tells the nand
> driver that
> this is a panic write?
> That way you can fall back to pio and polling mode without checking cpu numbers
> and oops_in_progress.

Thanks for your review  Richard. Will add flag to let low level
controller drivers know that that its a panic_write and make brcmnand
code more generic and simply fallback to pio and polling in such a
case. Will send a V2 patch with these recommended changes.


> --
> Thanks,
> //richard

Linux MTD discussion mailing list

      reply index

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-01 17:46 Kamal Dasu
2019-05-02  8:25 ` Miquel Raynal
2019-05-02 14:09   ` Kamal Dasu
2019-05-06 16:01 ` Richard Weinberger
2019-05-16 14:47   ` Kamal Dasu [this message]

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='' \ \ \ \ \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-mtd Archive on

Archives are clonable:
	git clone --mirror linux-mtd/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-mtd linux-mtd/ \
	public-inbox-index linux-mtd

Newsgroup available over NNTP:

AGPL code for this site: git clone public-inbox