From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Cc: "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
linux-spi <linux-spi@vger.kernel.org>,
Chris Brandt <chris.brandt@renesas.com>,
Rob Herring <robh+dt@kernel.org>,
"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
Philipp Zabel <p.zabel@pengutronix.de>,
Mason Yang <masonccyang@mxic.com.tw>
Subject: Re: [PATCH v3 1/2] dt-bindings: memory: document Renesas RPC-IF bindings
Date: Mon, 18 May 2020 23:23:15 +0200 [thread overview]
Message-ID: <CAMuHMdVg4=1JA2x4PN6Y4cE_WJ9LSZUTi0hyxUqiUWujv8Z3pg@mail.gmail.com> (raw)
In-Reply-To: <f998fe6c-c586-17cb-9343-30460ce0bf9d@cogentembedded.com>
Hi Sergei,
On Mon, May 18, 2020 at 10:33 PM Sergei Shtylyov
<sergei.shtylyov@cogentembedded.com> wrote:
> Renesas Reduced Pin Count Interface (RPC-IF) allows a SPI flash or
> HyperFlash connected to the SoC to be accessed via the external address
> space read mode or the manual mode.
>
> Document the device tree bindings for the Renesas RPC-IF found in the R-Car
> gen3 SoCs.
>
> Based on the original patch by Mason Yang <masonccyang@mxic.com.tw>.
>
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Thanks for your patch!
> --- /dev/null
> +++ linux/Documentation/devicetree/bindings/memory-controllers/renesas,rpc-if.yaml
> @@ -0,0 +1,88 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/memory-controllers/renesas,rpc-if.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Renesas Reduced Pin Count Interface (RPC-IF)
> +
> +maintainers:
> + - Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> +
> +description: |
> + Renesas RPC-IF allows a SPI flash or HyperFlash connected to the SoC to
> + be accessed via the external address space read mode or the manual mode.
> +
> + The flash chip itself should be represented by a subnode of the RPC-IF node.
> + The flash interface is selected based on the "compatible" property of this
> + subnode:
> + - if it contains "jedec,spi-nor", then SPI is used;
> + - if it contains "cfi-flash", then HyperFlash is used.
> +
> +allOf:
> + - $ref: "/schemas/spi/spi-controller.yaml#"
> +
> +properties:
> + compatible:
> + items:
> + - enum:
> + - renesas,r8a77980-rpc-if
Usually we add a comment with the SoC name, e.g. "# R-Car V3H"
> + - renesas,r8a77995-rpc-if
> + - enum:
> + - renesas,rcar-gen3-rpc-if # a generic R-Car gen3 device
No need for an enum, just use "- const: renesas,rcar-gen3-rpc-if".
> +examples:
> + - |
> + #include <dt-bindings/clock/renesas-cpg-mssr.h>
> + #include <dt-bindings/power/r8a77995-sysc.h>
> +
> + spi@ee200000 {
> + compatible = "renesas,r8a77995-rpc-if", "renesas,rcar-gen3-rpc-if";
> + reg = <0 0xee200000 0 0x200>,
> + <0 0x08000000 0 0x4000000>,
> + <0 0xee208000 0 0x100>;
Examples are built with #{address,size}-cells = <1>, so please drop
the zeroes.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2020-05-18 21:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-18 20:31 [PATCH v3 0/2] Add Renesas RPC-IF support Sergei Shtylyov
2020-05-18 20:33 ` [PATCH v3 1/2] dt-bindings: memory: document Renesas RPC-IF bindings Sergei Shtylyov
2020-05-18 21:23 ` Geert Uytterhoeven [this message]
2020-05-19 17:36 ` Rob Herring
2020-05-18 20:34 ` [PATCH v3 2/2] memory: add Renesas RPC-IF driver Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMuHMdVg4=1JA2x4PN6Y4cE_WJ9LSZUTi0hyxUqiUWujv8Z3pg@mail.gmail.com' \
--to=geert@linux-m68k.org \
--cc=chris.brandt@renesas.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-spi@vger.kernel.org \
--cc=masonccyang@mxic.com.tw \
--cc=p.zabel@pengutronix.de \
--cc=robh+dt@kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).