From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Cc: "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>, Mark Brown <broonie@kernel.org>,
linux-spi <linux-spi@vger.kernel.org>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
Chris Brandt <chris.brandt@renesas.com>,
Rob Herring <robh+dt@kernel.org>,
MTD Maling List <linux-mtd@lists.infradead.org>,
Philipp Zabel <p.zabel@pengutronix.de>,
Mason Yang <masonccyang@mxic.com.tw>
Subject: Re: [PATCH v5 1/2] dt-bindings: memory: document Renesas RPC-IF bindings
Date: Tue, 7 Jul 2020 11:33:07 +0200 [thread overview]
Message-ID: <CAMuHMdVnjE=BHe5MBr_NsL6LeXq30vKym8OVLp28=7sZeUBAWw@mail.gmail.com> (raw)
In-Reply-To: <54a84c75-fa17-9976-d9a6-a69ef67c418b@cogentembedded.com>
Hi Sergei,
On Tue, Jun 16, 2020 at 10:01 PM Sergei Shtylyov
<sergei.shtylyov@cogentembedded.com> wrote:
> Renesas Reduced Pin Count Interface (RPC-IF) allows a SPI flash or
> HyperFlash connected to the SoC to be accessed via the external address
> space read mode or the manual mode.
>
> Document the device tree bindings for the Renesas RPC-IF found in the R-Car
> gen3 SoCs.
>
> Based on the original patch by Mason Yang <masonccyang@mxic.com.tw>.
>
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Thanks for your patch!
> --- /dev/null
> +++ linux/Documentation/devicetree/bindings/memory-controllers/renesas,rpc-if.yaml
> @@ -0,0 +1,88 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/memory-controllers/renesas,rpc-if.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Renesas Reduced Pin Count Interface (RPC-IF)
> +
> +maintainers:
> + - Sergei Shtylyov <sergei.shtylyov@gmail.com>
> +
> +description: |
> + Renesas RPC-IF allows a SPI flash or HyperFlash connected to the SoC to
> + be accessed via the external address space read mode or the manual mode.
> +
> + The flash chip itself should be represented by a subnode of the RPC-IF node.
> + The flash interface is selected based on the "compatible" property of this
> + subnode:
> + - if it contains "jedec,spi-nor", then SPI is used;
> + - if it contains "cfi-flash", then HyperFlash is used.
> +patternProperties:
> + "flash@[0-9a-f]+$":
> + type: object
> + properties:
> + compatible:
> + enum:
> + - cfi-flash
> + - jedec,spi-nor
The above does not allow specifying e.g.
compatible = "spansion,s25fs512s", "jedec,spi-nor";
arch/arm64/boot/dts/renesas/r8a77970-eagle.dt.yaml: spi@ee200000:
flash@0:compatible: Additional items are not allowed ('jedec,spi-nor'
was unexpected)
arch/arm64/boot/dts/renesas/r8a77970-eagle.dt.yaml: spi@ee200000:
flash@0:compatible:0: 'spansion,s25fs512s' is not one of ['cfi-flash',
'jedec,spi-nor']
> +
> +examples:
> + - |
> + #include <dt-bindings/clock/renesas-cpg-mssr.h>
> + #include <dt-bindings/power/r8a77995-sysc.h>
> +
> + spi@ee200000 {
> + compatible = "renesas,r8a77995-rpc-if", "renesas,rcar-gen3-rpc-if";
> + reg = <0xee200000 0x200>,
> + <0x08000000 0x4000000>,
> + <0xee208000 0x100>;
> + reg-names = "regs", "dirmap", "wbuf";
> + clocks = <&cpg CPG_MOD 917>;
> + power-domains = <&sysc R8A77995_PD_ALWAYS_ON>;
> + resets = <&cpg 917>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + flash@0 {
> + compatible = "jedec,spi-nor";
... which you nicely circumvented in the example ;-)
> + reg = <0>;
> + spi-max-frequency = <40000000>;
> + spi-tx-bus-width = <1>;
> + spi-rx-bus-width = <1>;
> + };
> + };
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2020-07-07 9:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-16 20:00 [PATCH v5 0/2] Add Renesas RPC-IF support Sergei Shtylyov
2020-06-16 20:01 ` [PATCH v5 1/2] dt-bindings: memory: document Renesas RPC-IF bindings Sergei Shtylyov
2020-07-07 9:33 ` Geert Uytterhoeven [this message]
2020-06-16 20:03 ` [PATCH v5 2/2] memory: add Renesas RPC-IF driver Sergei Shtylyov
2020-07-01 22:24 ` [PATCH v5 0/2] Add Renesas RPC-IF support Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMuHMdVnjE=BHe5MBr_NsL6LeXq30vKym8OVLp28=7sZeUBAWw@mail.gmail.com' \
--to=geert@linux-m68k.org \
--cc=broonie@kernel.org \
--cc=chris.brandt@renesas.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=masonccyang@mxic.com.tw \
--cc=p.zabel@pengutronix.de \
--cc=robh+dt@kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).