From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C04CC4CEC9 for ; Tue, 17 Sep 2019 21:24:14 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 205782054F for ; Tue, 17 Sep 2019 21:24:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="lQ4N/Z3j" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 205782054F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-m68k.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=mnYSwyVg94MoikM3tDbB5cDyiuxICKSxW9gjpqWFo10=; b=lQ4N/Z3j8T43t/ OApS+LJ+YWSrRSrckKgeOHPdP3gitrprOvJ+xm2OyYeRhKZBwOjB3AePDYHJDMR5/Y4rkWbZ4dKJI OeNsQU5vi5k66DRtuC2cB8Z4gwfQVzuD0zP8VwGw0gMRapxUeAfO1wpbIdOVdtjIJNcVVza7fWs43 T4MDROjVriMQW0glJxStL/S+uAtQJj6tGwFnPN5ho2PhpYdH+RoFqvDJscqLAZqHlUZX4IdDW4Tq4 Ktj++W6jyOE/BimbpGZDt+3/tjIHqlrxmmQ53y1jqvpTRKppk6MOA5VlYkspX4cSFNx3pndVRG0En +/ICqK6XY9jk/OGBzvTg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.2 #3 (Red Hat Linux)) id 1iAKxG-0002BD-DN; Tue, 17 Sep 2019 21:24:10 +0000 Received: from mail-oi1-f193.google.com ([209.85.167.193]) by bombadil.infradead.org with esmtps (Exim 4.92.2 #3 (Red Hat Linux)) id 1iAKxC-0002Aq-LB for linux-mtd@lists.infradead.org; Tue, 17 Sep 2019 21:24:08 +0000 Received: by mail-oi1-f193.google.com with SMTP id w144so4194686oia.6 for ; Tue, 17 Sep 2019 14:24:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Ap24xjPWfCGB8lsHh+GC/IbtHCCeIcA2yTF7XA6OtUk=; b=P7QsA0C5hM+haFPJcpI1Yw8YAdBEiye8Q7LmU3Lk8QC/cG/kzhQTuKfbQ/Od5opByJ ja+pku6O7IevU+RKuj3uSeEMrgB39t5WrjefDryEVLU6jOFsMtWftjNw2Z7phzk6rYvy Rp6/wvEglH6CztH7UQeIFrCc4iqfzGWC3JaOP0fl6i2TtfElqvvmDzQBkhyo2f2SaOrQ GZuYjxZQDgjzuGCV120H2XGN7nCAvdeS4cqdih8/fJeapV4+T3vNQ5FXP9mCAHnh9828 pwsYolJuCQTh9kW86CXEfTOomAVpler39EcU+2XwA7HZhEXV/C12rBlOMOuu6FFJ/O4c PYGg== X-Gm-Message-State: APjAAAVFEJRLL/FR2N9HnjPHzmeGuwzMcRO0A1Y+zabYB3VDmCduAhNY e9K2KC29o8wrqSFrmgkLdxWGmENK5XeE/rsvy2E= X-Google-Smtp-Source: APXvYqzz/iohYneGVtTS7wC0CKuDB7uEzHxadYx0bqHzRRJxBysBydVNjXQrSQj/LE4/J9D2u5CBMEKOWCRjSo7Ufbg= X-Received: by 2002:aca:3908:: with SMTP id g8mr140666oia.54.1568755445280; Tue, 17 Sep 2019 14:24:05 -0700 (PDT) MIME-Version: 1.0 References: <610761cf-5a19-c182-07d8-8d118ca20035@cogentembedded.com> <90d87853-621f-890a-be59-1591cfe1f4ea@cogentembedded.com> In-Reply-To: <90d87853-621f-890a-be59-1591cfe1f4ea@cogentembedded.com> From: Geert Uytterhoeven Date: Tue, 17 Sep 2019 23:23:53 +0200 Message-ID: Subject: Re: [PATCH] mtd: cfi_util: use DIV_ROUND_UP() in cfi_udelay() To: Sergei Shtylyov X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190917_142406_694623_F681160D X-CRM114-Status: GOOD ( 10.90 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Vignesh Raghavendra , Richard Weinberger , Marek Vasut , MTD Maling List , Miquel Raynal , Brian Norris , David Woodhouse Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org Hi Sergei, On Tue, Sep 17, 2019 at 9:53 PM Sergei Shtylyov wrote: > On 09/17/2019 10:43 PM, Geert Uytterhoeven wrote: > >> cfi_udelay() open-codes DIV_ROUND_UP(), violating the kernel coding style > > > > Perhaps "violating" sounds a bit too harsh? > > Hm, indeed, scripts/checkpatch.pl doesn't complain on this line. Do you have > other ideas how to call this? Or just omit this? Just "use the existing helper, instead of open-coding the same operation"? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/