From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6EEF7C3A5A1 for ; Wed, 28 Aug 2019 08:58:33 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 41B5320578 for ; Wed, 28 Aug 2019 08:58:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="U1VyVNAH"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="c/7IxRS5" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 41B5320578 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=TFZDxsH9AEkwqAWNUH+UkrT6Em3EVPVpDEDen8dxBKQ=; b=U1VyVNAHurfRKe 6Hp70RknP8H2MHT8cV1xHCIlbO+PC4ymDLfPwIb5LCQCthHMkJpzU9rPEc6qt88DxNDHOxqZx5n3t s2Nc6ywTb0WA8Q31sH7JKWTsCo1QasS3VGR9WtCpRo7J6agF/6e9ml5VrL9KxLx4AICKeiQfJ8FgN ZvUm6wqL11PaJiBITlXVQ/iBUdpgVQTRneVN4aBTTe7oxaFM79DkyIu432ImNTy8/10PggYSyCmoY eYIalJYdDAzxzKiinbUhx9X0POyeZfGEmDptaZe2zEYmjBt0EgINnMsDbPnUjgxxFbKc3RnwUnrTE 4L8BiwHvRZ11UbWIXA2Q==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1i2tme-0004RR-FP; Wed, 28 Aug 2019 08:58:28 +0000 Received: from mail-yb1-xb43.google.com ([2607:f8b0:4864:20::b43]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1i2tmb-0004Qr-BW; Wed, 28 Aug 2019 08:58:26 +0000 Received: by mail-yb1-xb43.google.com with SMTP id 1so541749ybj.8; Wed, 28 Aug 2019 01:58:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ZkpFpnYPlZJ9QcxAWETe0exvhhGufV9GcXx8KPl75dQ=; b=c/7IxRS5bV7/Y1D6aqVDN4h5XY8CLwleVTKbXnD1xvkPuYpdCL6KG1pUCZedAgswVL jl/Y/H3TL3Y7v26WGEvK2/K7kQDXltg3Gh1B2bsEXgA+f3ZfuZKs0Owowo137ADQO4O+ cpzdYN/uTyuwxI00FWQlSRJrDeSiVoypEr2jK5PPgACNzrThi9kqlMgnjpNIbvs06isz sSk1xx9N3A6v0UgaCkxeg+WxsqAscnJ0NMP/ilLoKpdluNCBKsgYaS4spNoOe+kfNZNB 7XBDgWqpy6pn08EBwgtZBm+9GjktdL94w9YatMNYYgi1jW7re8aGyyVgQPga7XhLViSE j9Cg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ZkpFpnYPlZJ9QcxAWETe0exvhhGufV9GcXx8KPl75dQ=; b=t+1kQQXD8k/Ua4SP72K6Z2XZ6fHBOkNtcCgqqdgyLOCLjW3KQv77fF7sqyxV9X1Sy8 efQgTvyGwABIafIVpGiUEX1T9zAc+Jp2MQZLZ3hYIy1HN69lORUQpXTdz7W9SWJygzLJ ql//7mwahJaAVkz6gVlgOv06QxLTLXgZ2RSteQgUqEtef2YYbfR7DcMMUKNPjzovwrAh WkSRGFS3dpkexUdu1ZHxlLqOkHWiW9iaesyOUfTmgrUvNAKWsRoLv1k+IRmawZrap2yq pwRURCOLtGJdf1W9o6Tm1ei6fiY5rzQfP3MWuIbKj0SjVhAeqZWFmR9Z/Tw3VW6AgIk/ a7VQ== X-Gm-Message-State: APjAAAV7gvEKRQSqWxZD/mRBMQ3gVeSPLZhZPf893EFLRBNVl0H/DZTU PI5OKncunSLodNNQPyoI6tjXF4PlqJT6fYq06io= X-Google-Smtp-Source: APXvYqzSub2GIlA5tBXI/WsJGtSH+6zioYqDGzlUhxxxj30lJtRuCO2Hlbsd4xVOf5z0HjodsXgoZMdYp6cwy9sWUoQ= X-Received: by 2002:a25:c486:: with SMTP id u128mr2051352ybf.428.1566982703595; Wed, 28 Aug 2019 01:58:23 -0700 (PDT) MIME-Version: 1.0 References: <20190820180716.129882-1-salyzyn@android.com> <20190827141952.GB10098@quack2.suse.cz> In-Reply-To: <20190827141952.GB10098@quack2.suse.cz> From: Amir Goldstein Date: Wed, 28 Aug 2019 11:58:12 +0300 Message-ID: Subject: Re: [PATCH v7] Add flags option to get xattr method paired to __vfs_getxattr To: Mark Salyzyn X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190828_015825_421057_866E2AF8 X-CRM114-Status: GOOD ( 12.38 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Latchesar Ionkov , Eric Sandeen , Mike Marshall , linux-xfs , James Morris , devel@lists.orangefs.org, Eric Van Hensbergen , Joel Becker , Trond Myklebust , Mathieu Malaterre , Greg Kroah-Hartman , linux-kernel , Jan Kara , linux-fsdevel , Andrew Morton , Dave Kleikamp , linux-doc@vger.kernel.org, Jeff Layton , Chao Yu , Mimi Zohar , "David S. Miller" , CIFS , Paul Moore , "Darrick J. Wong" , Hugh Dickins , kernel-team@android.com, selinux@vger.kernel.org, Brian Foster , reiserfs-devel@vger.kernel.org, Casey Schaufler , Jaegeuk Kim , Theodore Ts'o , Miklos Szeredi , linux-f2fs-devel@lists.sourceforge.net, Benjamin Coddington , linux-integrity , Martin Brandenburg , Chris Mason , linux-mtd@lists.infradead.org, linux-afs@lists.infradead.org, Jonathan Corbet , Vyacheslav Dubeyko , Allison Henderson , Ilya Dryomov , Ext4 , Stephen Smalley , Serge Hallyn , Gao Xiang , Eric Paris , ceph-devel@vger.kernel.org, Linux NFS Mailing List , Linux MM , samba-technical , Steve French , Bob Peterson , Tejun Heo , linux-erofs@lists.ozlabs.org, Anna Schumaker , ocfs2-devel@oss.oracle.com, jfs-discussion@lists.sourceforge.net, Jan Kara , Eric Biggers , Dominique Martinet , Jeff Mahoney , Adrian Hunter , David Howells , Joseph Qi , Andreas Dilger , devel@driverdev.osuosl.org, "J. Bruce Fields" , Andreas Gruenbacher , Sage Weil , Richard Weinberger , Mark Fasheh , =?UTF-8?Q?Ernesto_A=2E_Fern=C3=A1ndez?= , cluster-devel@redhat.com, v9fs-developer@lists.sourceforge.net, Bharath Vedartham , Jann Horn , ecryptfs@vger.kernel.org, Josef Bacik , Dave Chinner , David Sterba , Artem Bityutskiy , Netdev , overlayfs , stable , Tyler Hicks , LSM List , Phillip Lougher , David Woodhouse , Linux Btrfs , Alexander Viro Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org On Wed, Aug 28, 2019 at 11:15 AM Jan Kara via samba-technical wrote: > > On Tue 20-08-19 11:06:48, Mark Salyzyn wrote: > > diff --git a/Documentation/filesystems/Locking b/Documentation/filesystems/Locking > > index 204dd3ea36bb..e2687f21c7d6 100644 > > --- a/Documentation/filesystems/Locking > > +++ b/Documentation/filesystems/Locking > > @@ -101,12 +101,10 @@ of the locking scheme for directory operations. > > ----------------------- xattr_handler operations ----------------------- > > prototypes: > > bool (*list)(struct dentry *dentry); > > - int (*get)(const struct xattr_handler *handler, struct dentry *dentry, > > - struct inode *inode, const char *name, void *buffer, > > - size_t size); > > - int (*set)(const struct xattr_handler *handler, struct dentry *dentry, > > - struct inode *inode, const char *name, const void *buffer, > > - size_t size, int flags); > > + int (*get)(const struct xattr_handler *handler, > > + struct xattr_gs_flags); > > + int (*set)(const struct xattr_handler *handler, > > + struct xattr_gs_flags); > > The prototype here is really "struct xattr_gs_flags *args", isn't it? > Otherwise feel free to add: > > Reviewed-by: Jan Kara > > for the ext2, ext4, ocfs2, reiserfs, and the generic fs/* bits. > > Honza Mark, That's some CC list you got there... but I never got any of your patches because they did not reach fsdevel list. Did you get a rejection message from ML server? Thanks, Amir. ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/