From: Mike Marshall <hubcap@omnibond.com>
To: Mark Salyzyn <salyzyn@android.com>
Cc: Latchesar Ionkov <lucho@ionkov.net>,
Hugh Dickins <hughd@google.com>, James Morris <jmorris@namei.org>,
Christoph Hellwig <hch@infradead.org>,
devel@lists.orangefs.org, Eric Van Hensbergen <ericvh@gmail.com>,
Joel Becker <jlbec@evilplan.org>,
Anna Schumaker <anna.schumaker@netapp.com>,
Trond Myklebust <trond.myklebust@hammerspace.com>,
Mathieu Malaterre <malat@debian.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
LKML <linux-kernel@vger.kernel.org>, Jan Kara <jack@suse.com>,
Casey Schaufler <casey@schaufler-ca.com>,
Andrew Morton <akpm@linux-foundation.org>,
Dave Kleikamp <shaggy@kernel.org>,
linux-doc@vger.kernel.org, Jeff Layton <jlayton@kernel.org>,
Chao Yu <yuchao0@huawei.com>, Mimi Zohar <zohar@linux.ibm.com>,
linux-cifs@vger.kernel.org, Paul Moore <paul@paul-moore.com>,
"Darrick J. Wong" <darrick.wong@oracle.com>,
Eric Sandeen <sandeen@sandeen.net>,
kernel-team@android.com, selinux@vger.kernel.org,
Brian Foster <bfoster@redhat.com>,
reiserfs-devel@vger.kernel.org, Tejun Heo <tj@kernel.org>,
Jaegeuk Kim <jaegeuk@kernel.org>, Theodore Ts'o <tytso@mit.edu>,
Miklos Szeredi <miklos@szeredi.hu>,
"Linux F2FS DEV,
Mailing List" <linux-f2fs-devel@lists.sourceforge.net>,
Benjamin Coddington <bcodding@redhat.com>,
linux-integrity@vger.kernel.org,
Martin Brandenburg <martin@omnibond.com>,
Chris Mason <clm@fb.com>,
linux-mtd <linux-mtd@lists.infradead.org>,
linux-afs@lists.infradead.org, Jonathan Corbet <corbet@lwn.net>,
Vyacheslav Dubeyko <slava@dubeyko.com>,
Allison Henderson <allison.henderson@oracle.com>,
Ilya Dryomov <idryomov@gmail.com>,
Ext4 Developers List <linux-ext4@vger.kernel.org>,
Stephen Smalley <sds@tycho.nsa.gov>,
Serge Hallyn <serge@hallyn.com>,
Gao Xiang <gaoxiang25@huawei.com>,
Eric Paris <eparis@parisplace.org>,
ceph-devel <ceph-devel@vger.kernel.org>,
Linux NFS Mailing List <linux-nfs@vger.kernel.org>,
linux-mm <linux-mm@kvack.org>,
samba-technical@lists.samba.org, linux-xfs@vger.kernel.org,
Bob Peterson <rpeterso@redhat.com>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
linux-erofs@lists.ozlabs.org,
"David S. Miller" <davem@davemloft.net>,
ocfs2-devel@oss.oracle.com, jfs-discussion@lists.sourceforge.net,
Jan Kara <jack@suse.cz>, Eric Biggers <ebiggers@google.com>,
Dominique Martinet <asmadeus@codewreck.org>,
Adrian Hunter <adrian.hunter@intel.com>,
David Howells <dhowells@redhat.com>,
Joseph Qi <joseph.qi@linux.alibaba.com>,
Andreas Dilger <adilger.kernel@dilger.ca>,
devel@driverdev.osuosl.org,
"J. Bruce Fields" <bfields@redhat.com>,
Andreas Gruenbacher <agruenba@redhat.com>,
Sage Weil <sage@redhat.com>, Richard Weinberger <richard@nod.at>,
Mark Fasheh <mark@fasheh.com>,
cluster-devel@redhat.com, Steve French <sfrench@samba.org>,
V9FS Developers <v9fs-developer@lists.sourceforge.net>,
Bharath Vedartham <linux.bhar@gmail.com>,
Jann Horn <jannh@google.com>,
ecryptfs@vger.kernel.org, Josef Bacik <josef@toxicpanda.com>,
Dave Chinner <dchinner@redhat.com>,
David Sterba <dsterba@suse.com>,
Artem Bityutskiy <dedekind1@gmail.com>,
netdev@vger.kernel.org, linux-unionfs@vger.kernel.org,
stable@vger.kernel.org, Tyler Hicks <tyhicks@canonical.com>,
linux-security-module@vger.kernel.org,
Phillip Lougher <phillip@squashfs.org.uk>,
David Woodhouse <dwmw2@infradead.org>,
linux-btrfs@vger.kernel.org,
Alexander Viro <viro@zeniv.linux.org.uk>
Subject: Re: [PATCH v8] Add flags option to get xattr method paired to __vfs_getxattr
Date: Thu, 29 Aug 2019 21:24:38 -0400 [thread overview]
Message-ID: <CAOg9mSTCC4Z3RpEyppC50B+pnSBbV0sr-F7hbsM-B+z3c-AZVA@mail.gmail.com> (raw)
In-Reply-To: <5dd09a38-fffb-36f2-505b-be2ddf6bb750@android.com>
I added this patch series on top of Linux 5.3-rc6 and ran xfstests
on orangefs with no regressions.
Acked-by: Mike Marshall <hubcap@omnibond.com>
-Mike
On Wed, Aug 28, 2019 at 10:40 AM Mark Salyzyn <salyzyn@android.com> wrote:
>
> On 8/28/19 7:24 AM, Christoph Hellwig wrote:
> > On Tue, Aug 27, 2019 at 08:05:15AM -0700, Mark Salyzyn wrote:
> >> Replace arguments for get and set xattr methods, and __vfs_getxattr
> >> and __vfs_setaxtr functions with a reference to the following now
> >> common argument structure:
> > Yikes. That looks like a mess. Why can't we pass a kernel-only
> > flag in the existing flags field for ₋>set and add a flags field
> > to ->get? Passing methods by structure always tends to be a mess.
>
> This was a response to GregKH@ criticism, an earlier patch set just
> added a flag as you stated to get method, until complaints of an
> excessively long argument list and fragility to add or change more
> arguments.
>
> So many ways have been tried to skin this cat ... the risk was taken to
> please some, and we now have hundreds of stakeholders, when the first
> patch set was less than a dozen. A recipe for failure?
>
> -- Mark
>
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
prev parent reply other threads:[~2019-08-30 1:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-27 15:05 [PATCH v8] Add flags option to get xattr method paired to __vfs_getxattr Mark Salyzyn
2019-08-27 15:49 ` Jeff Layton
2019-08-27 17:07 ` David Sterba
2019-08-27 21:35 ` Darrick J. Wong
2019-08-28 14:24 ` Christoph Hellwig
2019-08-28 14:40 ` Mark Salyzyn
2019-08-30 1:24 ` Mike Marshall [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOg9mSTCC4Z3RpEyppC50B+pnSBbV0sr-F7hbsM-B+z3c-AZVA@mail.gmail.com \
--to=hubcap@omnibond.com \
--cc=adilger.kernel@dilger.ca \
--cc=adrian.hunter@intel.com \
--cc=agruenba@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=allison.henderson@oracle.com \
--cc=anna.schumaker@netapp.com \
--cc=asmadeus@codewreck.org \
--cc=bcodding@redhat.com \
--cc=bfields@redhat.com \
--cc=bfoster@redhat.com \
--cc=casey@schaufler-ca.com \
--cc=ceph-devel@vger.kernel.org \
--cc=clm@fb.com \
--cc=cluster-devel@redhat.com \
--cc=corbet@lwn.net \
--cc=darrick.wong@oracle.com \
--cc=davem@davemloft.net \
--cc=dchinner@redhat.com \
--cc=dedekind1@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=devel@lists.orangefs.org \
--cc=dhowells@redhat.com \
--cc=dsterba@suse.com \
--cc=dwmw2@infradead.org \
--cc=ebiggers@google.com \
--cc=ecryptfs@vger.kernel.org \
--cc=eparis@parisplace.org \
--cc=ericvh@gmail.com \
--cc=gaoxiang25@huawei.com \
--cc=gregkh@linuxfoundation.org \
--cc=hch@infradead.org \
--cc=hughd@google.com \
--cc=idryomov@gmail.com \
--cc=jack@suse.com \
--cc=jack@suse.cz \
--cc=jaegeuk@kernel.org \
--cc=jannh@google.com \
--cc=jfs-discussion@lists.sourceforge.net \
--cc=jlayton@kernel.org \
--cc=jlbec@evilplan.org \
--cc=jmorris@namei.org \
--cc=josef@toxicpanda.com \
--cc=joseph.qi@linux.alibaba.com \
--cc=kernel-team@android.com \
--cc=linux-afs@lists.infradead.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-erofs@lists.ozlabs.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-nfs@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=linux-unionfs@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=linux.bhar@gmail.com \
--cc=lucho@ionkov.net \
--cc=malat@debian.org \
--cc=mark@fasheh.com \
--cc=martin@omnibond.com \
--cc=miklos@szeredi.hu \
--cc=netdev@vger.kernel.org \
--cc=ocfs2-devel@oss.oracle.com \
--cc=paul@paul-moore.com \
--cc=phillip@squashfs.org.uk \
--cc=reiserfs-devel@vger.kernel.org \
--cc=richard@nod.at \
--cc=rpeterso@redhat.com \
--cc=sage@redhat.com \
--cc=salyzyn@android.com \
--cc=samba-technical@lists.samba.org \
--cc=sandeen@sandeen.net \
--cc=sds@tycho.nsa.gov \
--cc=selinux@vger.kernel.org \
--cc=serge@hallyn.com \
--cc=sfrench@samba.org \
--cc=shaggy@kernel.org \
--cc=slava@dubeyko.com \
--cc=stable@vger.kernel.org \
--cc=tj@kernel.org \
--cc=trond.myklebust@hammerspace.com \
--cc=tyhicks@canonical.com \
--cc=tytso@mit.edu \
--cc=v9fs-developer@lists.sourceforge.net \
--cc=viro@zeniv.linux.org.uk \
--cc=yuchao0@huawei.com \
--cc=zohar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).