From: ron minnich <rminnich@gmail.com>
To: Miquel Raynal <miquel.raynal@bootlin.com>
Cc: Richard Weinberger <richard@nod.at>,
Boris Brezillon <boris.brezillon@collabora.com>,
linux-mtd@lists.infradead.org,
Vignesh Raghavendra <vigneshr@ti.com>,
Tudor Ambarus <tudor.ambarus@microchip.com>
Subject: Re: [PATCH 1/1] mtd: add | as a separator after mtd-id
Date: Sun, 22 Mar 2020 08:42:07 -0700 [thread overview]
Message-ID: <CAP6exYJoQNHheoe0zr2yy+f+9SYEM2=ExE_A-TfTsRbhLpF7pA@mail.gmail.com> (raw)
In-Reply-To: <20200322120911.70af403c@xps13>
I agree with you on changing the PCI driver name, as opposed to this
change. I don't like '|' very much either.
I am thinking just to change ':' to '.', e.g.
0000:00:1f.3 -> 0000.00.1f.3
It is an extremely simple change -- add one for loop in the pci map
code -- and nothing else need change.
If this sounds good to you, I'll send a new 2-patch series with that
change and with the intel-spi driver changed to show how one can use
command line partitioning?
Also, as I am coming back to this after a very long time, how do you
like your patch series to look? It seems the git command to generate
these creates 3 files, the first numbered 0 with no code in it. My
reading of the docs implies sending this no-code email is not a good
idea? Any recommendations here?
thanks very much for your comment!
ron
On Sun, Mar 22, 2020 at 4:09 AM Miquel Raynal <miquel.raynal@bootlin.com> wrote:
>
> Hi Ronald,
>
> ron minnich <rminnich@gmail.com> wrote on Sat, 21 Mar 2020 08:44:07
> -0700:
>
> > Anyone? This will be going into use at Google internally and I'd like
> > to get it upstream.
> >
> > The only other option that would work is to take the pci-format names
> > created by intel-spi-pci that have : in them and change the : to '.'.
> > Is that more acceptable?
>
> One important thing to note: Bootloaders share the same mtdparts
> definition and should be updated if we decide to support a new
> separator. U-boot and Barebox at least.
>
> I think changing just Intel's PCI driver name would be much more
> practical for us because I don't find the '|' separator being
> descriptive at all.
>
> However, I don't have a strong position and I would welcome
> Richard, Vignesh, Tudor and Boris' point of view.
>
> Thanks,
> Miquèl
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2020-03-22 15:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-20 20:21 [PATCH 1/1] mtd: add | as a separator after mtd-id ron minnich
2020-03-21 15:44 ` ron minnich
2020-03-22 11:09 ` Miquel Raynal
2020-03-22 15:42 ` ron minnich [this message]
2020-03-22 16:00 ` ron minnich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAP6exYJoQNHheoe0zr2yy+f+9SYEM2=ExE_A-TfTsRbhLpF7pA@mail.gmail.com' \
--to=rminnich@gmail.com \
--cc=boris.brezillon@collabora.com \
--cc=linux-mtd@lists.infradead.org \
--cc=miquel.raynal@bootlin.com \
--cc=richard@nod.at \
--cc=tudor.ambarus@microchip.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).