From: ron minnich <rminnich@gmail.com>
To: Miquel Raynal <miquel.raynal@bootlin.com>
Cc: Richard Weinberger <richard@nod.at>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Vignesh Raghavendra <vigneshr@ti.com>,
linux-mtd@lists.infradead.org
Subject: Re: [PATCH 1/1] mtd/intel-spi: Support cmdline-based partition
Date: Fri, 27 Mar 2020 09:53:35 -0700 [thread overview]
Message-ID: <CAP6exYLi0OnDd92b0uoAYm5B4x=+2h2_g+NXRnOSYaxkRA04QA@mail.gmail.com> (raw)
In-Reply-To: <20200327171907.7a7ffc73@xps13>
Mika, I have to agree with your comment on parsing the name correctly,
but the pci syntax is sufficiently flexible that I expect it would
create an explosion in code size and complexity and that is a concern.
OTOH, I can think of a few options: we could require, for example,
that PCI names ALWAYS be in the form AAAA:BB:CC.D, and then the test
is a bit simpler: it's a PCI name if id[4] == ':' && id [7] == ':' &&
id[10] == '.', and we can break the id from the parts at id[12]; it it
is not a PCI id, we do a strchr as is done now.
That would mean I could just dump this admittedly ugly change. I admit
the test above is a bit nasty, but it's pretty reliable. WDYT?
Miquel, your patience with this patch as I learn how to contribute is
greatly appreciated. Thanks for the tips. My last real contribution to
Linux was over 15 years ago, with 9p, and the real upstreaming work on
that was done by others; the kernel community is all new to me.
I'm going to drop this patch and start over and try not to make such a
mess of it.
thanks again everyone
ron
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2020-03-27 16:53 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-23 19:58 [PATCH 1/1] mtd/intel-spi: Support cmdline-based partition ron minnich
2020-03-23 23:19 ` ron minnich
2020-03-25 17:34 ` ron minnich
2020-03-25 17:34 ` ron minnich
2020-03-27 15:48 ` ron minnich
2020-03-27 15:56 ` Mika Westerberg
2020-03-27 16:19 ` Miquel Raynal
2020-03-27 16:48 ` Mika Westerberg
2020-03-27 16:52 ` Miquel Raynal
2020-03-27 17:05 ` ron minnich
2020-03-27 17:16 ` Mika Westerberg
2020-03-27 17:39 ` ron minnich
2020-03-27 23:53 ` ron minnich
2020-03-30 6:08 ` Mika Westerberg
2020-03-30 7:27 ` Miquel Raynal
2020-03-30 15:53 ` ron minnich
2020-04-01 7:41 ` Miquel Raynal
2020-04-01 15:42 ` ron minnich
2020-04-01 19:49 ` ron minnich
2020-04-27 9:16 ` Boris Brezillon
2020-04-27 9:49 ` Boris Brezillon
2020-04-27 14:41 ` Miquel Raynal
2020-04-27 18:48 ` ron minnich
2020-04-27 18:50 ` ron minnich
2020-04-27 18:56 ` Miquel Raynal
2020-04-27 18:59 ` ron minnich
2020-04-27 19:21 ` Boris Brezillon
2020-04-27 19:31 ` ron minnich
2020-04-27 20:31 ` ron minnich
2020-04-27 21:20 ` Miquel Raynal
2020-03-27 16:53 ` ron minnich [this message]
2020-03-27 16:15 ` Miquel Raynal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAP6exYLi0OnDd92b0uoAYm5B4x=+2h2_g+NXRnOSYaxkRA04QA@mail.gmail.com' \
--to=rminnich@gmail.com \
--cc=linux-mtd@lists.infradead.org \
--cc=mika.westerberg@linux.intel.com \
--cc=miquel.raynal@bootlin.com \
--cc=richard@nod.at \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).