Linux-mtd Archive on lore.kernel.org
 help / color / Atom feed
From: Paul Cercueil <paul@crapouillou.net>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Vignesh Raghavendra <vigneshr@ti.com>,
	Richard Weinberger <richard@nod.at>,
	linux-kernel@vger.kernel.org,
	Krzysztof Kozlowski <krzk@kernel.org>,
	Harvey Hunt <harveyhuntnexus@gmail.com>,
	linux-mtd <linux-mtd@lists.infradead.org>,
	Miquel Raynal <miquel.raynal@bootlin.com>
Subject: Re: [PATCH v3 2/2] mtd: rawnand: ingenic: Limit MTD_NAND_JZ4780 to architecture only
Date: Sun, 26 Jul 2020 18:06:13 +0200
Message-ID: <DE33EQ.XSK1UTONAHU61@crapouillou.net> (raw)
In-Reply-To: <CAK8P3a0HDu15u5dREd6gk_e9D6mrZ9JqT0DJs9AeC9C2602nAw@mail.gmail.com>



Le sam. 25 juil. 2020 à 20:30, Arnd Bergmann <arnd@arndb.de> a écrit :
> On Sat, Jul 25, 2020 at 2:17 PM Paul Cercueil <paul@crapouillou.net> 
> wrote:
>>  Le ven. 24 juil. 2020 à 17:54, Krzysztof Kozlowski 
>> <krzk@kernel.org> a
>>  écrit :
>>  > On Fri, Jul 24, 2020 at 05:50:06PM +0200, Paul Cercueil wrote:
>>  >>  Le ven. 24 juil. 2020 à 17:33, Krzysztof Kozlowski
>>  >> <krzk@kernel.org> a écrit:
>>  >>  > On Fri, 24 Jul 2020 at 17:19, Paul Cercueil 
>> <paul@crapouillou.net>
>>  >>  > wrote:
>>  >>
>>  >>  On MIPS, the SoC selection is a Kconfig "choice", so you can 
>> only
>>  >> support
>>  >>  one SoC family, unfortunately.
>>  >
>>  > Let's say someone selected then some other architecture
>>  > (MIPS_ALCHEMY).
>>  > They could select this MTD driver.
>>  >
>>  > Does it mean they would be able to run it on Ingenic hardware?
>> 
>>  In *theory* yes, as long as the Kconfig options that MACH_INGENIC
>>  selects are enabled, the kernel should boot and work on Ingenic 
>> SoCs.
> 
> Right now, this won't work yet, because there are platform specific
> functions that are implemented by each of the platforms in arch/mips,
> e.g. arch/mips/generic/init.c and arch/mips/jz4740/setup.c.
> 
> A lot of the newer platforms are part of arch/mips/generic
> (CONFIG_MIPS_GENERIC), which roughly corresponds to
> CONFIG_ARCH_MULTIPLATFORM on in arch/arm/.
> Similarly, there are header files in arch/mips/include/asm/mach-*/
> that conflict and you need to have the right one.
> 
> To have more than one platform enabled, each one needs to
> have all of that platform code converted to fit into the
> MIPS_GENERIC framework. This can be a lot of work, but
> I suppose the ingenic platform would be a candidate for
> which this makes sense, as long as new SoCs of that family
> still come out.

It should be much less work now that the vast majority of 
arch/mips/jz4740 is gone. The code left is pretty much generic. I can 
have a look to convert it to the MIPS_GENERIC framework.

Although the code there is scary. Have a look at 
arch/mips/include/asm/{machine,mips_machine}.h, you'll see what I mean.

Anyway, I think we're way past the scope of this patch, so for this one:
Acked-by: Paul Cercueil <paul@crapouillou.net>

Cheers,
-Paul



______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

  reply index

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-24 14:53 [PATCH v3 0/2] mips: jz4780: Kconfig cleanup Krzysztof Kozlowski
2020-07-24 14:54 ` [PATCH v3 1/2] memory: jz4780-nemc: Limit dependency and compile testing to Ingenic architecture only Krzysztof Kozlowski
2020-07-24 14:54 ` [PATCH v3 2/2] mtd: rawnand: ingenic: Limit MTD_NAND_JZ4780 to " Krzysztof Kozlowski
2020-07-24 15:19   ` Paul Cercueil
2020-07-24 15:33     ` Krzysztof Kozlowski
2020-07-24 15:50       ` Paul Cercueil
2020-07-24 15:54         ` Krzysztof Kozlowski
2020-07-25 12:17           ` Paul Cercueil
2020-07-25 18:30             ` Arnd Bergmann
2020-07-26 16:06               ` Paul Cercueil [this message]
2020-07-26 16:06               ` Krzysztof Kozlowski
2020-07-26 16:12                 ` Paul Cercueil
2020-07-26 16:15                   ` Krzysztof Kozlowski
2020-07-26 16:20                     ` Paul Cercueil
2020-07-27  7:55                       ` Arnd Bergmann
2020-07-27 17:03                         ` Krzysztof Kozlowski
2020-07-27 17:12                           ` Paul Cercueil
2020-07-27 17:28                           ` Arnd Bergmann
2020-08-03  8:36                             ` Miquel Raynal
2020-08-03  8:39                               ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DE33EQ.XSK1UTONAHU61@crapouillou.net \
    --to=paul@crapouillou.net \
    --cc=arnd@arndb.de \
    --cc=harveyhuntnexus@gmail.com \
    --cc=krzk@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=miquel.raynal@bootlin.com \
    --cc=richard@nod.at \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-mtd Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-mtd/0 linux-mtd/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-mtd linux-mtd/ https://lore.kernel.org/linux-mtd \
		linux-mtd@lists.infradead.org
	public-inbox-index linux-mtd

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.infradead.lists.linux-mtd


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git